From 2fbb93fc11b3d67d062d55acb0abd4db8538b8ce Mon Sep 17 00:00:00 2001
From: Brian Wilkerson <brianwilkerson@google.com>
Date: Mon, 12 Dec 2022 18:12:57 +0000
Subject: [PATCH] Do not apply the fix for
 avoid_function_literals_in_foreach_calls when body is not sync

Change-Id: I0482c0d35a01afffd26073383b137697b829249c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274943
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
---
 .../dart/convert_for_each_to_for_loop.dart    |  3 +
 .../convert_for_each_to_for_loop_test.dart    | 66 +++++++++++++++++++
 2 files changed, 69 insertions(+)

diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_for_each_to_for_loop.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_for_each_to_for_loop.dart
index 610e19b67a8..349e22bbc3a 100644
--- a/pkg/analysis_server/lib/src/services/correction/dart/convert_for_each_to_for_loop.dart
+++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_for_each_to_for_loop.dart
@@ -52,6 +52,9 @@ class ConvertForEachToForLoop extends CorrectionProducer {
     }
     var target = utils.getNodeText(invocation.target!);
     var body = argument.body;
+    if (body.isAsynchronous || body.isGenerator) {
+      return;
+    }
     if (body is BlockFunctionBody) {
       await builder.addDartFileEdit(file, (builder) {
         builder.addReplacement(range.startStart(invocation, body), (builder) {
diff --git a/pkg/analysis_server/test/src/services/correction/fix/convert_for_each_to_for_loop_test.dart b/pkg/analysis_server/test/src/services/correction/fix/convert_for_each_to_for_loop_test.dart
index 75125ccb953..478b67acb45 100644
--- a/pkg/analysis_server/test/src/services/correction/fix/convert_for_each_to_for_loop_test.dart
+++ b/pkg/analysis_server/test/src/services/correction/fix/convert_for_each_to_for_loop_test.dart
@@ -129,6 +129,39 @@ void f(List<String> list) {
 ''');
   }
 
+  Future<void> test_blockBody_async() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) async {
+    e.length / 2;
+  });
+}
+''');
+    await assertNoFix();
+  }
+
+  Future<void> test_blockBody_asyncStar() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) async* {
+    e.length / 2;
+  });
+}
+''');
+    await assertNoFix();
+  }
+
+  Future<void> test_blockBody_syncStar() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) sync* {
+    e.length / 2;
+  });
+}
+''');
+    await assertNoFix();
+  }
+
   Future<void> test_expressionBody() async {
     await resolveTestCode('''
 void f(List<String> list) {
@@ -144,6 +177,39 @@ void f(List<String> list) {
 ''');
   }
 
+  Future<void> test_expressionBody_async() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) async => e.substring(3, 7));
+}
+''');
+    await assertNoFix();
+  }
+
+  Future<void> test_expressionBody_asyncStar() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) async* => e.substring(3, 7));
+}
+''');
+    await assertNoFix(
+        errorFilter: (error) =>
+            error.errorCode.name ==
+            LintNames.avoid_function_literals_in_foreach_calls);
+  }
+
+  Future<void> test_expressionBody_syncStar() async {
+    await resolveTestCode('''
+void f(List<String> list) {
+  list.forEach((e) sync* => e.substring(3, 7));
+}
+''');
+    await assertNoFix(
+        errorFilter: (error) =>
+            error.errorCode.name ==
+            LintNames.avoid_function_literals_in_foreach_calls);
+  }
+
   Future<void> test_return() async {
     await resolveTestCode('''
 void f(List<String> list) {