From 2c69fb1d5311ba873d8ec887e2504b67e08f16f3 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Sat, 6 Jun 2020 00:50:10 +0000 Subject: [PATCH] [vm] Update PRESUBMIT.py to also check for synchronized changes between runtime/tests/vm/{dart,dart_2} Change-Id: Iaa026a312933e14fd3d56acb4d89257efd40b6b1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150221 Reviewed-by: Alexander Markov Commit-Queue: Martin Kustermann --- PRESUBMIT.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 85551ac71ae..5f27094c01a 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -67,7 +67,10 @@ def _CheckNnbdTestSync(input_api, output_api): a test, the test's counterpart (if it exists at all) should be in the CL too. """ - DIRS = ["co19", "corelib", "ffi", "language", "lib", "standalone"] + DIRS = [ + "tests/co19", "tests/corelib", "tests/ffi", "tests/language", + "tests/lib", "tests/standalone", "runtime/tests/vm/dart" + ] files = [git_file.LocalPath() for git_file in input_api.AffectedTextFiles()] unsynchronized = [] @@ -75,8 +78,8 @@ def _CheckNnbdTestSync(input_api, output_api): if file.endswith('.status'): continue for dir in DIRS: - legacy_dir = "tests/{}_2/".format(dir) - nnbd_dir = "tests/{}/".format(dir) + legacy_dir = "{}_2/".format(dir) + nnbd_dir = "{}/".format(dir) counterpart = None if file.startswith(legacy_dir):