languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 15:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

TBR: bug fixes for switch from [] to JsNative.SetProperty Make calls to .isExternal property more robust

Browse source 
BUG=

Review URL: https://codereview.chromium.org/1419503008 .
This commit is contained in:
Jacob Richman 2015-11-04 17:47:03 -08:00
parent 6bfbb93d72
commit 2c6989df5f
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
sdk/lib/js/dartium/js_dartium.dart
View file

@ -310,8 +310,9 @@ String _getDeclarationName(mirrors.DeclarationMirror declaration) {
final _JS_LIBRARY_PREFIX = "js_library";
final _UNDEFINED_VAR = "_UNDEFINED_JS_CONST";
String _accessJsPath(String path) {
var parts = path.split(".");
String _accessJsPath(String path) => _accessJsPathHelper(path.split("."));
String _accessJsPathHelper(Iterable<String> parts) {
var sb = new StringBuffer();
sb
..write('${_JS_LIBRARY_PREFIX}.JsNative.getProperty(' * parts.length)
@ -322,11 +323,10 @@ String _accessJsPath(String path) {
return sb.toString();
}
String _accessJsPathSetter(String path) {
var parts = path.split(".");
return "${_JS_LIBRARY_PREFIX}.JsNative.setProperty(${_accessJsPath(parts.getRange(0, parts.length - 1).join('.'))
}, '{parts.end}', v)";
return "${_JS_LIBRARY_PREFIX}.JsNative.setProperty(${_accessJsPathHelper(parts.getRange(0, parts.length - 1))
}, '${parts.last}', v)";
}
@Deprecated("Internal Use Only")
@ -395,13 +395,12 @@ void addMemberHelper(
sb.write("\n");
}
// TODO(jacobr): make this check more robust.
bool _isExternal(mirrors.Mirror mirror) {
/*
var source = mirror.source;
return source != null && source.startsWith("external ");
*/
bool _isExternal(mirrors.MethodMirror mirror) {
// This try-catch block is a workaround for BUG:24834.
try {
return mirror.isExternal;
} catch (e) { }
return false;
}
List<String> _generateExternalMethods() {