languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:37:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speedup x64 disassembler to avoid tests timing out.

Browse source 
Same change as I already did for ia32.

We don't have a lot of raw addresses embedded in code anymore with the new
calling convention, so this part of the disassembler is not useful anymore.

TBR=rmacnak

Review URL: https://codereview.chromium.org//1347363004 .
This commit is contained in:
Florian Schneider 2015-09-21 12:56:27 +02:00
parent 8c6b990305
commit 2bbf0c61ae
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
runtime/vm/disassembler_x64.cc
View file

@ -790,7 +790,8 @@ static const char* ObjectToCStringNoGC(const Object& obj) {
obj.IsClass() ||
obj.IsFunction() ||
obj.IsICData() ||
obj.IsField()) {
obj.IsField() ||
obj.IsCode()) {
return obj.ToCString();
}
@ -808,6 +809,7 @@ void DisassemblerX64::AppendAddressToBuffer(uint8_t* addr_byte_ptr) {
if (((addr & kSmiTagMask) == kHeapObjectTag) &&
reinterpret_cast<RawObject*>(addr)->IsWellFormed() &&
reinterpret_cast<RawObject*>(addr)->IsOldObject() &&
!Dart::vm_isolate()->heap()->CodeContains(addr) &&
!Isolate::Current()->heap()->CodeContains(addr) &&
Disassembler::CanFindOldObject(addr)) {
NoSafepointScope no_safepoint;
@ -835,14 +837,6 @@ void DisassemblerX64::AppendAddressToBuffer(uint8_t* addr_byte_ptr) {
const char* name_of_stub = StubCode::NameOfStub(addr);
if (name_of_stub != NULL) {
AppendToBuffer(" [stub: %s]", name_of_stub);
} else {
// Print only if jumping to entry point.
const Code& code = Code::Handle(Code::LookupCode(addr));
if (!code.IsNull() && (code.EntryPoint() == addr)) {
const String& name = String::Handle(code.PrettyName());
const char* name_c = name.ToCString();
AppendToBuffer(" [%s]", name_c);
}
}
}
}