From 2b56c2c58a48c1b74a047d92697b8a74848708c5 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Wed, 19 Jun 2019 23:04:01 +0000 Subject: [PATCH] Normalize status files Run `pkg/status_file/bin/normalize.dart` across all status files. This should solve most presubmit warnings about "existing and possibly new status file issues". There are remaining issues in pkg/front_end/testcases/strong.status and pkg/front_end/testcases/text_serialization.status which will need to be fixed manually. Change-Id: Iceae8992c4907442481590d75c1b0a84ce29521b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106726 Reviewed-by: Bob Nystrom Commit-Queue: Bob Nystrom Auto-Submit: Nate Bosch --- runtime/tests/vm/vm.status | 209 ++++++++++---------- samples/samples.status | 6 +- tests/ffi/ffi.status | 60 +++--- tests/language_2/language_2.status | 12 +- tests/language_2/language_2_dart2js.status | 2 +- tests/language_2/language_2_dartdevc.status | 2 +- tests/lib_2/analyzer/analyze_library.status | 2 +- tests/lib_2/lib_2_precompiled.status | 22 +-- tools/dom/docs/docs.status | 2 +- 9 files changed, 153 insertions(+), 164 deletions(-) diff --git a/runtime/tests/vm/vm.status b/runtime/tests/vm/vm.status index 5d70c9e0436..0a268a33567 100644 --- a/runtime/tests/vm/vm.status +++ b/runtime/tests/vm/vm.status @@ -12,6 +12,7 @@ cc/IsolateReload_PendingStaticCall_NSMToDefined: Fail, Crash # Issue 32981. Fail cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic: Fail # Issue 32981 cc/IsolateReload_PendingUnqualifiedCall_StaticToInstance: Fail # Issue 32981 cc/IsolateReload_RunNewFieldInitializersWithGenerics: Fail # Issue 32299 +cc/Profiler_StringInterpolation: Fail # Issue 37208 dart/data_uri_import_test/none: SkipByDesign dart/entrypoints/jit: Skip # Tests with brittle dependencies on usage counters - Issue 37144 dart/slow_path_shared_stub_test: Pass, Slow # Uses --shared-slow-path-triggers-gc flag. @@ -19,10 +20,8 @@ dart/snapshot_version_test: Skip # This test is a Dart1 test (script snapshot) dart/stack_overflow_shared_test: Pass, Slow # Uses --shared-slow-path-triggers-gc flag. dart/use_bare_instructions_flag_test: Pass, Slow # Spawns several subprocesses -cc/Profiler_StringInterpolation: Fail # Issue 37208 - -[ $mode == debug ] -dart/appjit_cha_deopt_test: Pass, Slow # Quite slow in debug mode, uses --optimization-counter-threshold=100 +[ $builder_tag == asan ] +dart/transferable_throws_oom_test: SkipByDesign # This test tries to allocate too much memory on purpose. Still dartbug.com/37188 [ $builder_tag == optimization_counter_threshold ] dart/appjit*: SkipByDesign # Test needs to a particular opt-counter value @@ -32,44 +31,14 @@ dart/kernel_determinism_test: SkipSlow dart/redirection_type_shuffling_test/none: RuntimeError dart/snapshot_version_test: RuntimeError -[ $hot_reload || $hot_reload_rollback ] -dart/compilation_trace_test: Pass, Slow -dart/type_feedback_test: Pass, Slow -dart/issue_31959_31960_test: SkipSlow - -[ $compiler != dartk || ($arch != x64 && $arch != simarm && $arch != arm) || $hot_reload || $hot_reload_rollback ] -dart/entrypoints/jit/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. - -[ $compiler != dartkp || ($arch != x64 && $arch != simarm && $arch != arm) || $hot_reload || $hot_reload_rollback ] -dart/entrypoints/aot/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. - -[ ($compiler != dartk && $compiler != dartkp) || ($arch != x64 && $arch != simarm && $arch != arm) || $hot_reload || $hot_reload_rollback ] -dart/entrypoints/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. - [ $compiler == dartk ] dart/entrypoints/aot/*: SkipByDesign -[ ($compiler == dartk || $compiler == dartkb) ] -cc/DartAPI_New: Fail # Issue #33041 -dart/redirection_type_shuffling_test/00: RuntimeError, Pass -dart/redirection_type_shuffling_test/none: RuntimeError +[ $compiler == dartkb ] +cc/*: Skip # Bytecode modes are not properly hooked up in run_vm_tests. -[ $runtime != vm && $runtime != dart_precompiled ] -dart/catch_entry_state: SkipByDesign - -[ $builder_tag == asan ] -dart/transferable_throws_oom_test: SkipByDesign # This test tries to allocate too much memory on purpose. Still dartbug.com/37188 - -[ $system == macos ] -dart/transferable_throws_oom_test: SkipByDesign # Allocating too much memory to cause OOM doesn't work on mac - -[ $compiler != dartk && $compiler != dartkb ] -cc/IsolateReload_KernelIncrementalCompile: SkipByDesign -cc/IsolateReload_KernelIncrementalCompileAppAndLib: SkipByDesign -cc/IsolateReload_KernelIncrementalCompileExpression: SkipByDesign -cc/IsolateReload_KernelIncrementalCompileGenerics: SkipByDesign -cc/Mixin_PrivateSuperResolution: Skip -cc/Mixin_PrivateSuperResolutionCrossLibraryShouldFail: Skip +[ $compiler == dartkp ] +dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler. [ $compiler == fasta ] dart/data_uri_import_test/badencodeddate: CompileTimeError @@ -79,53 +48,37 @@ dart/byte_array_test: SkipByDesign # Incompatible flag --disable_alloc_stubs_aft [ $mode == debug ] cc/CorelibIsolateStartup: SkipByDesign # This is a benchmark that is not informative in debug mode. +cc/IRTest_TypedDataAOT_FunctionalGetSet: Skip # run_vm_tests contains JIT/AOT but FLAG_precompiled_mode is not always correct. This causes this test to fail in debug mode, hitting an assertion. See http://dartbug.com/36521 cc/VerifyExplicit_Crash: Crash # Negative tests of VerifiedMemory should crash iff in DEBUG mode. TODO(koda): Improve support for negative tests. cc/VerifyImplicit_Crash: Crash # Negative tests of VerifiedMemory should crash iff in DEBUG mode. TODO(koda): Improve support for negative tests. +dart/appjit_cha_deopt_test: Pass, Slow # Quite slow in debug mode, uses --optimization-counter-threshold=100 dart/spawn_shutdown_test: Pass, Slow # VM Shutdown test, It can take some time for all the isolates to shutdown in a Debug build. [ $runtime == dart_precompiled ] dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri dart/issue32950_test: SkipByDesign # uses spawnUri. -[ $runtime == vm && $mode == product && $compiler == dartk ] -cc/CorelibIsolateStartup: Timeout, Pass - -[ $runtime != vm && $runtime != dart_precompiled ] -dart/*: SkipByDesign # VM specific tests - -[ $runtime != dart_precompiled || $system == android ] -dart/bare_instructions_trampolines_test: SkipByDesign # This test is for VM AOT only (android fails due to listing interfaces). - -[ $mode == debug || $runtime != dart_precompiled || $system == android ] -dart/use_bare_instructions_flag_test: SkipByDesign # This test is for VM AOT only and is quite slow (so we don't run it in debug mode). - [ $system == fuchsia ] cc/CorelibIsolateStartup: Skip # OOM crash can bring down the OS. cc/Read: Fail # TODO(zra): Investigate, ../../dart/runtime/bin/file_test.cc: 34: error: expected: !file->WriteByte(1) dart/data_uri_spawn_test: Skip # TODO(zra): package:unittest is not in the image. dart/spawn_shutdown_test: Skip # OOM crash can bring down the OS. +[ $system == macos ] +dart/transferable_throws_oom_test: SkipByDesign # Allocating too much memory to cause OOM doesn't work on mac + [ $system == windows ] cc/CorelibCompilerStats: Skip -cc/GenKernelKernelLoadKernel: Skip # Issue 34542. -cc/GenKernelKernelReadAllBytecode: Skip # Issue 34393. -cc/GenKernelKernelCombined: Skip # Issue 34393. -cc/GenKernelKernelMaxRSS: Skip # Issue 34393. -dart/appjit_bytecode_simple_test: Skip # Issue 34393. - -[ $arch == simarm || $arch == simdbc || $arch == simdbc64 || $arch == ia32 || $arch == arm ] -cc/GenKernelKernelLoadKernel: SkipByDesign # No interpreter support. -cc/GenKernelKernelReadAllBytecode: SkipByDesign # No interpreter support. -cc/GenKernelKernelCombined: SkipByDesign # No interpreter support. -cc/GenKernelKernelMaxRSS: SkipByDesign # No interpreter support. +cc/GenKernelKernelCombined: Skip # Issue 34393. +cc/GenKernelKernelLoadKernel: Skip # Issue 34542. +cc/GenKernelKernelMaxRSS: Skip # Issue 34393. +cc/GenKernelKernelReadAllBytecode: Skip # Issue 34393. +dart/appjit_bytecode_simple_test: Skip # Issue 34393. [ !$strong ] dart/callee_side_type_checks_test: SkipByDesign -[ !$checked && !$strong && $runtime == vm ] -dart/redirection_type_shuffling_test/00: MissingCompileTimeError - -[ $arch != simarm && $arch != simarm64 && $arch != simdbc64 && ($compiler == dartk || $compiler == dartkb) && $hot_reload ] +[ $arch != simarm && $arch != simarm64 && $arch != simdbc64 && $hot_reload && ($compiler == dartk || $compiler == dartkb) ] dart/data_uri_import_test/base64: Crash dart/data_uri_import_test/nocharset: Crash dart/data_uri_import_test/nomime: Crash @@ -133,16 +86,60 @@ dart/data_uri_import_test/percentencoded: Crash dart/data_uri_import_test/utf16: Crash dart/data_uri_import_test/wrongmime: Crash +[ $builder_tag == obfuscated && $compiler == dartkp ] +dart/optimized_stacktrace_line_and_column_test: SkipByDesign # Looks for filenames in stacktrace output +dart/optimized_stacktrace_line_test: SkipByDesign # Looks for filenames in stacktrace output + +[ $compiler == dartk && $mode == product && $runtime == vm ] +cc/CorelibIsolateStartup: Timeout, Pass + +[ $compiler != dartk && $compiler != dartkb ] +cc/IsolateReload_KernelIncrementalCompile: SkipByDesign +cc/IsolateReload_KernelIncrementalCompileAppAndLib: SkipByDesign +cc/IsolateReload_KernelIncrementalCompileExpression: SkipByDesign +cc/IsolateReload_KernelIncrementalCompileGenerics: SkipByDesign +cc/Mixin_PrivateSuperResolution: Skip +cc/Mixin_PrivateSuperResolutionCrossLibraryShouldFail: Skip + +[ $compiler != dartk && $compiler != dartkb && $compiler != none ] +dart/appjit*: SkipByDesign # Test needs to run from source +dart/kernel_determinism_test: SkipByDesign # Test needs to run from source + +[ $compiler == dartkp && ($runtime == dart_precompiled || $runtime == vm) ] +dart/issue32950_test: SkipByDesign # uses spawnUri. +dart/redirection_type_shuffling_test: SkipByDesign # Includes dart:mirrors. +dart/spawn_shutdown_test: SkipSlow + +[ $mode == debug && $system == windows ] +dart/spawn_shutdown_test: Skip # Flaky crashes unable to start thread; likely low memory on the bot. + # Enabling of dartk for sim{arm,arm64,dbc64} revelaed these test failures, which # are to be triaged. Isolate tests are skipped on purpose due to the usage of # batch mode. -[ ($compiler == dartk || $compiler == dartkb) && $mode == debug && ($arch == simarm || $arch == simarm64) ] +[ $mode == debug && ($arch == simarm || $arch == simarm64) && ($compiler == dartk || $compiler == dartkb) ] cc/StackTraceMallocHookLengthTest: Fail # Please triage. -[ ($compiler == dartk || $compiler == dartkb) && $mode == release && $runtime == vm ] +[ $mode == product && $runtime == vm ] +cc/DartAPI_IsolateSetCheckedMode: Fail, OK # Checked mode disabled in product mode. + +[ $mode == release && $runtime == vm && ($compiler == dartk || $compiler == dartkb) ] cc/CorelibIsolateStartup: Timeout, Pass -[ ($compiler == dartk || $compiler == dartkb) && $runtime == vm ] +[ $runtime == dart_precompiled && $minified ] +dart/inline_stack_frame_test: Skip +dart/optimized_stacktrace_line_test: Skip + +[ $runtime != dart_precompiled && $runtime != vm ] +dart/*: SkipByDesign # VM specific tests +dart/catch_entry_state: SkipByDesign + +[ $runtime == vm && $system == macos && ($compiler == dartk || $compiler == dartkb) ] +cc/IsolateReload_LibraryLookup: Fail, Crash + +[ $runtime == vm && !$checked && !$strong ] +dart/redirection_type_shuffling_test/00: MissingCompileTimeError + +[ $runtime == vm && ($compiler == dartk || $compiler == dartkb) ] cc/Class_ComputeEndTokenPos: Crash cc/DartAPI_LoadLibrary: Fail, Crash # Issue 33048. cc/DebuggerAPI_BreakpointStubPatching: Fail @@ -158,19 +155,16 @@ cc/IsolateReload_NotTypedefToTypedef: Fail cc/IsolateReload_TypedefToNotTypedef: Fail dart/spawn_shutdown_test: SkipSlow -[ ($compiler == dartk || $compiler == dartkb) && $runtime == vm && $system == macos ] +[ $system == linux && ($compiler == dartk || $compiler == dartkb) ] cc/IsolateReload_LibraryLookup: Fail, Crash -[ ($compiler == dartk || $compiler == dartkb) && $system == linux ] +[ $system == windows && ($compiler == dartk || $compiler == dartkb) ] cc/IsolateReload_LibraryLookup: Fail, Crash -[ ($compiler == dartk || $compiler == dartkb) && $system == windows ] -cc/IsolateReload_LibraryLookup: Fail, Crash - -[ ($compiler == dartk || $compiler == dartkb) && $checked ] +[ $checked && ($compiler == dartk || $compiler == dartkb) ] dart/redirection_type_shuffling_test/00: Pass # Works in --checked mode but not in --strong mode. -[ ($compiler == dartk || $compiler == dartkb) && $strong ] +[ $strong && ($compiler == dartk || $compiler == dartkb) ] cc/DartGeneratedArrayLiteralMessages: Crash # Issue 32190 cc/FullSnapshot1: Crash # Issue 32190 cc/IsolateReload_LibraryLookup: Fail, Crash # Issue 32190 @@ -178,14 +172,14 @@ cc/MismatchedSnapshotKinds: Fail, Crash, OK # Script snapshots not supported in cc/ScriptSnapshot1: Fail, Crash, OK # Script snapshots not supported in Dart 2 cc/ScriptSnapshotsUpdateSubclasses: Fail, Crash, OK # Script snapshots not supported in Dart 2 -[ ($compiler == dartk || $compiler == dartkb) && ($arch == simarm || $arch == simarm64 || $arch == simdbc || $arch == simdbc64) ] +[ ($arch == simarm || $arch == simarm64 || $arch == simdbc || $arch == simdbc64) && ($compiler == dartk || $compiler == dartkb) ] dart/appjit*: SkipSlow # DFE too slow dart/issue_31959_31960_test: SkipSlow # Enabling of dartk for sim{arm,arm64,dbc64} revelaed these test failures, which # are to be triaged. Isolate tests are skipped on purpose due to the usage of # batch mode. -[ ($compiler == dartk || $compiler == dartkb) && ($arch == simarm || $arch == simarm64 || $arch == simdbc64) ] +[ ($arch == simarm || $arch == simarm64 || $arch == simdbc64) && ($compiler == dartk || $compiler == dartkb) ] dart/data_uri_spawn_test: Skip # Please triage. dart/snapshot_version_test: RuntimeError # Please triage. @@ -193,24 +187,14 @@ dart/snapshot_version_test: RuntimeError # Please triage. dart/data_uri_spawn_test: Skip # Timeout dart/kernel_determinism_test: SkipSlow -[ $compiler != dartk && $compiler != dartkb && $compiler != none ] -dart/appjit*: SkipByDesign # Test needs to run from source -dart/kernel_determinism_test: SkipByDesign # Test needs to run from source +[ $arch == arm || $arch == arm64 || $compiler != dartkp ] +dart/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). -[ $compiler == dartkp && ($runtime == dart_precompiled || $runtime == vm) ] -dart/issue32950_test: SkipByDesign # uses spawnUri. -dart/redirection_type_shuffling_test: SkipByDesign # Includes dart:mirrors. -dart/spawn_shutdown_test: SkipSlow - -[ $mode == debug && $system == windows ] -dart/spawn_shutdown_test: Skip # Flaky crashes unable to start thread; likely low memory on the bot. - -[ $mode == product && $runtime == vm ] -cc/DartAPI_IsolateSetCheckedMode: Fail, OK # Checked mode disabled in product mode. - -[ $runtime == dart_precompiled && $minified ] -dart/inline_stack_frame_test: Skip -dart/optimized_stacktrace_line_test: Skip +[ $arch == arm || $arch == ia32 || $arch == simarm || $arch == simdbc || $arch == simdbc64 ] +cc/GenKernelKernelCombined: SkipByDesign # No interpreter support. +cc/GenKernelKernelLoadKernel: SkipByDesign # No interpreter support. +cc/GenKernelKernelMaxRSS: SkipByDesign # No interpreter support. +cc/GenKernelKernelReadAllBytecode: SkipByDesign # No interpreter support. # Profiler is completely disabled in SIMDBC builds. # On the simluator stack traces produced by the Profiler do not match @@ -262,31 +246,38 @@ dart/generic_field_invocation_test: SkipByDesign # DBC and KBC interpreters do n [ $compiler == dart2analyzer || $compiler == dart2js ] dart/data_uri*test: Skip # Data uri's not supported by dart2js or the analyzer. +[ $compiler == dartk || $compiler == dartkb ] +cc/DartAPI_New: Fail # Issue #33041 +dart/redirection_type_shuffling_test/00: RuntimeError, Pass +dart/redirection_type_shuffling_test/none: RuntimeError + +[ $compiler != dartk || $hot_reload || $hot_reload_rollback || $arch != arm && $arch != simarm && $arch != x64 ] +dart/entrypoints/jit/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. + +[ $compiler != dartkp || $hot_reload || $hot_reload_rollback || $arch != arm && $arch != simarm && $arch != x64 ] +dart/entrypoints/aot/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. + [ $compiler == precompiler || $mode == product ] cc/CoreSnapshotSize: SkipByDesign # Imports dart:mirrors cc/CreateMirrorSystem: SkipByDesign # Imports dart:mirrors cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors +[ $mode == debug || $runtime != dart_precompiled || $system == android ] +dart/use_bare_instructions_flag_test: SkipByDesign # This test is for VM AOT only and is quite slow (so we don't run it in debug mode). + +[ $runtime != dart_precompiled || $system == android ] +dart/bare_instructions_trampolines_test: SkipByDesign # This test is for VM AOT only (android fails due to listing interfaces). + [ $hot_reload || $hot_reload_rollback ] dart/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot. +dart/compilation_trace_test: Pass, Slow +dart/issue_31959_31960_test: SkipSlow dart/slow_path_shared_stub_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled. dart/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads. dart/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads. dart/stack_overflow_shared_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled. +dart/type_feedback_test: Pass, Slow -[ $builder_tag == obfuscated && $compiler == dartkp ] -dart/optimized_stacktrace_line_and_column_test: SkipByDesign # Looks for filenames in stacktrace output -dart/optimized_stacktrace_line_test: SkipByDesign # Looks for filenames in stacktrace output - -[ $compiler != dartkp || $arch == arm || $arch == arm64 ] -dart/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). - -[ $compiler == dartkp ] -dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler. - -[ $compiler == dartkb ] -cc/*: Skip # Bytecode modes are not properly hooked up in run_vm_tests. - -[ $mode == debug ] -cc/IRTest_TypedDataAOT_FunctionalGetSet: Skip # run_vm_tests contains JIT/AOT but FLAG_precompiled_mode is not always correct. This causes this test to fail in debug mode, hitting an assertion. See http://dartbug.com/36521 +[ $hot_reload || $hot_reload_rollback || $arch != arm && $arch != simarm && $arch != x64 || $compiler != dartk && $compiler != dartkp ] +dart/entrypoints/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots. diff --git a/samples/samples.status b/samples/samples.status index 09ae4a3b2bc..f72f9e5e546 100644 --- a/samples/samples.status +++ b/samples/samples.status @@ -23,6 +23,9 @@ sample_extension/test/sample_extension_app_snapshot_test: Pass, RuntimeError # I [ !$preview_dart_2 && ($runtime == dart_precompiled || $runtime == vm) ] *: SkipByDesign # Deprecating all Dart1 modes of execution +[ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ] +ffi/sqlite/test/sqlite_test: Skip # FFI not supported or libsqlite3.so not available. + [ $compiler == app_jitk || $compiler == dartkb || $compiler == dartkp ] sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign sample_extension/test/sample_extension_test: SkipByDesign @@ -33,6 +36,3 @@ sample_extension/*: Skip [ $hot_reload || $hot_reload_rollback ] sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign # Cannot reload with URI pointing to app snapshot. - -[ $arch != x64 || $system != linux || $compiler != dartk || $hot_reload || $hot_reload_rollback ] -ffi/sqlite/test/sqlite_test: Skip # FFI not supported or libsqlite3.so not available. diff --git a/tests/ffi/ffi.status b/tests/ffi/ffi.status index 61d2ce64348..1fa9e5bd351 100644 --- a/tests/ffi/ffi.status +++ b/tests/ffi/ffi.status @@ -2,40 +2,14 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $runtime != dart_precompiled && $runtime != vm ] -*: SkipByDesign # FFI is a VM-only feature. (This test suite is part of the default set.) - -[ $builder_tag == asan ] -data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose. - -# dartbug.com/35768: Structs not supported on 32-bit. -[ $arch == ia32 || $arch == arm || $arch == simdbc ] -function_structs_test: Skip -structs_test: Skip - -[ $arch == x64 || $arch == arm64 || $arch == simdbc64 ] -enable_structs_test: SkipByDesign # Tests that structs don't work on 32-bit systems. - -[ $runtime == dart_precompiled ] -*: Skip # AOT is not yet supported: dartbug.com/35765 - -[ $arch == simarm || $arch == simarm64 ] -*: Skip # FFI not yet supported on the arm simulator. - [ $arch == simdbc ] *: Skip # FFI not yet supported on SimDBC32: dartbug.com/36809 -[ $arch == simdbc64 && $system != linux && $system != macos ] -*: Skip # FFI not yet supported outside x64 Linux: dartbug.com/36809 - -[ $system != android && $system != linux && $system != macos && $system != windows ] -*: Skip # FFI not yet supported on other OSes. - -[ $system != android && $arch == arm ] -*: Skip # "hardfp" calling convention is not yet supported (iOS is also supported but not tested): dartbug.com/36309 - [ $arch == simdbc64 ] -function_callbacks_test: Skip # Issue 37140 +function_callbacks_test: Skip # Issue 37140 + +[ $builder_tag == asan ] +data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose. # These tests trigger and catch an abort (intentionally) and terminate the VM # before it can generate a snapshot. @@ -43,3 +17,29 @@ function_callbacks_test: Skip # Issue 37140 function_callbacks_test/01: Skip function_callbacks_test/02: Skip function_callbacks_test/03: Skip + +[ $runtime == dart_precompiled ] +*: Skip # AOT is not yet supported: dartbug.com/35765 + +[ $arch == arm && $system != android ] +*: Skip # "hardfp" calling convention is not yet supported (iOS is also supported but not tested): dartbug.com/36309 + +[ $arch == simdbc64 && $system != linux && $system != macos ] +*: Skip # FFI not yet supported outside x64 Linux: dartbug.com/36809 + +[ $runtime != dart_precompiled && $runtime != vm ] +*: SkipByDesign # FFI is a VM-only feature. (This test suite is part of the default set.) + +[ $system != android && $system != linux && $system != macos && $system != windows ] +*: Skip # FFI not yet supported on other OSes. + +# dartbug.com/35768: Structs not supported on 32-bit. +[ $arch == arm || $arch == ia32 || $arch == simdbc ] +function_structs_test: Skip +structs_test: Skip + +[ $arch == arm64 || $arch == simdbc64 || $arch == x64 ] +enable_structs_test: SkipByDesign # Tests that structs don't work on 32-bit systems. + +[ $arch == simarm || $arch == simarm64 ] +*: Skip # FFI not yet supported on the arm simulator. diff --git a/tests/language_2/language_2.status b/tests/language_2/language_2.status index 921c002c5dc..374157174e9 100644 --- a/tests/language_2/language_2.status +++ b/tests/language_2/language_2.status @@ -21,12 +21,6 @@ issue34488_test/none: Fail # Issue 34488 mixin_class_from_core_library_test: Fail # Issue 34488 nested_generic_closure_test: Fail # Issue 28515 -[ $compiler != compare_analyzer_cfe && $compiler != spec_parser ] -mixin_constructor_forwarding/const_constructor_test/none: CompileTimeError # Issue 32223 -mixin_constructor_forwarding/const_constructor_with_field_test/none: CompileTimeError # Issue 32223 -mixin_constructor_forwarding/optional_named_parameters_test/none: CompileTimeError # Issue 31543 -mixin_constructor_forwarding/optional_positional_parameters_test/none: CompileTimeError # Issue 31543 - [ $compiler != dart2analyzer ] switch_case_warn_test: Skip # Analyzer only, see language_analyzer2.status @@ -74,6 +68,12 @@ compile_time_constant_static5_test/21: CompileTimeError # Issue 30546 compile_time_constant_static5_test/23: CompileTimeError # Issue 30546 type_promotion_more_specific_test/04: CompileTimeError # Issue 30906. +[ $compiler != compare_analyzer_cfe && $compiler != spec_parser ] +mixin_constructor_forwarding/const_constructor_test/none: CompileTimeError # Issue 32223 +mixin_constructor_forwarding/const_constructor_with_field_test/none: CompileTimeError # Issue 32223 +mixin_constructor_forwarding/optional_named_parameters_test/none: CompileTimeError # Issue 31543 +mixin_constructor_forwarding/optional_positional_parameters_test/none: CompileTimeError # Issue 31543 + # Detection of compile-time errors that are related to constants can't be fully # done at the front end, because constants are evaluated at back ends. So, some # errors aren't detected by fasta, but reported by back ends as compile-time diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index 6c0369480ef..d6403c52d7b 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -114,8 +114,8 @@ issue31596_super_test/01: CompileTimeError issue31596_super_test/03: CompileTimeError left_shift_test: RuntimeError # non JS number semantics library_env_test/has_io_support: RuntimeError, OK # dart2js doesn't support io when compiling on --categories=Client -library_env_test/has_mirror_support: Fail # mirrors not supported on web library_env_test/has_mirror_support: RuntimeError +library_env_test/has_mirror_support: Fail # mirrors not supported on web library_env_test/has_no_html_support: RuntimeError, OK library_env_test/has_no_mirror_support: Pass # fails for the wrong reason. list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351 diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index 63b4104e66c..26643dcd4ee 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -259,8 +259,8 @@ regress_23408_test: CompileTimeError # Issue 31533 regress_24283_test: RuntimeError # Expect.equals(expected: <-1>, actual: <4294967295>) fails. regress_29025_test: CompileTimeError regress_29405_test: CompileTimeError # Issue 31402 Error: A value of type '#lib2::Foo' can't be assigned to a variable of type '(#lib2::Foo) → void'. -regress_30339_test: RuntimeError # Uncaught Expect.isTrue(false) fails. regress_30339_test: CompileTimeError +regress_30339_test: RuntimeError # Uncaught Expect.isTrue(false) fails. setter_no_getter_test/01: CompileTimeError super_bound_closure_test/none: CompileTimeError # Issue 31533 super_call4_test/01: MissingCompileTimeError diff --git a/tests/lib_2/analyzer/analyze_library.status b/tests/lib_2/analyzer/analyze_library.status index e34a9bb88ed..0dd8e28ddcf 100644 --- a/tests/lib_2/analyzer/analyze_library.status +++ b/tests/lib_2/analyzer/analyze_library.status @@ -3,4 +3,4 @@ # BSD-style license that can be found in the LICENSE file. [ $compiler == dart2analyzer ] -*: Skip \ No newline at end of file +*: Skip diff --git a/tests/lib_2/lib_2_precompiled.status b/tests/lib_2/lib_2_precompiled.status index 86461fee429..9a1e8962a9c 100644 --- a/tests/lib_2/lib_2_precompiled.status +++ b/tests/lib_2/lib_2_precompiled.status @@ -3,21 +3,10 @@ # BSD-style license that can be found in the LICENSE file. [ $compiler == precompiler ] +async/async_no_await_zones_test: RuntimeError # Issue 33700 convert/chunked_conversion_utf88_test: Pass, Timeout convert/utf85_test: Pass, Timeout html/*: SkipByDesign # dart:html not supported on AOT. -mirrors/*: SkipByDesign # Mirrors not supported on AOT. -async/async_no_await_zones_test: RuntimeError # Issue 33700 - -[ $compiler == app_jit || $compiler == none || $compiler == precompiler ] -async/future_or_strong_test: RuntimeError -async/timer_not_available_test: SkipByDesign # only meant to test when there is no way to implement timer (currently only in d8) -isolate/compile_time_error_test/01: Skip # Issue 12587 -isolate/ping_pause_test: Skip # Resolve test issues -isolate/ping_test: Skip # Resolve test issues -mirrors/symbol_validation_test: RuntimeError # Issue 13596 - -[ $compiler == precompiler ] isolate/count_test: SkipByDesign isolate/cross_isolate_message_test: SkipByDesign isolate/illegal_msg_function_test: SkipByDesign @@ -39,3 +28,12 @@ isolate/unresolved_ports_test: SkipByDesign js/datetime_roundtrip_test: CompileTimeError js/null_test: CompileTimeError js/prototype_access_test: CompileTimeError +mirrors/*: SkipByDesign # Mirrors not supported on AOT. + +[ $compiler == app_jit || $compiler == none || $compiler == precompiler ] +async/future_or_strong_test: RuntimeError +async/timer_not_available_test: SkipByDesign # only meant to test when there is no way to implement timer (currently only in d8) +isolate/compile_time_error_test/01: Skip # Issue 12587 +isolate/ping_pause_test: Skip # Resolve test issues +isolate/ping_test: Skip # Resolve test issues +mirrors/symbol_validation_test: RuntimeError # Issue 13596 diff --git a/tools/dom/docs/docs.status b/tools/dom/docs/docs.status index d873a783fee..a5020666de9 100644 --- a/tools/dom/docs/docs.status +++ b/tools/dom/docs/docs.status @@ -3,5 +3,5 @@ # BSD-style license that can be found in the LICENSE file. # docs.dart is a tool that only runs on the VM -[ $compiler == dart2js] +[ $compiler == dart2js ] *: Skip