languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:39:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue 27539. Check that the source is not modified between constructor and correction computing.

Browse source 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27539

Review URL: https://codereview.chromium.org/2411063002 .
This commit is contained in:
Konstantin Shcheglov 2016-10-11 13:41:44 -07:00
parent e25461c151
commit 2a000e1587
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/analysis_server/lib/src/services/correction/assist_internal.dart
View file

@ -87,6 +87,12 @@ class AssistProcessor {
String get eol => utils.endOfLine;
Future<List<Assist>> compute() async {
// If the source was changed between the constructor and running
// this asynchronous method, it is not safe to use the unit.
if (analysisContext.getModificationStamp(source) != fileStamp) {
return const <Assist>[];
}
try {
utils = new CorrectionUtils(unit);
} catch (e) {

6
pkg/analysis_server/lib/src/services/correction/fix_internal.dart
View file

@ -139,6 +139,12 @@ class FixProcessor {
String get eol => utils.endOfLine;
Future<List<Fix>> compute() async {
// If the source was changed between the constructor and running
// this asynchronous method, it is not safe to use the unit.
if (context.getModificationStamp(unitSource) != fileStamp) {
return const <Fix>[];
}
try {
utils = new CorrectionUtils(unit);
} catch (e) {