languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:45:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pre-existing HintCode.UNNECESSARY_TYPE_CHECK_TRUE in CFE.

Browse source 
Change-Id: Idb85e0eeec14e31d4d4d1516bafff99186494491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204084
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2021-06-18 16:00:02 +00:00 committed by commit-bot@chromium.org
parent 6baf46b844
commit 29191139f2
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart
View file

@ -3162,7 +3162,7 @@ class ConstantEvaluator implements ExpressionVisitor<Constant> {
}
String name = target.name.text;
if (target is Procedure && target.isFactory) {
if (target.isFactory) {
if (name.isEmpty) {
name = target.enclosingClass!.name;
} else {

3
pkg/kernel/lib/class_hierarchy.dart
View file

@ -1216,8 +1216,7 @@ class ClosedWorldClassHierarchy implements ClassHierarchy {
for (Member mixinMember in _buildDeclaredMembers(
mixedInClassNode, mixedInInfo,
setters: setters)) {
if (mixinMember is! Procedure ||
(mixinMember is Procedure && !mixinMember.isSynthetic)) {
if (mixinMember is! Procedure || !mixinMember.isSynthetic) {
memberMap[mixinMember.name] = mixinMember;
}
}