languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 20:01:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use output-only string streams instead of input-output string streams.

Browse source 
The assertion code only writes to its string streams and never reads data
back.  As such, there is no reason to use a stream type supporting input.

Review URL: https://chromiumcodereview.appspot.com//10828317

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10693 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
cshapiro@google.com 2012-08-14 23:55:37 +00:00
parent 2d94944c8d
commit 28c9533a21
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/platform/assert.cc
View file

@ -18,7 +18,7 @@ static void failed_exit(void) {
}
void DynamicAssertionHelper::Fail(const char* format, ...) {
std::stringstream stream;
std::ostringstream stream;
stream << file_ << ":" << line_ << ": error: ";
va_list arguments;

20
runtime/platform/assert.h
View file

@ -99,7 +99,7 @@ class Expect: public DynamicAssertionHelper {
template<typename E, typename A>
void DynamicAssertionHelper::Equals(const E& expected, const A& actual) {
if (actual == expected) return;
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << expected;
ass << actual;
std::string es = ess.str(), as = ass.str();
@ -111,7 +111,7 @@ template<typename E, typename A>
void DynamicAssertionHelper::NotEquals(const E& not_expected,
const A& actual) {
if (actual != not_expected) return;
std::stringstream ness;
std::ostringstream ness;
ness << not_expected;
std::string nes = ness.str();
Fail("did not expect: <%s>", nes.c_str());
@ -125,7 +125,7 @@ void DynamicAssertionHelper::FloatEquals(const E& expected,
if (((expected - tol) <= actual) && (actual <= (expected + tol))) {
return;
}
std::stringstream ess, ass, tolss;
std::ostringstream ess, ass, tolss;
ess << expected;
ass << actual;
tolss << tol;
@ -139,7 +139,7 @@ void DynamicAssertionHelper::FloatEquals(const E& expected,
template<typename E, typename A>
void DynamicAssertionHelper::StringEquals(const E& expected, const A& actual) {
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << expected;
ass << actual;
std::string es = ess.str(), as = ass.str();
@ -150,7 +150,7 @@ void DynamicAssertionHelper::StringEquals(const E& expected, const A& actual) {
template<typename E, typename A>
void DynamicAssertionHelper::IsSubstring(const E& needle, const A& haystack) {
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << needle;
ass << haystack;
std::string es = ess.str(), as = ass.str();
@ -163,7 +163,7 @@ void DynamicAssertionHelper::IsSubstring(const E& needle, const A& haystack) {
template<typename E, typename A>
void DynamicAssertionHelper::IsNotSubstring(const E& needle,
const A& haystack) {
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << needle;
ass << haystack;
std::string es = ess.str(), as = ass.str();
@ -176,7 +176,7 @@ void DynamicAssertionHelper::IsNotSubstring(const E& needle,
template<typename E, typename A>
void DynamicAssertionHelper::LessThan(const E& left, const A& right) {
if (left < right) return;
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << left;
ass << right;
std::string es = ess.str(), as = ass.str();
@ -187,7 +187,7 @@ void DynamicAssertionHelper::LessThan(const E& left, const A& right) {
template<typename E, typename A>
void DynamicAssertionHelper::LessEqual(const E& left, const A& right) {
if (left <= right) return;
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << left;
ass << right;
std::string es = ess.str(), as = ass.str();
@ -198,7 +198,7 @@ void DynamicAssertionHelper::LessEqual(const E& left, const A& right) {
template<typename E, typename A>
void DynamicAssertionHelper::GreaterThan(const E& left, const A& right) {
if (left > right) return;
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << left;
ass << right;
std::string es = ess.str(), as = ass.str();
@ -209,7 +209,7 @@ void DynamicAssertionHelper::GreaterThan(const E& left, const A& right) {
template<typename E, typename A>
void DynamicAssertionHelper::GreaterEqual(const E& left, const A& right) {
if (left >= right) return;
std::stringstream ess, ass;
std::ostringstream ess, ass;
ess << left;
ass << right;
std::string es = ess.str(), as = ass.str();