languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:59:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the interface definition for Socket.close and Socket.done.

Browse source 
These members were defined as returning Future<Socket>, but the
implementation in _Socket didn't conform to the interface.  There's no
reason these members need to return Future<Socket> anyway, so just
change them to return Future<dynamic>.

Avoids a strong mode error in socket_patch.dart.

Change-Id: Icdda5c7880daf0241e36f1d35e61d171f1694409
Reviewed-on: https://dart-review.googlesource.com/29741
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2017-12-15 16:16:14 +00:00 committed by commit-bot@chromium.org
parent 8239aa093e
commit 2822fbadea
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sdk/lib/io/socket.dart
View file

@ -577,9 +577,9 @@ abstract class Socket implements Stream<List<int>>, IOSink {
*/
InternetAddress get remoteAddress;
Future<Socket> close();
Future close();
Future<Socket> get done;
Future get done;
}
/**