Update test_reflective_loader, use @SkippedTest

Change-Id: I17f8da88a4587a7ad51038ca796f138231021fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119583
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

DEPS

@@ -136,7 +136,7 @@ vars = {
   "test_descriptor_tag": "1.1.1",
   "test_process_tag": "1.0.3",
   "term_glyph_tag": "1.0.1",
-  "test_reflective_loader_tag": "0.1.8",
+  "test_reflective_loader_tag": "0.1.9",
   "test_tag": "test-v1.6.4",
   "tflite_native_rev": "06e533a9747306d1114c53427cc67eda080f51f9",
   "typed_data_tag": "1.1.6",

pkg/analysis_server/test/integration/lsp_server/diagnostic_test.dart

@@ -15,8 +15,10 @@ main() {
 
 @reflectiveTest
 class DiagnosticTest extends AbstractLspAnalysisServerIntegrationTest {
-  skip_test_initialAnalysis() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_initialAnalysis() async {
     newFile(mainFilePath, content: 'String a = 1;');
 
     final diagnosticsUpdate = waitForDiagnostics(mainFileUri);
@@ -31,8 +33,10 @@ class DiagnosticTest extends AbstractLspAnalysisServerIntegrationTest {
     expect(diagnostic.range.end.character, equals(12));
   }
 
-  skip_test_lints() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_lints() async {
     newFile(mainFilePath, content: '''main() async => await 1;''');
     newFile(analysisOptionsPath, content: '''
 linter:

pkg/analysis_server/test/integration/lsp_server/initialization_test.dart

@@ -17,8 +17,10 @@ main() {
 
 @reflectiveTest
 class InitializationTest extends AbstractLspAnalysisServerIntegrationTest {
-  skip_test_initialize_invalidParams() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_initialize_invalidParams() async {
     final params = {'processId': 'invalid'};
     final request = new RequestMessage(
       Either2<num, String>.t1(1),

pkg/analysis_server/test/integration/lsp_server/server_test.dart

@@ -18,8 +18,10 @@ main() {
 
 @reflectiveTest
 class ServerTest extends AbstractLspAnalysisServerIntegrationTest {
-  skip_test_diagnosticServer() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_diagnosticServer() async {
     await initialize();
 
     // Send the custom request to the LSP server to get the Dart diagnostic
@@ -39,8 +41,10 @@ class ServerTest extends AbstractLspAnalysisServerIntegrationTest {
     expect(responseBody, contains('<title>Analysis Server</title>'));
   }
 
-  skip_test_exit_inintializedWithShutdown() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_exit_inintializedWithShutdown() async {
     await initialize();
     await sendShutdown();
     sendExit();
@@ -55,8 +59,10 @@ class ServerTest extends AbstractLspAnalysisServerIntegrationTest {
     expect(exitCode, equals(0));
   }
 
-  skip_test_exit_initializedWithoutShutdown() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_exit_initializedWithoutShutdown() async {
     // Send a request that we can wait for, to ensure the server is fully ready
     // before we send exit. Otherwise the exit notification won't be handled for
     // a long time (while the server starts up) and will exceed the 10s timeout.
@@ -73,8 +79,10 @@ class ServerTest extends AbstractLspAnalysisServerIntegrationTest {
     expect(exitCode, equals(1));
   }
 
-  skip_test_exit_uninintializedWithShutdown() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_exit_uninintializedWithShutdown() async {
     await sendShutdown();
     sendExit();
 
@@ -88,8 +96,10 @@ class ServerTest extends AbstractLspAnalysisServerIntegrationTest {
     expect(exitCode, equals(0));
   }
 
-  skip_test_exit_uninitializedWithoutShutdown() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_exit_uninitializedWithoutShutdown() async {
     // This tests the same as test_exit_withoutShutdown but without sending
     // initialize. It can't be as strict with the timeout as the server may take
     // time to start up (we can't tell when it's ready without sending a request).

pkg/analysis_server/test/src/plugin/plugin_manager_test.dart

@@ -202,8 +202,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
         notificationManager, InstrumentationService.NULL_SERVICE);
   }
 
-  skip_test_addPluginToContextRoot() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_addPluginToContextRoot() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(test: (String pluginPath) async {
@@ -214,8 +216,30 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_broadcastRequest_many() async {
-    // skipped due to flaky timeouts, #38629
+  @failingTest
+  test_addPluginToContextRoot_pubspec() async {
+    // We can't successfully run pub until after the analyzer_plugin package has
+    // been published.
+    fail('Cannot run pub');
+//    io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
+//    String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
+//    await withPubspecPlugin(test: (String pluginPath) async {
+//      ContextRoot contextRoot = _newContextRoot(pkgPath);
+//      await manager.addPluginToContextRoot(contextRoot, pluginPath);
+//      String packagesPath =
+//          resourceProvider.pathContext.join(pluginPath, '.packages');
+//      File packagesFile = resourceProvider.getFile(packagesPath);
+//      bool exists = packagesFile.exists;
+//      await manager.stopAll();
+//      expect(exists, isTrue, reason: '.packages file was not created');
+//    });
+//    pkg1Dir.deleteSync(recursive: true);
+  }
+
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_broadcastRequest_many() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(
@@ -241,8 +265,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_broadcastRequest_many_noContextRoot() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_broadcastRequest_many_noContextRoot() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(
@@ -266,8 +292,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_broadcastWatchEvent() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_broadcastWatchEvent() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(
@@ -290,8 +318,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_pluginsForContextRoot_multiple() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_pluginsForContextRoot_multiple() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(
@@ -318,8 +348,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_pluginsForContextRoot_one() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_pluginsForContextRoot_one() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(test: (String pluginPath) async {
@@ -335,8 +367,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
     pkg1Dir.deleteSync(recursive: true);
   }
 
-  skip_test_removedContextRoot() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_removedContextRoot() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
     await withPlugin(test: (String pluginPath) async {
@@ -351,8 +385,10 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
   }
 
   @TestTimeout(const Timeout.factor(4))
-  skip_test_restartPlugins() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_restartPlugins() async {
     io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
     String pkg1Path = pkg1Dir.resolveSymbolicLinksSync();
     io.Directory pkg2Dir = io.Directory.systemTemp.createTempSync('pkg2');
@@ -390,26 +426,6 @@ class PluginManagerFromDiskTest extends PluginTestSupport {
         });
     pkg1Dir.deleteSync(recursive: true);
   }
-
-  @failingTest
-  test_addPluginToContextRoot_pubspec() async {
-    // We can't successfully run pub until after the analyzer_plugin package has
-    // been published.
-    fail('Cannot run pub');
-//    io.Directory pkg1Dir = io.Directory.systemTemp.createTempSync('pkg1');
-//    String pkgPath = pkg1Dir.resolveSymbolicLinksSync();
-//    await withPubspecPlugin(test: (String pluginPath) async {
-//      ContextRoot contextRoot = _newContextRoot(pkgPath);
-//      await manager.addPluginToContextRoot(contextRoot, pluginPath);
-//      String packagesPath =
-//          resourceProvider.pathContext.join(pluginPath, '.packages');
-//      File packagesFile = resourceProvider.getFile(packagesPath);
-//      bool exists = packagesFile.exists;
-//      await manager.stopAll();
-//      expect(exists, isTrue, reason: '.packages file was not created');
-//    });
-//    pkg1Dir.deleteSync(recursive: true);
-  }
 }
 
 @reflectiveTest
@@ -522,8 +538,10 @@ class PluginManagerTest with ResourceProviderMixin {
 
 @reflectiveTest
 class PluginSessionFromDiskTest extends PluginTestSupport {
-  skip_test_start_notRunning() async {
-    // skipped due to flaky timeouts, #38629
+  @SkippedTest(
+      reason: 'flaky timeouts',
+      issue: 'https://github.com/dart-lang/sdk/issues/38629')
+  test_start_notRunning() async {
     await withPlugin(test: (String pluginPath) async {
       String packagesPath = path.join(pluginPath, '.packages');
       String mainPath = path.join(pluginPath, 'bin', 'plugin.dart');

pkg/analyzer/test/src/task/strong/inferred_type_test.dart

@@ -3394,9 +3394,7 @@ foo() {
   }
 
   test_inferTypesOnGenericInstantiationsInLibraryCycle() async {
-    // Note: this is a regression test for a non-deterministic behavior we used to
-    // have with inference in library cycles. If you see this test flake out,
-    // change `test` to `skip_test` and reopen bug #48.
+    // Note: this is a regression test for bug #48.
     addFile('''
 import 'main.dart';
 abstract class I<E> {