languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

[gardening] Attempt to repair red HHH bot, take 3

Browse source 
OK, this time the patch was applied.

However, there are still compile-time errors as HttpClientResponseCompressionState
was not imported into create_test.dart:

org-dartlang-app:///test/commands/create_test.dart:1176:3: Error: Type 'HttpClientResponseCompressionState' not found.
  HttpClientResponseCompressionState get compressionState {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:///test/commands/create_test.dart:1177:12: Error: Getter not found: 'HttpClientResponseCompressionState'.
    return HttpClientResponseCompressionState.decompressed;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:///test/commands/create_test.dart:1177:12: Error: The getter 'HttpClientResponseCompressionState' isn't defined for the class 'MockHttpClientResponse'.
 - 'MockHttpClientResponse' is from 'org-dartlang-app:///test/commands/create_test.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'HttpClientResponseCompressionState'.
    return HttpClientResponseCompressionState.decompressed;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This change should fix these errors.

Change-Id: I58b7ca97b2181fe04b4169a11a47173e63c3b865
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104381
Reviewed-by: Todd Volkert <tvolkert@google.com>
This commit is contained in:
Alexander Markov 2019-05-31 22:00:39 +00:00
parent cddf2bbdfe
commit 250f3d2e56
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tools/patches/flutter-flutter/445a23a9bc14a57ea6275e5d4da179f7cb0bbdb6.patch
View file

@ -16,6 +16,18 @@ index 7d450be42..e158e33af 100644
@override
List<Cookie> get cookies => null;
diff --git a/packages/flutter_tools/lib/src/base/io.dart b/packages/flutter_tools/lib/src/base/io.dart
index 4c9d2250b..8b3535d54 100644
--- a/packages/flutter_tools/lib/src/base/io.dart
+++ b/packages/flutter_tools/lib/src/base/io.dart
@@ -47,6 +47,7 @@ export 'dart:io'
HttpClient,
HttpClientRequest,
HttpClientResponse,
+ HttpClientResponseCompressionState,
HttpHeaders,
HttpRequest,
HttpServer,
diff --git a/packages/flutter_tools/test/commands/create_test.dart b/packages/flutter_tools/test/commands/create_test.dart
index b5453cbb1..f7cdf6164 100644
--- a/packages/flutter_tools/test/commands/create_test.dart