languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 17:34:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[benchmarks] Fix lints in Omnibus benchmarks

Browse source 
Change-Id: I08dd527bcfd3b4ed97d0c57a877c64ff0ec49ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196460
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2021-04-23 20:11:52 +00:00 committed by commit-bot@chromium.org
parent f08e228238
commit 235ff47a07
4 changed files with 52 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
benchmarks/Omnibus/dart/Omnibus.dart
View file

@ -9,9 +9,11 @@
// //
// -N: run benchmarks N times, defaults to once. // -N: run benchmarks N times, defaults to once.
import '../../ListCopy/dart/ListCopy.dart' as lib_ListCopy; // ignore_for_file: library_prefixes
import '../../BigIntParsePrint/dart/BigIntParsePrint.dart' import '../../BigIntParsePrint/dart/BigIntParsePrint.dart'
as lib_BigIntParsePrint; as lib_BigIntParsePrint;
import '../../ListCopy/dart/ListCopy.dart' as lib_ListCopy;
import '../../MD5/dart/md5.dart' as lib_MD5; import '../../MD5/dart/md5.dart' as lib_MD5;
import '../../RuntimeType/dart/RuntimeType.dart' as lib_RuntimeType; import '../../RuntimeType/dart/RuntimeType.dart' as lib_RuntimeType;
import '../../SHA1/dart/sha1.dart' as lib_SHA1; import '../../SHA1/dart/sha1.dart' as lib_SHA1;
@ -39,13 +41,13 @@ final Map<String, Function()> benchmarks = {
'Utf8Encode': () => lib_Utf8Encode.main([]), 'Utf8Encode': () => lib_Utf8Encode.main([]),
}; };
main(List<String> originalArguments) { void main(List<String> originalArguments) {
List<String> args = List.of(originalArguments); final List<String> args = List.of(originalArguments);
int repeats = 1; int repeats = 1;
for (final arg in args.toList()) { for (final arg in args.toList()) {
int? count = int.tryParse(arg); final int? count = int.tryParse(arg);
if (count != null && count < 0) { if (count != null && count < 0) {
repeats = 0 - count; repeats = 0 - count;
args.remove(arg); args.remove(arg);

30
benchmarks/Omnibus/dart2/Omnibus.dart
View file

@ -11,21 +11,23 @@
// //
// -N: run benchmarks N times, defaults to once. // -N: run benchmarks N times, defaults to once.
import '../../ListCopy/dart/ListCopy.dart' as lib_ListCopy; // ignore_for_file: library_prefixes
import '../../BigIntParsePrint/dart/BigIntParsePrint.dart'
import '../../BigIntParsePrint/dart2/BigIntParsePrint.dart'
as lib_BigIntParsePrint; as lib_BigIntParsePrint;
import '../../MD5/dart/md5.dart' as lib_MD5; import '../../ListCopy/dart2/ListCopy.dart' as lib_ListCopy;
import '../../RuntimeType/dart/RuntimeType.dart' as lib_RuntimeType; import '../../MD5/dart2/md5.dart' as lib_MD5;
import '../../SHA1/dart/sha1.dart' as lib_SHA1; import '../../RuntimeType/dart2/RuntimeType.dart' as lib_RuntimeType;
import '../../SHA256/dart/sha256.dart' as lib_SHA256; import '../../SHA1/dart2/sha1.dart' as lib_SHA1;
import '../../SkeletalAnimation/dart/SkeletalAnimation.dart' import '../../SHA256/dart2/sha256.dart' as lib_SHA256;
import '../../SkeletalAnimation/dart2/SkeletalAnimation.dart'
as lib_SkeletalAnimation; as lib_SkeletalAnimation;
import '../../SkeletalAnimationSIMD/dart/SkeletalAnimationSIMD.dart' import '../../SkeletalAnimationSIMD/dart2/SkeletalAnimationSIMD.dart'
as lib_SkeletalAnimationSIMD; as lib_SkeletalAnimationSIMD;
import '../../TypedDataDuplicate/dart/TypedDataDuplicate.dart' import '../../TypedDataDuplicate/dart2/TypedDataDuplicate.dart'
as lib_TypedDataDuplicate; as lib_TypedDataDuplicate;
import '../../Utf8Decode/dart/Utf8Decode.dart' as lib_Utf8Decode; import '../../Utf8Decode/dart2/Utf8Decode.dart' as lib_Utf8Decode;
import '../../Utf8Encode/dart/Utf8Encode.dart' as lib_Utf8Encode; import '../../Utf8Encode/dart2/Utf8Encode.dart' as lib_Utf8Encode;
final Map<String, Function()> benchmarks = { final Map<String, Function()> benchmarks = {
'ListCopy': lib_ListCopy.main, 'ListCopy': lib_ListCopy.main,
@ -41,13 +43,13 @@ final Map<String, Function()> benchmarks = {
'Utf8Encode': () => lib_Utf8Encode.main([]), 'Utf8Encode': () => lib_Utf8Encode.main([]),
}; };
main(List<String> originalArguments) { void main(List<String> originalArguments) {
List<String> args = List.of(originalArguments); final List<String> args = List.of(originalArguments);
int repeats = 1; int repeats = 1;
for (final arg in args.toList()) { for (final arg in args.toList()) {
int count = int.tryParse(arg); final int count = int.tryParse(arg);
if (count != null && count < 0) { if (count != null && count < 0) {
repeats = 0 - count; repeats = 0 - count;
args.remove(arg); args.remove(arg);

16
benchmarks/OmnibusDeferred/dart/OmnibusDeferred.dart
View file

@ -9,9 +9,11 @@
// //
// -N: run benchmarks N times, defaults to once. // -N: run benchmarks N times, defaults to once.
import '../../ListCopy/dart/ListCopy.dart' deferred as lib_ListCopy; // ignore_for_file: library_prefixes
import '../../BigIntParsePrint/dart/BigIntParsePrint.dart' import '../../BigIntParsePrint/dart/BigIntParsePrint.dart'
deferred as lib_BigIntParsePrint; deferred as lib_BigIntParsePrint;
import '../../ListCopy/dart/ListCopy.dart' deferred as lib_ListCopy;
import '../../MD5/dart/md5.dart' deferred as lib_MD5; import '../../MD5/dart/md5.dart' deferred as lib_MD5;
import '../../RuntimeType/dart/RuntimeType.dart' deferred as lib_RuntimeType; import '../../RuntimeType/dart/RuntimeType.dart' deferred as lib_RuntimeType;
import '../../SHA1/dart/sha1.dart' deferred as lib_SHA1; import '../../SHA1/dart/sha1.dart' deferred as lib_SHA1;
@ -78,20 +80,20 @@ final Map<String, Lib> benchmarks = {
), ),
}; };
main(List<String> originalArguments) async { void main(List<String> originalArguments) async {
List<String> args = List.of(originalArguments); final List<String> args = List.of(originalArguments);
int repeats = 1; int repeats = 1;
for (final arg in args.toList()) { for (final arg in args.toList()) {
int? count = int.tryParse(arg); final int? count = int.tryParse(arg);
if (count != null && count < 0) { if (count != null && count < 0) {
repeats = 0 - count; repeats = 0 - count;
args.remove(arg); args.remove(arg);
} }
} }
bool preload = args.remove('--preload'); final preload = args.remove('--preload');
List<Lib> libs = []; List<Lib> libs = [];
@ -109,7 +111,9 @@ main(List<String> originalArguments) async {
if (libs.isEmpty) libs = benchmarks.values.toList(); if (libs.isEmpty) libs = benchmarks.values.toList();
if (preload) { if (preload) {
for (final lib in libs) await lib.load(); for (final lib in libs) {
await lib.load();
}
} }
for (var i = 0; i < repeats; i++) { for (var i = 0; i < repeats; i++) {

36
benchmarks/OmnibusDeferred/dart2/OmnibusDeferred.dart
View file

@ -11,21 +11,23 @@
// //
// -N: run benchmarks N times, defaults to once. // -N: run benchmarks N times, defaults to once.
import '../../ListCopy/dart/ListCopy.dart' deferred as lib_ListCopy; // ignore_for_file: library_prefixes
import '../../BigIntParsePrint/dart/BigIntParsePrint.dart'
import '../../BigIntParsePrint/dart2/BigIntParsePrint.dart'
deferred as lib_BigIntParsePrint; deferred as lib_BigIntParsePrint;
import '../../MD5/dart/md5.dart' deferred as lib_MD5; import '../../ListCopy/dart2/ListCopy.dart' deferred as lib_ListCopy;
import '../../RuntimeType/dart/RuntimeType.dart' deferred as lib_RuntimeType; import '../../MD5/dart2/md5.dart' deferred as lib_MD5;
import '../../SHA1/dart/sha1.dart' deferred as lib_SHA1; import '../../RuntimeType/dart2/RuntimeType.dart' deferred as lib_RuntimeType;
import '../../SHA256/dart/sha256.dart' deferred as lib_SHA256; import '../../SHA1/dart2/sha1.dart' deferred as lib_SHA1;
import '../../SkeletalAnimation/dart/SkeletalAnimation.dart' import '../../SHA256/dart2/sha256.dart' deferred as lib_SHA256;
import '../../SkeletalAnimation/dart2/SkeletalAnimation.dart'
deferred as lib_SkeletalAnimation; deferred as lib_SkeletalAnimation;
import '../../SkeletalAnimationSIMD/dart/SkeletalAnimationSIMD.dart' import '../../SkeletalAnimationSIMD/dart2/SkeletalAnimationSIMD.dart'
deferred as lib_SkeletalAnimationSIMD; deferred as lib_SkeletalAnimationSIMD;
import '../../TypedDataDuplicate/dart/TypedDataDuplicate.dart' import '../../TypedDataDuplicate/dart2/TypedDataDuplicate.dart'
deferred as lib_TypedDataDuplicate; deferred as lib_TypedDataDuplicate;
import '../../Utf8Decode/dart/Utf8Decode.dart' deferred as lib_Utf8Decode; import '../../Utf8Decode/dart2/Utf8Decode.dart' deferred as lib_Utf8Decode;
import '../../Utf8Encode/dart/Utf8Encode.dart' deferred as lib_Utf8Encode; import '../../Utf8Encode/dart2/Utf8Encode.dart' deferred as lib_Utf8Encode;
class Lib { class Lib {
final Future Function() load; final Future Function() load;
@ -80,20 +82,20 @@ final Map<String, Lib> benchmarks = {
), ),
}; };
main(List<String> originalArguments) async { void main(List<String> originalArguments) async {
List<String> args = List.of(originalArguments); final List<String> args = List.of(originalArguments);
int repeats = 1; int repeats = 1;
for (final arg in args.toList()) { for (final arg in args.toList()) {
int count = int.tryParse(arg); final int count = int.tryParse(arg);
if (count != null && count < 0) { if (count != null && count < 0) {
repeats = 0 - count; repeats = 0 - count;
args.remove(arg); args.remove(arg);
} }
} }
bool preload = args.remove('--preload'); final preload = args.remove('--preload');
List<Lib> libs = []; List<Lib> libs = [];
@ -111,7 +113,9 @@ main(List<String> originalArguments) async {
if (libs.isEmpty) libs = benchmarks.values.toList(); if (libs.isEmpty) libs = benchmarks.values.toList();
if (preload) { if (preload) {
for (final lib in libs) await lib.load(); for (final lib in libs) {
await lib.load();
}
} }
for (var i = 0; i < repeats; i++) { for (var i = 0; i < repeats; i++) {