From 226fceaef2341f294e1c80a536ce07420ab65189 Mon Sep 17 00:00:00 2001 From: pq Date: Fri, 6 May 2022 16:08:50 +0000 Subject: [PATCH] bump to linter 1.23.0 Tested internally w/ `blaze run //ads/acx/devcycle/lints/find_violations -- 446742744`. Should be a clean roll. Change-Id: I5ebd2fab7b79e108a82e2790fcb754e74767e435 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242391 Reviewed-by: Brian Wilkerson Commit-Queue: Phil Quitslund --- CHANGELOG.md | 18 ++++++++++++++++-- DEPS | 2 +- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f90627d066..ce00d95fabb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -274,9 +274,23 @@ them, you must set the lower bound on the SDK constraint for your package to #### Linter -Updated the Linter to `1.22.0`, which includes changes that +Updated the Linter to `1.23.0`, which includes changes that -- fixes null-safe variance exceptions in `invariant_booleans` +- fixes `no_leading_underscores_for_local_identifiers` + to lint local function declarations. +- fixes `avoid_init_to_null` to correctly handle super + initializing defaults that are non-null. +- updates `no_leading_underscores_for_local_identifiers` + to allow identifiers with just underscores. +- fixes `flutter_style_todos` to support usernames that + start with a digit. +- updates `require_trailing_commas` to handle functions + in asserts and multi-line strings. +- updates `unsafe_html` to allow assignments to + `img.src`. +- fixes `unnecessary_null_checks` to properly handle map + literal entries. +- fixes null-safe variance exceptions in `invariant_booleans`. - updates `depend_on_referenced_packages` to treat `flutter_gen` as a virtual package, not needing an explicit dependency. - updates `unnecessary_null_checks` and diff --git a/DEPS b/DEPS index e12bacc16b9..b2edad0f98f 100644 --- a/DEPS +++ b/DEPS @@ -122,7 +122,7 @@ vars = { "intl_rev": "9669926609e7efc17dfd74fbb44ec719a7e573cc", "jinja2_rev": "2222b31554f03e62600cd7e383376a7c187967a1", "json_rpc_2_rev": "7e00f893440a72de0637970325e4ea44bd1e8c8e", - "linter_rev": "14c916a16e78315e212cf79e7ccf4c19159a1bda", + "linter_rev": "4305b933c8ed0275f26a99bd1ade39fe9130e6a5", # 1.23.0 "lints_rev": "8294e5648ab49474541527e2911e72e4c5aefe55", "logging_rev": "dfbe88b890c3b4f7bc06da5a7b3b43e9e263b688", "markdown_rev": "7479783f0493f6717e1d7ae31cb37d39a91026b2",