languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup in JsInvocationMirror: remove message about MirrorsUsed

Browse source 
Change-Id: I3aeeb0dfb2a3e76abd0b8587ab2e32b54cf726f6
Reviewed-on: https://dart-review.googlesource.com/66081
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Sigmund Cherem 2018-07-23 17:10:49 +00:00 committed by commit-bot@chromium.org
parent 1566b0dbc1
commit 21a582d886
1 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
sdk/lib/_internal/js_runtime/lib/js_helper.dart
View file

@ -49,7 +49,7 @@ import 'dart:_internal'
import 'dart:_native_typed_data';
import 'dart:_js_names'
show extractKeys, mangledNames, unmangleAllIdentifiersIfPreservedAnyways;
show extractKeys, unmangleAllIdentifiersIfPreservedAnyways;
part 'annotations.dart';
part 'constant_map.dart';
@ -312,30 +312,16 @@ class JSInvocationMirror implements Invocation {
var /* String or Symbol */ _memberName;
final String _internalName;
final int _kind;
final List<Type> _typeArguments;
final List _arguments;
final List _namedArgumentNames;
final int _typeArgumentCount;
/** Map from argument name to index in _arguments. */
Map<String, dynamic> _namedIndices = null;
JSInvocationMirror(this._memberName, this._internalName, this._kind,
this._arguments, this._namedArgumentNames, this._typeArgumentCount);
Symbol get memberName {
if (_memberName is Symbol) return _memberName;
String name = _memberName;
String unmangledName = mangledNames[name];
if (unmangledName != null) {
name = unmangledName.split(':')[0];
} else {
if (mangledNames[_internalName] == null) {
print("Warning: '$name' is used reflectively but not in MirrorsUsed. "
"This will break minified code.");
}
}
_memberName = new _symbol_dev.Symbol.unvalidated(name);
return _memberName;
return _memberName = new _symbol_dev.Symbol.unvalidated(_memberName);
}
bool get isMethod => _kind == METHOD;