languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Cache targetsIncludeComplexNoSuchMethod

Browse source 
This seems to speed up inferrer by 5-10%

Change-Id: I733159e9ec79212821444b4e502b28aa2bf81bdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263220
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2022-10-09 06:42:44 +00:00 committed by Commit Queue
parent cf61632921
commit 20fff85f10
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
View file

@ -1076,6 +1076,9 @@ class DynamicCallSiteTypeInformation<T extends ir.Node>
/// Cached concrete targets of this call.
Iterable<MemberEntity>? _concreteTargets;
/// Recomputed when _concreteTargets changes.
bool? _targetsIncludeComplexNoSuchMethod;
DynamicCallSiteTypeInformation(
AbstractValueDomain abstractValueDomain,
MemberTypeInformation context,
@ -1109,6 +1112,7 @@ class DynamicCallSiteTypeInformation<T extends ir.Node>
inferrer.closedWorld.includesClosureCall(selector!, typeMask);
final concreteTargets = _concreteTargets =
inferrer.closedWorld.locateMembers(selector!, typeMask);
_targetsIncludeComplexNoSuchMethod = null;
receiver.addUser(this);
if (arguments != null) {
arguments!.forEach((info) => info.addUser(this));
@ -1146,7 +1150,8 @@ class DynamicCallSiteTypeInformation<T extends ir.Node>
}
bool targetsIncludeComplexNoSuchMethod(InferrerEngine inferrer) {
return _concreteTargets!.any((MemberEntity e) {
return _targetsIncludeComplexNoSuchMethod ??=
_concreteTargets!.any((MemberEntity e) {
return e.isFunction &&
e.isInstanceMember &&
e.name == Identifiers.noSuchMethod_ &&
@ -1278,6 +1283,7 @@ class DynamicCallSiteTypeInformation<T extends ir.Node>
// Update the call graph if the targets could have changed.
if (!identical(concreteTargets, oldTargets)) {
_targetsIncludeComplexNoSuchMethod = null;
// Add calls to new targets to the graph.
concreteTargets
.where((target) => !oldTargets.contains(target))
@ -1372,6 +1378,7 @@ class DynamicCallSiteTypeInformation<T extends ir.Node>
inferrer.closedWorld.includesClosureCall(localSelector, mask);
final newConcreteTargets = _concreteTargets =
inferrer.closedWorld.locateMembers(localSelector, mask);
_targetsIncludeComplexNoSuchMethod = null;
for (MemberEntity element in newConcreteTargets) {
if (!oldTargets.contains(element)) {
MemberTypeInformation callee =