From 20b2a6bd521eedbbb3ca8b99ec939f7c684276a6 Mon Sep 17 00:00:00 2001 From: Kevin Chisholm Date: Thu, 24 Feb 2022 09:17:23 +0000 Subject: [PATCH] update breaking change policy Closes https://github.com/dart-lang/sdk/pull/48463 GitOrigin-RevId: c711f1456983b39f2b76ab1724e7373da45490ed Change-Id: I1208cb437cd41939ab4d3c2842bb681cb1be3f33 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234104 Reviewed-by: Alexander Thomas Commit-Queue: Alexander Thomas --- docs/process/breaking-changes.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/process/breaking-changes.md b/docs/process/breaking-changes.md index 4ea8bda9a55..65d85f77cc0 100644 --- a/docs/process/breaking-changes.md +++ b/docs/process/breaking-changes.md @@ -29,7 +29,7 @@ abide by the following basic conditions: * Must contain no static analysis **errors**. -* Must not rely on a certain runtime **error** being thrown (in other words, +* Must not rely on a certain runtime **error** being thrown (in other words, a new SDK might throw fewer errors than an old SDK). * Must access libraries via the public API (for example, must not reach into @@ -45,6 +45,13 @@ abide by the following basic conditions: Compatibility is only considered between stable releases (i.e. releases from the [Dart stable channel](https://dart.dev/tools/sdk/archive#stable-channel)). +## Breaking change implementation timing + +To avoid shipping features that have not been thoroughly vetted, we implement a +policy of not including breaking changes in the final beta before a release. +Breaking changes must be included in the beta before the final beta to be +considered for the next stable release. + ## Breaking change notification Anyone wishing to make a breaking change to Dart is expected to perform the @@ -76,7 +83,7 @@ to a change being released in a dev channel release. * A request that developers may leave comments in the linked issue, if this breaking change poses a severe problem. -Once you have sent the announce email, please let devoncarew@ know in order +Once you have sent the announce email, please let kevinjchisholm@ know in order to start the review and approval process. ### Step 2: Approval