Revert "[cfe/vm] Enable prefer_final lints in pkg/vm"

This reverts commit c2a32fe534.

Reason for revert: Reverting because enabling these lints without doing a cleanup breaks some peoples workflow. We'll discuss which path to take forward, and enable them again later.

Original change's description:
> [cfe/vm] Enable prefer_final lints in pkg/vm
> 
> As discussed by email, this adds the prefer_final_* lints to pkg/vm.
> 
> Adding the lints is a practical step forward, even though we do not enforce them with a presubmit check at this time.
> Next steps including cleaning up lint violations and adding a presubmit check.
> 
> Change-Id: I50c421ad06114b1ae4a5da422b375fd28d7150d6
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118542
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=johnniwinther@google.com,dacoharkes@google.com

Change-Id: I9dd908a0a594f9c23279ba3f5380382c239f5c2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118583
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>

pkg/vm/analysis_options.yaml

@@ -6,8 +6,3 @@ analyzer:
   exclude:
     - testcases/**
     - tool/**
-linter:
-  rules:
-    - prefer_final_fields
-    - prefer_final_in_for_each
-    - prefer_final_locals