languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 21:01:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate support of legacy type Dyamic

Browse source 
With this change, Dynamic is no longer implicitly converted
to dynamic.

This change breaks code that still uses Dynamic.
Review URL: https://codereview.chromium.org//11419176

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15404 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
hausner@google.com 2012-11-27 17:33:17 +00:00
parent a850cc252f
commit 1da3a82fbf
2 changed files with 3 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
runtime/vm/parser.cc
View file

@ -29,8 +29,6 @@ DEFINE_FLAG(bool, warning_as_error, false, "Treat warnings as errors.");
DEFINE_FLAG(bool, silent_warnings, false, "Silence warnings.");
DEFINE_FLAG(bool, warn_legacy_map_literal, false,
"Warning on legacy map literal syntax (single type argument)");
DEFINE_FLAG(bool, warn_legacy_dynamic, false,
"Warning on legacy type Dynamic)");
DEFINE_FLAG(bool, warn_legacy_getters, false,
"Warning on legacy getter syntax");
DEFINE_FLAG(bool, strict_function_literals, false,
@ -6723,9 +6721,7 @@ String* Parser::ExpectUserDefinedTypeIdentifier(const char* msg) {
ErrorMsg("%s", msg);
}
String* ident = CurrentLiteral();
// TODO(hausner): Remove check for 'Dynamic' once support for upper-case
// type dynamic is gone.
if (ident->Equals("Dynamic") || ident->Equals("dynamic")) {
if (ident->Equals("dynamic")) {
ErrorMsg("%s", msg);
}
ConsumeToken();
@ -8603,16 +8599,6 @@ RawAbstractType* Parser::ParseType(
SkipQualIdent();
} else {
ParseQualIdent(&type_name);
// TODO(hausner): Remove this once support for legacy type 'Dynamic'
// is removed.
if ((type_name.lib_prefix == NULL) && type_name.ident->Equals("Dynamic")) {
if (FLAG_warn_legacy_dynamic) {
Warning(type_name.ident_pos,
"legacy type 'Dynamic' found; auto-converting to 'dynamic'");
}
// Replace with lower-case 'dynamic'.
*type_name.ident ^= Symbols::Dynamic();
}
// An identifier cannot be resolved in a local scope when top level parsing.
if (!is_top_level_ &&
(type_name.lib_prefix == NULL) &&

4
tests/html/instance_of_test.dart
View file

@ -43,8 +43,8 @@ main() {
// expect(context, isNot(isCanvasPixelArray));
// FIXME(b/5286633): Interface injection type check workaround.
var image = context.createImageData(canvas.width as Dynamic,
canvas.height as Dynamic);
var image = context.createImageData(canvas.width as dynamic,
canvas.height as dynamic);
expect(image, isNot(isCanvasRenderingContext));
expect(image, isNot(isCanvasRenderingContext2D));
expect(image, isNot(isElement));