languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "[vm] Add type to _AsyncAwaitCompleter.start."

Browse source 
This reverts commit 9983424a3c.

Reason for revert: Breaks vm/dart/causal_stacks/async_throws_stack_no_causal_test

Original change's description:
> [vm] Add type to _AsyncAwaitCompleter.start.
> 
> Without the type, the call to the the parameter f() was being handled
> as a dynamic InstanceCall (smiable), so we had a megamorphic call to one
> of the Closure_XXXX_call methods (there are many copies of this method
> for different signatures) which in turn calls the closure.
> 
> Now that the type is present, we do a direct ClosureCall to the target.
> 
> This gives a measurable improvement to an important internal benchmark.
> 
> Change-Id: Ia9429879f69257465a2537616d8f8595fb1eefa8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138520
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Samir Jindel <sjindel@google.com>

TBR=kustermann@google.com,sjindel@google.com

Change-Id: I2deeebc24d80a7f444f4f53c5c8959b747fd1b29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138502
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
This commit is contained in:
Samir Jindel 2020-03-05 17:52:44 +00:00 committed by commit-bot@chromium.org
parent 2a8127dbfa
commit 1cf9d7a0c5
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sdk/lib/_internal/vm/lib/async_patch.dart
View file

@ -43,7 +43,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
}
}
void start(void Function() f) {
void start(f) {
f();
isSync = true;
}

2
sdk_nnbd/lib/_internal/vm/lib/async_patch.dart
View file

@ -41,7 +41,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
}
}
void start(void Function() f) {
void start(f) {
f();
isSync = true;
}