languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-04 16:03:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the old now-unused PubGetError test expectation.

Browse source 
I'd like to clean up more of these confusing expectations, but that's
harder. But this one seems like an easy fix since it's totally unused.

Change-Id: Ic624b12fc7122827e4d6b384d6d5388558bc7729
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297762
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
This commit is contained in:
Robert Nystrom 2023-04-28 13:15:26 +00:00 committed by Commit Queue
parent cda6ab570d
commit 1c19e5c417
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/status_file/lib/expectation.dart
View file

@ -79,11 +79,6 @@ class Expectation {
static final Expectation missingStaticWarning =
Expectation._('MissingStaticWarning', group: fail);
/// An invocation of "pub get" exited with a non-zero exit code.
// TODO(rnystrom): Is this still used? If not, remove.
static final Expectation pubGetError =
Expectation._('PubGetError', group: fail);
/// The stdout or stderr produced by the test was not valid UTF-8 and could
/// not be decoded.
// TODO(rnystrom): The only test that uses this expectation is the one that
@ -180,7 +175,6 @@ class Expectation {
missingCompileTimeError,
staticWarning,
missingStaticWarning,
pubGetError,
nonUtf8Error,
dartkCrash,
dartkTimeout,