[CFE] Cleanup incremental_load_from_dill_test yamls

Change-Id: I30012b08499e5c5a7babb74cb43706031fb3f4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118445
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

pkg/front_end/test/incremental_load_from_dill_test.dart

@@ -116,8 +116,11 @@ class RunCompilations extends Step<TestData, TestData, Context> {
 
   Future<Result<TestData>> run(TestData data, Context context) async {
     YamlMap map = data.map;
+    Set<String> keys = new Set<String>.from(map.keys.cast<String>());
+    keys.remove("type");
     switch (map["type"]) {
       case "basic":
+        keys.removeAll(["sources", "entry", "invalidate"]);
         await basicTest(
           map["sources"],
           map["entry"],
@@ -126,6 +129,7 @@ class RunCompilations extends Step<TestData, TestData, Context> {
         );
         break;
       case "newworld":
+        keys.removeAll(["worlds", "modules", "omitPlatform", "target"]);
         await newWorldTest(
           map["worlds"],
           map["modules"],
@@ -136,6 +140,8 @@ class RunCompilations extends Step<TestData, TestData, Context> {
       default:
         throw "Unexpected type: ${map['type']}";
     }
+
+    if (keys.isNotEmpty) throw "Unknown toplevel keys: $keys";
     return pass(data);
   }
 }

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_10.yaml

@@ -7,7 +7,6 @@
 # the same.
 
 type: newworld
-strong: true
 modules:
   module:
     module/a.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_11.yaml

@@ -7,7 +7,6 @@
 # the same.
 
 type: newworld
-strong: true
 modules:
   module:
     module/a.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_12.yaml

@@ -6,7 +6,6 @@
 # which - if loaded - pulls in more of itself.
 
 type: newworld
-strong: true
 modules:
   module:
     module/a.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_4.yaml

@@ -7,7 +7,6 @@
 # dill libraries.
 
 type: newworld
-strong: true
 modules:
   moduleB:
     moduleB/b.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_5.yaml

@@ -7,7 +7,6 @@
 # dill libraries.
 
 type: newworld
-strong: true
 modules:
   moduleB:
     moduleB/b.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_6.yaml

@@ -7,7 +7,6 @@
 # dill libraries.
 
 type: newworld
-strong: true
 modules:
   moduleB:
     moduleB/b.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_7.yaml

@@ -7,7 +7,6 @@
 # dill libraries.
 
 type: newworld
-strong: true
 modules:
   module:
     module/lib1.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_8.yaml

@@ -7,7 +7,6 @@
 # dill libraries.
 
 type: newworld
-strong: true
 modules:
   module:
     module/lib1.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/changing_modules_9.yaml

@@ -7,7 +7,6 @@
 # the same.
 
 type: newworld
-strong: true
 modules:
   moduleA:
     moduleA/a.dart: |

pkg/front_end/testcases/incremental_initialize_from_dill/crash_test_1.yaml

@@ -5,7 +5,6 @@
 # This have crashed at one point (assertion error).
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_10.yaml

@@ -10,7 +10,6 @@
 # Fix both and the error should go away.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_11.yaml

@@ -8,7 +8,6 @@
 # Fixing that should fix everything.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_6.yaml

@@ -7,7 +7,6 @@
 # we keep getting errors. Once we fix it, we no longer get errors.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_7.yaml

@@ -7,7 +7,6 @@
 # we keep getting errors. Once we fix it, we no longer get errors.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_8.yaml

@@ -8,7 +8,6 @@
 # Remove said file again and the error should go away.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources:

pkg/front_end/testcases/incremental_initialize_from_dill/reissue_errors_9.yaml

@@ -9,7 +9,6 @@
 # Any references to the constant shouldn't matter in this regard.
 
 type: newworld
-strong: true
 worlds:
   - entry: main.dart
     sources: