languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:09:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a recovery test based on reported failure (and fix a minor bug)

Browse source 
Change-Id: Ieaa0309559f7b2cc5c24741f16194c98f9ba0df2
Reviewed-on: https://dart-review.googlesource.com/51960
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson 2018-04-19 18:47:19 +00:00 committed by commit-bot@chromium.org
parent 2048137583
commit 1a56d6534c
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/dart/ast/utilities.dart
View file

@ -1792,7 +1792,7 @@ class AstComparator implements AstVisitor<bool> {
isEqualTokens(node.modifierKeyword, other.modifierKeyword) &&
isEqualNodes(node.returnType, other.returnType) &&
isEqualTokens(node.propertyKeyword, other.propertyKeyword) &&
isEqualTokens(node.propertyKeyword, other.propertyKeyword) &&
isEqualTokens(node.operatorKeyword, other.operatorKeyword) &&
isEqualNodes(node.name, other.name) &&
isEqualNodes(node.parameters, other.parameters) &&
isEqualNodes(node.body, other.body);

13
pkg/analyzer/test/src/fasta/recovery/missing_code_test.dart
View file

@ -293,6 +293,19 @@ f(x) {
testUserDefinableOperatorWithSuper('-');
}
@failingTest
void test_missingGet() {
testRecovery('''
class Bar {
int foo => 0;
}
''', [ParserErrorCode.MISSING_GET], '''
class Bar {
int get foo => 0;
}
''');
}
@failingTest
void test_parameterList_leftParen() {
// https://github.com/dart-lang/sdk/issues/22938