languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 10:36:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allocate error messages in old space: needed for background compilation and rarely done

Browse source 
BUG=
R=koda@google.com, regis@google.com

Review URL: https://codereview.chromium.org//1375443004 .
This commit is contained in:
Srdjan Mitrovic 2015-10-01 13:13:04 -07:00
parent 03e379de7a
commit 1a11dbfc1c
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
runtime/vm/object.cc
View file

@ -5862,7 +5862,9 @@ bool Function::AreValidArgumentCounts(intptr_t num_arguments,
"%" Pd " named passed, at most %" Pd " expected",
num_named_arguments,
NumOptionalNamedParameters());
*error_message = String::New(message_buffer);
// Allocate in old space because it can be invoked in background
// optimizing compilation.
*error_message = String::New(message_buffer, Heap::kOld);
}
return false; // Too many named arguments.
}
@ -5882,7 +5884,9 @@ bool Function::AreValidArgumentCounts(intptr_t num_arguments,
num_opt_pos_params > 0 ? " positional" : "",
num_opt_pos_params > 0 ? "at most " : "",
num_pos_params - num_hidden_params);
*error_message = String::New(message_buffer);
// Allocate in old space because it can be invoked in background
// optimizing compilation.
*error_message = String::New(message_buffer, Heap::kOld);
}
return false; // Too many fixed and/or positional arguments.
}
@ -5899,7 +5903,9 @@ bool Function::AreValidArgumentCounts(intptr_t num_arguments,
num_opt_pos_params > 0 ? " positional" : "",
num_opt_pos_params > 0 ? "at least " : "",
num_fixed_parameters() - num_hidden_params);
*error_message = String::New(message_buffer);
// Allocate in old space because it can be invoked in background
// optimizing compilation.
*error_message = String::New(message_buffer, Heap::kOld);
}
return false; // Too few fixed and/or positional arguments.
}
@ -5944,7 +5950,9 @@ bool Function::AreValidArguments(intptr_t num_arguments,
kMessageBufferSize,
"no optional formal parameter named '%s'",
argument_name.ToCString());
*error_message = String::New(message_buffer);
// Allocate in old space because it can be invoked in background
// optimizing compilation.
*error_message = String::New(message_buffer, Heap::kOld);
}
return false;
}
@ -5990,7 +5998,9 @@ bool Function::AreValidArguments(const ArgumentsDescriptor& args_desc,
kMessageBufferSize,
"no optional formal parameter named '%s'",
argument_name.ToCString());
*error_message = String::New(message_buffer);
// Allocate in old space because it can be invoked in background
// optimizing compilation.
*error_message = String::New(message_buffer, Heap::kOld);
}
return false;
}
@ -14530,8 +14540,7 @@ bool Instance::IsInstanceOf(const AbstractType& other,
}
Isolate* isolate = Isolate::Current();
const Class& cls = Class::Handle(isolate, clazz());
TypeArguments& type_arguments =
TypeArguments::Handle(isolate);
TypeArguments& type_arguments = TypeArguments::Handle(isolate);
if (cls.NumTypeArguments() > 0) {
type_arguments = GetTypeArguments();
ASSERT(type_arguments.IsNull() || type_arguments.IsCanonical());