languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 20:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix path matching for windows in analyze_test.dart.

Browse source 
Change-Id: I7afa9d7b9f13e78df373e214801e6716963870b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288544
Auto-Submit: Janice Collins <jcollins@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Janice Collins 2023-03-15 16:35:41 +00:00 committed by Commit Queue
parent 4b3bd7564c
commit 18a99b3536
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/dartdev/test/commands/analyze_test.dart
View file

@ -6,6 +6,7 @@ import 'package:cli_util/cli_logging.dart';
import 'package:dartdev/src/analysis_server.dart';
import 'package:dartdev/src/commands/analyze.dart';
import 'package:dartdev/src/sdk.dart';
import 'package:path/path.dart' as path;
import 'package:test/test.dart';
import '../utils.dart';
@ -229,7 +230,7 @@ void defineAnalyze() {
expect(result.exitCode, 3);
expect(result.stderr, isEmpty);
expect(result.stdout, contains('A value of type '));
expect(result.stdout, contains('lib/main.dart:1:16 '));
expect(result.stdout, contains('lib${path.separator}main.dart:1:16 '));
expect(result.stdout, contains('return_of_invalid_type'));
expect(result.stdout, contains('2 issues found.'));
});
@ -286,7 +287,7 @@ void defineAnalyze() {
expect(result.exitCode, 3);
expect(result.stderr, isEmpty);
expect(result.stdout, contains('A value of type '));
expect(result.stdout, contains('lib/main.dart:1:16 '));
expect(result.stdout, contains('lib${path.separator}main.dart:1:16 '));
expect(result.stdout, contains('return_of_invalid_type'));
expect(result.stdout, contains('1 issue found.'));
});
@ -397,9 +398,9 @@ void defineAnalyze() {
expect(result.exitCode, equals(_warningExitCode));
expect(result.stderr, isEmpty);
expect(result.stdout, contains('lib/main.dart:2:6 '));
expect(result.stdout, contains('lib${path.separator}main.dart:2:6 '));
expect(result.stdout, contains('TODO: Implement this - todo'));
expect(result.stdout, contains('lib/main.dart:3:6 '));
expect(result.stdout, contains('lib${path.separator}main.dart:3:6 '));
expect(result.stdout, contains('FIXME: Fix this - fixme'));
expect(result.stdout, contains('2 issues found.'));
});
@ -454,7 +455,7 @@ int f() {
group('--packages', () {
test('existing', () async {
final foo = project(name: 'foo');
foo.file('lib/foo.dart', 'var my_foo = 0;');
foo.file('lib${path.separator}foo.dart', 'var my_foo = 0;');
p = project(mainSrc: '''
import 'package:foo/foo.dart';
@ -572,7 +573,7 @@ void f() {
expect(logger.stderrBuffer, isEmpty);
final stdout = logger.stdoutBuffer.toString().trim();
expect(stdout, contains('info'));
expect(stdout, contains('lib/test.dart:15:4'));
expect(stdout, contains('lib${path.separator}test.dart:15:4'));
expect(stdout, contains('Foo bar baz.'));
expect(stdout, contains('dead_code'));
});