languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Delete approve_results.

Browse source 
Change-Id: I43346ff69e6b82f700a06b52bdff891122d38572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128551
Reviewed-by: Alexander Thomas <athom@google.com>
This commit is contained in:
Jonas Termansen 2020-03-25 10:27:40 +00:00
parent 81f5bf98b1
commit 188ab04445
4 changed files with 3 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/co19/update.sh
View file

@ -63,8 +63,5 @@ git cl web
set +x
cat << EOF
Wait for the builders to finish. If any failed, pre-approve them:
tools/sdks/dart-sdk/bin/dart tools/approve_results.dart \
-p https://dart-review.googlesource.com/c/sdk/+/$ISSUE
Wait for the builders to finish. If any failed, pre-approve them.
EOF

5
tests/co19_2/update.sh
View file

@ -64,8 +64,5 @@ git cl web
set +x
cat << EOF
Wait for the builders to finish. If any failed, pre-approve them:
tools/sdks/dart-sdk/bin/dart tools/approve_results.dart \
-p https://dart-review.googlesource.com/c/sdk/+/$ISSUE
Wait for the builders to finish. If any failed, pre-approve them.
EOF

19
tools/approve_results.dart
View file

@ -1,19 +0,0 @@
#!/usr/bin/env dart
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
main(List<String> args) async {
print("""
This command-line approval script is no longer used.
You can approve test failures using the web UI at
<https://dart-ci.firebaseapp.com/>.
Please see instructions for approving failing tests
at:
https://goto.google.com/dart-test-approval
https://goto.google.com/dart-status-file-free-workflow
https://goto.google.com/dart-test-approval-faq""");
}

6
tools/bots/results.dart
View file

@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// results.json and flaky.json parses.
// results.json and flaky.json parser.
import 'dart:async';
import 'dart:convert';
@ -17,10 +17,6 @@ String gsutilPy;
/// Cloud storage location containing results.
const testResultsStoragePath = "gs://dart-test-results/builders";
/// Cloud storage location containing approved results.
const approvedResultsStoragePath =
"gs://dart-test-results-approved-results/builders";
/// Limit the number of concurrent subprocesses by half the number of cores.
final gsutilPool = new Pool(max(1, Platform.numberOfProcessors ~/ 2));