languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Avoid warnings in pkg/js_ast

Browse source 
Change-Id: I883230beeed33878115940982ade5cd6844d26ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108812
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
This commit is contained in:
Johnni Winther 2019-07-12 15:51:23 +00:00 committed by commit-bot@chromium.org
parent e82ca2f366
commit 178cfe6111
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/js_ast/lib/src/builder.dart
View file

@ -318,6 +318,7 @@ class JsBuilder {
case "\v":
return r"\v";
}
throw new UnsupportedError("Unexpected match: ${match.group(0)}");
});
LiteralString result = string(escaped);
// We don't escape ' under the assumption that the string is wrapped

20
pkg/js_ast/lib/src/template.dart
View file

@ -199,7 +199,8 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
var value = arguments[nameOrPosition];
if (value is Expression) return value;
if (value is String) return convertStringToVariableUse(value);
error('Interpolated value #$nameOrPosition is not an Expression: $value');
throw error(
'Interpolated value #$nameOrPosition is not an Expression: $value');
};
}
@ -209,7 +210,8 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
var value = arguments[nameOrPosition];
if (value is Declaration) return value;
if (value is String) return convertStringToVariableDeclaration(value);
error('Interpolated value #$nameOrPosition is not a declaration: $value');
throw error(
'Interpolated value #$nameOrPosition is not a declaration: $value');
};
}
@ -221,7 +223,7 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
Expression toExpression(item) {
if (item is Expression) return item;
if (item is String) return convertStringToVariableUse(item);
return error('Interpolated value #$nameOrPosition is not '
throw error('Interpolated value #$nameOrPosition is not '
'an Expression or List of Expressions: $value');
}
@ -249,7 +251,7 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
Parameter toParameter(item) {
if (item is Parameter) return item;
if (item is String) return new Parameter(item);
return error('Interpolated value #$nameOrPosition is not a Parameter or'
throw error('Interpolated value #$nameOrPosition is not a Parameter or'
' List of Parameters: $value');
}
@ -267,7 +269,8 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
var value = arguments[nameOrPosition];
if (value is Expression) return value;
if (value is String) return new LiteralString('"$value"');
error('Interpolated value #$nameOrPosition is not a selector: $value');
throw error(
'Interpolated value #$nameOrPosition is not a selector: $value');
};
}
@ -276,7 +279,8 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
return (arguments) {
var value = arguments[nameOrPosition];
if (value is Node) return value.toStatement();
error('Interpolated value #$nameOrPosition is not a Statement: $value');
throw error(
'Interpolated value #$nameOrPosition is not a Statement: $value');
};
}
@ -288,7 +292,7 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
Statement toStatement(item) {
if (item is Statement) return item;
if (item is Expression) return item.toStatement();
return error('Interpolated value #$nameOrPosition is not '
throw error('Interpolated value #$nameOrPosition is not '
'a Statement or List of Statements: $value');
}
@ -370,7 +374,7 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {
if (value is bool) return value;
if (value is Expression) return value;
if (value is String) return convertStringToVariableUse(value);
error('Interpolated value #$nameOrPosition '
throw error('Interpolated value #$nameOrPosition '
'is not an Expression: $value');
};
}