languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 19:40:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for '!' operator when report HintCode.NULL_CHECK_ALWAYS_FAILS

Browse source 
Follow up for:
https://dart-review.googlesource.com/c/sdk/+/170122

Change-Id: If9b3cb1a18ecd7cf21149dbd0fda4ec209506b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2020-11-04 03:43:25 +00:00 committed by commit-bot@chromium.org
parent ffc36db613
commit 1726476120
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/analyzer/lib/src/error/best_practices_verifier.dart
View file

@ -613,7 +613,8 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
@override
void visitPostfixExpression(PostfixExpression node) {
_deprecatedVerifier.postfixExpression(node);
if (node.operand.staticType?.isDartCoreNull ?? false) {
if (node.operator.type == TokenType.BANG &&
node.operand.staticType.isDartCoreNull) {
_errorReporter.reportErrorForNode(HintCode.NULL_CHECK_ALWAYS_FAILS, node);
}
super.visitPostfixExpression(node);

4
pkg/analyzer/test/src/diagnostics/null_check_always_fails_test.dart
View file

@ -37,10 +37,10 @@ void f() {
test_nullLiteral_parenthesized() async {
await assertErrorsInCode(r'''
void f() {
null!;
(null)!;
}
''', [
error(HintCode.NULL_CHECK_ALWAYS_FAILS, 13, 5),
error(HintCode.NULL_CHECK_ALWAYS_FAILS, 13, 7),
]);
}