languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-02 23:39:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

[benchmark] Adjust UTF-8 decode benchmark to reflect more typical use.

Browse source 
The majority of UTF-8 decoding in Dart programs is done via the
utf8.decode() call. Therefore, our benchmark should do the same to
better reflect realistic use.

Change-Id: I080edf689a8acd329bb2ee4d54a3de842f387a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145594
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
This commit is contained in:
Aske Simon Christensen 2020-05-01 15:21:13 +00:00 committed by commit-bot@chromium.org
parent 7082e99c28
commit 16b4cbc0df
1 changed files with 15 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
benchmarks/Utf8Decode/dart/Utf8Decode.dart
View file

@ -21,9 +21,7 @@ class Utf8Decode extends BenchmarkBase {
final String text;
final int size;
final bool allowMalformed;
final Utf8Decoder decoder;
Uint8List data;
List<int> chunks;
List<Uint8List> chunks;
int totalInputSize;
int totalOutputSize;
@ -37,27 +35,27 @@ class Utf8Decode extends BenchmarkBase {
}
Utf8Decode(this.language, this.text, this.size, this.allowMalformed)
: decoder = Utf8Decoder(allowMalformed: allowMalformed),
super(_makeName(language, size, allowMalformed));
: super(_makeName(language, size, allowMalformed));
@override
void setup() {
data = utf8.encode(text) as Uint8List;
Uint8List data = utf8.encode(text) as Uint8List;
if (data.length != 10000) {
throw "Expected input data of exactly 10000 bytes.";
}
if (size < data.length) {
// Split into chunks.
chunks = <int>[];
chunks.add(0);
chunks = <Uint8List>[];
int startPos = 0;
for (int pos = size; pos < data.length; pos += size) {
int chunkPos = pos;
while ((data[chunkPos] & 0xc0) == 0x80) {
chunkPos--;
int endPos = pos;
while ((data[endPos] & 0xc0) == 0x80) {
endPos--;
}
chunks.add(chunkPos);
chunks.add(Uint8List.fromList(data.sublist(startPos, endPos)));
startPos = endPos;
}
chunks.add(data.length);
chunks.add(Uint8List.fromList(data.sublist(startPos, data.length)));
totalInputSize = data.length;
totalOutputSize = text.length;
} else if (size > data.length) {
@ -66,13 +64,12 @@ class Utf8Decode extends BenchmarkBase {
for (int i = 0; i < size; i++) {
expanded[i] = data[i % data.length];
}
chunks = <int>[0, size];
chunks = <Uint8List>[expanded];
totalInputSize = size;
totalOutputSize = text.length * size ~/ data.length;
data = expanded;
} else {
// Use data as is.
chunks = <int>[0, data.length];
chunks = <Uint8List>[data];
totalInputSize = data.length;
totalOutputSize = text.length;
}
@ -81,9 +78,8 @@ class Utf8Decode extends BenchmarkBase {
@override
void run() {
int lengthSum = 0;
final int numChunks = chunks.length - 1;
for (int i = 0; i < numChunks; i++) {
final String s = decoder.convert(data, chunks[i], chunks[i + 1]);
for (int i = 0; i < chunks.length; i++) {
final String s = utf8.decode(chunks[i], allowMalformed: allowMalformed);
lengthSum += s.length;
}
if (lengthSum != totalOutputSize) {