mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 08:24:39 +00:00
[vm] Read causal-async-stacks/lazy-async-stacks from snapshot (instead of requiring AOT runtime to pass same flags as in compiler)
We already do this for "use-bare-instructions" and "dwarf-stack-traces". This CL does the same for "causal-async-stacks" and "lazy-async-stacks". Issue https://github.com/dart-lang/sdk/issues/39525 Change-Id: I44136299858b3b72e8a3a176234f5051d6b61c1d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130364 Reviewed-by: Teagan Strickland <sstrickl@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
parent
21e3580519
commit
16697697d4
|
@ -843,8 +843,9 @@ const char* Dart::FeaturesString(Isolate* isolate,
|
|||
ADD_FLAG(#name, value); \
|
||||
} while (0);
|
||||
|
||||
VM_GLOBAL_FLAG_LIST(ADD_FLAG);
|
||||
if (Snapshot::IncludesCode(kind)) {
|
||||
VM_GLOBAL_FLAG_LIST(ADD_FLAG);
|
||||
|
||||
// enabling assertions affects deopt ids.
|
||||
ADD_ISOLATE_FLAG(asserts, enable_asserts, FLAG_enable_asserts);
|
||||
if (kind == Snapshot::kFullJIT) {
|
||||
|
@ -852,9 +853,6 @@ const char* Dart::FeaturesString(Isolate* isolate,
|
|||
FLAG_use_field_guards);
|
||||
ADD_ISOLATE_FLAG(use_osr, use_osr, FLAG_use_osr);
|
||||
}
|
||||
buffer.AddString(FLAG_causal_async_stacks ? " causal_async_stacks"
|
||||
: " no-causal_async_stacks");
|
||||
|
||||
#if !defined(PRODUCT)
|
||||
buffer.AddString(FLAG_code_comments ? " code-comments"
|
||||
: " no-code-comments");
|
||||
|
@ -890,10 +888,6 @@ const char* Dart::FeaturesString(Isolate* isolate,
|
|||
#endif
|
||||
}
|
||||
|
||||
if (FLAG_precompiled_mode && FLAG_dwarf_stack_traces) {
|
||||
buffer.AddString(" dwarf-stack-traces");
|
||||
}
|
||||
|
||||
if (Dart::non_nullable_flag()) {
|
||||
buffer.AddString(" nnbd-experiment");
|
||||
}
|
||||
|
|
|
@ -250,6 +250,8 @@ constexpr bool kDartUseBackgroundCompilation = true;
|
|||
// V(name, command-line-flag-name)
|
||||
#define VM_GLOBAL_FLAG_LIST(V) \
|
||||
V(dwarf_stack_traces, FLAG_dwarf_stack_traces) \
|
||||
V(causal_async_stacks, FLAG_causal_async_stacks) \
|
||||
V(lazy_async_stacks, FLAG_lazy_async_stacks) \
|
||||
V(use_bare_instructions, FLAG_use_bare_instructions)
|
||||
|
||||
#endif // RUNTIME_VM_FLAG_LIST_H_
|
||||
|
|
Loading…
Reference in a new issue