From 13ce2a8de415921d7c67680fb4ae1987468420ab Mon Sep 17 00:00:00 2001 From: Jonas Termansen Date: Fri, 21 Feb 2020 13:33:31 +0000 Subject: [PATCH] [dart:io] Update CHANGELOG for new socket option semantics. This is a breaking change. https://github.com/dart-lang/sdk/issues/40702 The change originally landed in fddbc53a640047ab6a7b7ef02e76cbdcb7b27ddf but it was decided to file a breaking change request about this change as it is observable. Change-Id: Ie9b045f3abec858486d8efb335eedf2c68e78951 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136583 Reviewed-by: Lasse R.H. Nielsen --- CHANGELOG.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1009575e9b1..4dc9ab3e38a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,10 +34,11 @@ Same change is applied to `set`. `preserveHeaderCase` will preserve the case of `name` instead of converting them to lowercase. `HttpHeader.forEach()` provides the current case of each header. -* The `Socket` class will now throw a `SocketException` if the socket has been - destroyed or upgraded to a secure socket upon setting or getting socket - options. Previously setting a socket options would be ignored and getting a - socket option would return `null`. +* **Breaking change** [#40702](https://github.com/dart-lang/sdk/issues/40702): + The `Socket` class will now throw a `SocketException` if the socket has been + explicitly destroyed or upgraded to a secure socket upon setting or getting + socket options. Previously setting a socket option would be ignored and + getting a socket option would return `null`. * **Breaking change** [#40483](https://github.com/dart-lang/sdk/issues/40483): The `Process` class will now throw a `StateError` if the process is detached