languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ VM ] Avoid pausing system isolates on start/shutdown

Browse source 
Can cause unexpected behavior when combined with
--mark-main-isolate-as-system-isolate

TEST=Confirmed main isolate used to pause on start and not output anything to console. Applied fix, sample ran to completion.

Change-Id: I355deaa7f30909b345f38c85ec5a7ccb358b43c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211881
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jacob Richman <jacobr@google.com>
This commit is contained in:
Ben Konyi 2021-08-30 19:07:27 +00:00 committed by commit-bot@chromium.org
parent 6382d1ab17
commit 127fcf872a
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
runtime/vm/dart.cc
View file

@ -1065,8 +1065,7 @@ ErrorPtr Dart::InitializeIsolate(const uint8_t* snapshot_data,
}
#if !defined(PRODUCT)
ServiceIsolate::MaybeMakeServiceIsolate(I);
if (!ServiceIsolate::IsServiceIsolate(I) &&
!KernelIsolate::IsKernelIsolate(I)) {
if (!Isolate::IsSystemIsolate(I)) {
I->message_handler()->set_should_pause_on_start(
FLAG_pause_isolates_on_start);
I->message_handler()->set_should_pause_on_exit(FLAG_pause_isolates_on_exit);