languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-03 20:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed memory leak in SetTrustedCertificates in SecurityContext

Browse source 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2923163004 .
This commit is contained in:
Ben Konyi 2017-06-06 14:02:47 -07:00
parent b18c325f68
commit 0e164c043f
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
runtime/bin/security_context.cc
View file

@ -228,20 +228,22 @@ static int SetTrustedCertificatesBytesPEM(SSL_CTX* context, BIO* bio) {
void SSLCertContext::SetTrustedCertificatesBytes(Dart_Handle cert_bytes,
const char* password) {
ScopedMemBIO bio(cert_bytes);
int status = SetTrustedCertificatesBytesPEM(context(), bio.bio());
if (status == 0) {
if (SecureSocketUtils::NoPEMStartLine()) {
int status = 0;
{
ScopedMemBIO bio(cert_bytes);
status = SetTrustedCertificatesBytesPEM(context(), bio.bio());
if (status == 0) {
if (SecureSocketUtils::NoPEMStartLine()) {
ERR_clear_error();
BIO_reset(bio.bio());
status =
SetTrustedCertificatesBytesPKCS12(context(), bio.bio(), password);
}
} else {
// The PEM file was successfully parsed.
ERR_clear_error();
BIO_reset(bio.bio());
status =
SetTrustedCertificatesBytesPKCS12(context(), bio.bio(), password);
}
} else {
// The PEM file was successfully parsed.
ERR_clear_error();
}
SecureSocketUtils::CheckStatus(status, "TlsException",
"Failure trusting builtin roots");
}