languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vm] Finish removing legacy restart mechanism.

Browse source 
Cf. a4adbffb50.

TEST=ci
Change-Id: I9d2517c6cb0b5630990d087812e9a54241f41bb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280043
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2023-01-31 18:28:59 +00:00 committed by Commit Queue
parent ee32255b21
commit 0c87126ea2
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
runtime/vm/message_handler.cc
View file

@ -44,8 +44,6 @@ const char* MessageHandler::MessageStatusString(MessageStatus status) {
return "OK";
case kError:
return "Error";
case kRestart:
return "Restart";
case kShutdown:
return "Shutdown";
default:
@ -358,9 +356,8 @@ bool MessageHandler::ShouldPauseOnStart(MessageStatus status) const {
}
// If we are restarting or shutting down, we do not want to honor
// should_pause_on_start or should_pause_on_exit.
return (status != MessageHandler::kRestart &&
status != MessageHandler::kShutdown) &&
should_pause_on_start() && owning_isolate->is_runnable();
return (status != MessageHandler::kShutdown) && should_pause_on_start() &&
owning_isolate->is_runnable();
}
bool MessageHandler::ShouldPauseOnExit(MessageStatus status) const {
@ -368,9 +365,8 @@ bool MessageHandler::ShouldPauseOnExit(MessageStatus status) const {
if (owning_isolate == NULL) {
return false;
}
return (status != MessageHandler::kRestart &&
status != MessageHandler::kShutdown) &&
should_pause_on_exit() && owning_isolate->is_runnable();
return (status != MessageHandler::kShutdown) && should_pause_on_exit() &&
owning_isolate->is_runnable();
}
#endif

1
runtime/vm/message_handler.h
View file

@ -25,7 +25,6 @@ class MessageHandler {
enum MessageStatus {
kOK, // We successfully handled a message.
kError, // We encountered an error handling a message.
kRestart, // The VM is restarting.
kShutdown, // The VM is shutting down.
};
static const char* MessageStatusString(MessageStatus status);