languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-19 20:17:27 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[vm] Fix ia32/x64 gcc build.

Browse source 
(The simulators are broken at runtime.)

Change-Id: I10089cad44fca57145cfdd598342279f07c6d7fd
Reviewed-on: https://dart-review.googlesource.com/75205
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2018-09-17 22:27:43 +00:00 committed by commit-bot@chromium.org
parent c1ea77a3a0
commit 0c80630577
8 changed files with 41 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
build/config/compiler/BUILD.gn
View file

@ -690,11 +690,13 @@ if (is_win) {
# See http://lwn.net/Articles/192624/ .
"-Wl,-O1",
"-Wl,--gc-sections",
]
if (is_clang) {
# Identical code folding to reduce size.
# Warning: This changes C/C++ semantics of function pointer comparison.
"-Wl,--icf=all",
]
common_optimize_on_ldflags += [ "-Wl,--icf=all" ]
}
if (!using_sanitizer) {
# Functions interposed by the sanitizers can make ld think

1
runtime/BUILD.gn
View file

@ -158,6 +158,7 @@ config("dart_config") {
"-Wvla",
"-Wno-conversion-null",
"-Woverloaded-virtual",
"-Wno-comments", # Conflicts with clang-format.
"-g3",
"-ggdb3",
"-fno-rtti",

20
runtime/bin/options.h
View file

@ -119,7 +119,25 @@ class CallbackOptionProcessor : public OptionProcessor {
static OptionProcessor_##name option_##name;
#define DEFINE_BOOL_OPTION(name, variable) \
DEFINE_BOOL_OPTION_CB(name, { variable = true; })
class OptionProcessor_##name : public OptionProcessor { \
public: \
virtual bool Process(const char* option, CommandLineOptions* vm_options) { \
const char* value = OptionProcessor::ProcessOption(option, "--" #name); \
if (value == NULL) { \
return false; \
} \
if (*value == '=') { \
Log::PrintErr("Non-empty value for option " #name "\n"); \
return false; \
} \
if (*value != '\0') { \
return false; \
} \
variable = true; \
return true; \
} \
}; \
static OptionProcessor_##name option_##name;
#define DEFINE_BOOL_OPTION_SHORT(short_name, long_name, variable) \
class OptionProcessor_##long_name : public OptionProcessor { \

1
runtime/vm/compiler/backend/il_arm64.cc
View file

@ -1141,7 +1141,6 @@ void LoadIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
(representation() == kUnboxedFloat64x2)) {
const VRegister result = locs()->out(0).fpu_reg();
switch (class_id()) {
ASSERT(aligned());
case kTypedDataFloat32ArrayCid:
// Load single precision float.
if (aligned()) {

1
runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
View file

@ -1190,6 +1190,7 @@ FlowGraph* StreamingFlowGraphBuilder::BuildGraphOfDynamicInvocationForwarder() {
first_parameter_offset = ReaderOffset() + data_program_offset_;
}
}
USE(first_parameter_offset);
// Current position: About to read list of positionals.
// Should never build a dynamic invocation forwarder for equality

5
runtime/vm/exceptions.cc
View file

@ -283,6 +283,9 @@ class ExceptionHandlerFinder : public StackResource {
case CatchEntryMove::SourceKind::kUint32Slot:
value = Integer::New(*SlotAt<uint32_t>(fp, move.src_slot()));
break;
default:
UNREACHABLE();
}
*TaggedSlotAt(fp, move.dest_slot()) = value;
@ -296,7 +299,7 @@ class ExceptionHandlerFinder : public StackResource {
NoSafepointScope no_safepoint;
ReadStream stream(static_cast<uint8_t*>(td.DataAddr(0)), td.Length());
intptr_t prefix_length, suffix_length, suffix_offset;
intptr_t prefix_length = 0, suffix_length = 0, suffix_offset = 0;
while (stream.PendingBytes() > 0) {
intptr_t target_pc_offset = Reader::Read(&stream);
prefix_length = Reader::Read(&stream);

18
runtime/vm/interpreter.cc
View file

@ -890,7 +890,7 @@ DART_NOINLINE bool Interpreter::InvokeCompiled(Thread* thread,
UNIMPLEMENTED();
#endif
ASSERT(Function::HasCode(function));
RawCode* code = function->ptr()->code_;
RawCode* volatile code = function->ptr()->code_;
ASSERT(code != StubCode::LazyCompile_entry()->code());
// TODO(regis): Once we share the same stack, try to invoke directly.
#if defined(DEBUG)
@ -902,9 +902,9 @@ DART_NOINLINE bool Interpreter::InvokeCompiled(Thread* thread,
// On success, returns a RawInstance. On failure, a RawError.
typedef RawObject* (*invokestub)(RawCode * code, RawArray * argdesc,
RawObject * *arg0, Thread * thread);
invokestub entrypoint = reinterpret_cast<invokestub>(
invokestub volatile entrypoint = reinterpret_cast<invokestub>(
StubCode::InvokeDartCodeFromBytecode_entry()->EntryPoint());
RawObject* result;
RawObject* volatile result;
Exit(thread, *FP, call_top + 1, *pc);
{
InterpreterSetjmpBuffer buffer(this);
@ -969,11 +969,13 @@ DART_NOINLINE bool Interpreter::ProcessInvocation(bool* invoked,
RawField* field = reinterpret_cast<RawField*>(function->ptr()->data_);
intptr_t offset_in_words = Smi::Value(field->ptr()->value_.offset_);
RawAbstractType* field_type = field->ptr()->type_;
const classid_t cid =
field_type->GetClassId() == kTypeCid
? Smi::Value(reinterpret_cast<RawSmi*>(
Type::RawCast(field_type)->ptr()->type_class_id_))
: kIllegalCid; // Not really illegal, but not a Type to skip.
classid_t cid;
if (field_type->GetClassId() == kTypeCid) {
cid = Smi::Value(reinterpret_cast<RawSmi*>(
Type::RawCast(field_type)->ptr()->type_class_id_));
} else {
cid = kIllegalCid; // Not really illegal, but not a Type to skip.
}
// Perform type test of value if field type is not one of dynamic, object,
// or void, and if the value is not null.
RawObject* null_value = Object::null();

3
runtime/vm/simulator_arm.cc
View file

@ -1592,8 +1592,8 @@ DART_FORCE_INLINE void Simulator::DecodeType01(Instr* instr) {
// Registers rd, rn, rm, ra are encoded as rn, rm, rs, rd.
// Format(instr, "mls'cond's 'rn, 'rm, 'rs, 'rd");
rd_val = get_register(rd);
// fall through
}
/* Falls through */
case 0: {
// Registers rd, rn, rm are encoded as rn, rm, rs.
// Format(instr, "mul'cond's 'rn, 'rm, 'rs");
@ -1650,6 +1650,7 @@ DART_FORCE_INLINE void Simulator::DecodeType01(Instr* instr) {
// umaal is only in ARMv6 and above.
UnimplementedInstruction(instr);
}
/* Falls through */
case 5:
// Registers rd_lo, rd_hi, rn, rm are encoded as rd, rn, rm, rs.
// Format(instr, "umlal'cond's 'rd, 'rn, 'rm, 'rs");