languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Update a test for dart2wasm

Browse source 
The test stacktrace_current compares two stack traces by masking any
line numbers.

With dart2wasm, V8 shows function offsets instead of line numbers, in
hex, which causes the test to fail with unrelated changes.

This updates the regex to mask hex numbers as well, making the test
stable with unrelated dart2wasm changes.

Change-Id: I8dd951d4bf29fe39b6ec5d8de7bf2c9c37a5b5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275600
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This commit is contained in:
Ömer Sinan Ağacan 2022-12-14 13:41:46 +00:00 committed by Commit Queue
parent af5c53b087
commit 0bb3b53194
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/corelib/stacktrace_current_test.dart
View file

@ -19,10 +19,12 @@ void main() {
var st0s = findMain(st0);
var st1s = findMain(st1);
// Stack traces are not equal (contains at least a different line number,
// and possible different frame numbers).
// Stack traces are not equal (contains at least a different line number, and
// possibly different frame numbers).
// They are *similar*, so check that they agree on everything but numbers.
var digits = new RegExp(r"\d+");
// Also match hex digits as V8 (used by dart2wasm) shows function offsets in
// hex.
final digits = new RegExp(r"(0[xX][0-9a-fA-F]+)|\d+");
Expect.equals(st0s.replaceAll(digits, "0"), st1s.replaceAll(digits, "0"));
}