languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[analysis_server] AddExplicitCast for as

Browse source 
Bug: #49896
Change-Id: Iddbe616db0edadf57ad76637863ad7a29533a77b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260111
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Ahmed Ashour 2022-10-10 21:26:15 +00:00 committed by Commit Queue
parent ecb992586a
commit 0a23e439e9
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/analysis_server/lib/src/services/correction/dart/add_explicit_cast.dart
View file

@ -11,6 +11,7 @@ import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/src/dart/ast/extensions.dart';
import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
import 'package:analyzer_plugin/utilities/range_factory.dart';
class AddExplicitCast extends CorrectionProducer {
@override
@ -66,7 +67,12 @@ class AddExplicitCast extends CorrectionProducer {
}
}
if (target is AsExpression) {
// TODO(brianwilkerson) Consider updating the right operand.
var type = target.type;
await builder.addDartFileEdit(file, (builder) {
builder.addReplacement(range.node(type), (builder) {
builder.writeType(toType);
});
});
return;
}

10
pkg/analysis_server/test/src/services/correction/fix/add_explicit_cast_test.dart
View file

@ -51,7 +51,15 @@ class A {}
class B {}
class C {}
''');
await assertNoFix();
await assertHasFix('''
f(A a) {
C c = a as C;
print(c);
}
class A {}
class B {}
class C {}
''');
}
Future<void> test_assignment_general() async {