[CFE] Delete unused stuff

Change-Id: I54158b983d7636b47a6356b44c2dff4b4ac7ef1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300202
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

pkg/front_end/lib/src/fasta/dill/dill_loader.dart

@@ -274,7 +274,6 @@ severity: $severity
       {bool Function(Uri uri)? filter, int byteCount = 0}) {
     List<Library> componentLibraries = component.libraries;
     List<Uri> requestedLibraries = <Uri>[];
-    List<Uri> requestedLibrariesFileUri = <Uri>[];
     for (int i = 0; i < componentLibraries.length; i++) {
       Library library = componentLibraries[i];
       Uri uri = library.importUri;
@@ -282,7 +281,6 @@ severity: $severity
         libraries.add(library);
         registerKnownLibrary(library);
         requestedLibraries.add(uri);
-        requestedLibrariesFileUri.add(library.fileUri);
       }
     }
     List<DillLibraryBuilder> result = <DillLibraryBuilder>[];

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -1142,7 +1142,6 @@ class BodyBuilder extends StackListenerImpl
     debugEvent("finishFields");
     assert(checkState(null, [/*field count*/ ValueKinds.Integer]));
     int count = pop() as int;
-    List<SourceFieldBuilder> fields = [];
     for (int i = 0; i < count; i++) {
       assert(checkState(null, [
         ValueKinds.FieldInitializerOrNull,
@@ -1171,7 +1170,6 @@ class BodyBuilder extends StackListenerImpl
       } else {
         continue;
       }
-      fields.add(fieldBuilder);
       if (initializer != null) {
         if (fieldBuilder.hasBodyBeenBuilt) {
           // The initializer was already compiled (e.g., if it appear in the

pkg/front_end/lib/src/fasta/source/source_enum_builder.dart

@@ -521,7 +521,7 @@ class SourceEnumBuilder extends SourceClassBuilder {
       ..synthesizedDefaultConstructorBuilder =
           synthesizedDefaultConstructorBuilder;
 
-    void setParent(String name, MemberBuilder? builder) {
+    void setParent(MemberBuilder? builder) {
       while (builder != null) {
         builder.parent = enumBuilder;
         builder = builder.next as MemberBuilder?;
@@ -550,13 +550,12 @@ class SourceEnumBuilder extends SourceClassBuilder {
               ]);
         }
       }
-      setParent(name, member as MemberBuilder);
+      setParent(member as MemberBuilder);
     }
 
     members.forEach(setParentAndCheckConflicts);
     constructorScope
-        .filteredNameIterator(
-            includeDuplicates: false, includeAugmentations: true)
+        .filteredIterator(includeDuplicates: false, includeAugmentations: true)
         .forEach(setParent);
     selfType.bind(libraryBuilder, enumBuilder);
 
@@ -616,19 +615,6 @@ class SourceEnumBuilder extends SourceClassBuilder {
     Class cls = super.build(coreLibrary);
     cls.isEnum = true;
 
-    List<Expression> values = <Expression>[];
-    if (enumConstantInfos != null) {
-      for (EnumConstantInfo? enumConstantInfo in enumConstantInfos!) {
-        if (enumConstantInfo != null) {
-          Builder declaration = firstMemberNamed(enumConstantInfo.name)!;
-          if (declaration.isField) {
-            SourceFieldBuilder fieldBuilder = declaration as SourceFieldBuilder;
-            values.add(new StaticGet(fieldBuilder.field));
-          }
-        }
-      }
-    }
-
     // The super initializer for the synthesized default constructor is
     // inserted here if the enum's supertype is _Enum to preserve the legacy
     // behavior or having the old-style enum constants built in the outlines.

pkg/front_end/lib/src/fasta/source/source_library_builder.dart

@@ -1959,7 +1959,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
     constructorReferences.clear();
     Map<String, TypeVariableBuilder>? typeVariablesByName =
         checkTypeVariables(typeVariables, classBuilder);
-    void setParent(String name, MemberBuilder? member) {
+    void setParent(MemberBuilder? member) {
       while (member != null) {
         member.parent = classBuilder;
         member = member.next as MemberBuilder?;
@@ -1980,7 +1980,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
               ]);
         }
       }
-      setParent(name, member as MemberBuilder);
+      setParent(member as MemberBuilder);
     }
 
     members.forEach(setParentAndCheckConflicts);
@@ -2173,7 +2173,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
     constructorReferences.clear();
     Map<String, TypeVariableBuilder>? typeVariablesByName =
         checkTypeVariables(typeVariables, extensionBuilder);
-    void setParent(String name, MemberBuilder? member) {
+    void setParent(MemberBuilder? member) {
       while (member != null) {
         member.parent = extensionBuilder;
         member = member.next as MemberBuilder?;
@@ -2194,7 +2194,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
               ]);
         }
       }
-      setParent(name, member as MemberBuilder);
+      setParent(member as MemberBuilder);
     }
 
     members.forEach(setParentAndCheckConflicts);
@@ -2265,7 +2265,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
     constructorReferences.clear();
     Map<String, TypeVariableBuilder>? typeVariablesByName =
         checkTypeVariables(typeVariables, inlineClassBuilder);
-    void setParent(String name, MemberBuilder? member) {
+    void setParent(MemberBuilder? member) {
       while (member != null) {
         member.parent = inlineClassBuilder;
         member = member.next as MemberBuilder?;
@@ -2286,7 +2286,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
               ]);
         }
       }
-      setParent(name, member as MemberBuilder);
+      setParent(member as MemberBuilder);
     }
 
     members.forEach(setParentAndCheckConflicts);
@@ -3165,7 +3165,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
     Map<String, TypeVariableBuilder>? typeVariablesByName =
         checkTypeVariables(typeVariables, enumBuilder);
 
-    void setParent(String name, MemberBuilder? member) {
+    void setParent(MemberBuilder? member) {
       while (member != null) {
         member.parent = enumBuilder;
         member = member.next as MemberBuilder?;
@@ -3186,7 +3186,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
               ]);
         }
       }
-      setParent(name, member as MemberBuilder);
+      setParent(member as MemberBuilder);
     }
 
     members.forEach(setParentAndCheckConflicts);

pkg/front_end/lib/src/fasta/source/source_procedure_builder.dart

@@ -390,8 +390,7 @@ class SourceProcedureBuilder extends SourceFunctionBuilderImpl
     }
 
     VariableDeclaration copyParameter(
-        VariableDeclaration parameter, DartType type,
-        {required bool isOptional}) {
+        VariableDeclaration parameter, DartType type) {
       VariableDeclaration newParameter = new VariableDeclaration(parameter.name,
           type: type,
           isFinal: parameter.isFinal,
@@ -403,8 +402,7 @@ class SourceProcedureBuilder extends SourceFunctionBuilderImpl
 
     VariableDeclaration extensionThis = copyParameter(
         function.positionalParameters.first,
-        substitution.substituteType(function.positionalParameters.first.type),
-        isOptional: false);
+        substitution.substituteType(function.positionalParameters.first.type));
 
     DartType closureReturnType =
         substitution.substituteType(function.returnType);
@@ -421,8 +419,7 @@ class SourceProcedureBuilder extends SourceFunctionBuilderImpl
             .add(new VariableGet(extensionThis)..fileOffset = fileOffset);
       } else {
         DartType type = substitution.substituteType(parameter.type);
-        VariableDeclaration newParameter = copyParameter(parameter, type,
-            isOptional: position >= function.requiredParameterCount);
+        VariableDeclaration newParameter = copyParameter(parameter, type);
         closurePositionalParameters.add(newParameter);
         closurePositionalArguments
             .add(new VariableGet(newParameter)..fileOffset = fileOffset);
@@ -432,8 +429,7 @@ class SourceProcedureBuilder extends SourceFunctionBuilderImpl
     List<NamedExpression> closureNamedArguments = [];
     for (VariableDeclaration parameter in function.namedParameters) {
       DartType type = substitution.substituteType(parameter.type);
-      VariableDeclaration newParameter =
-          copyParameter(parameter, type, isOptional: true);
+      VariableDeclaration newParameter = copyParameter(parameter, type);
       closureNamedParameters.add(newParameter);
       closureNamedArguments.add(new NamedExpression(parameter.name!,
           new VariableGet(newParameter)..fileOffset = fileOffset));

pkg/front_end/lib/src/fasta/type_inference/inference_visitor_base.dart

@@ -2133,8 +2133,6 @@ abstract class InferenceVisitorBase implements InferenceVisitor {
             inferredTypes;
       }
     }
-    List<DartType> positionalArgumentTypes = [];
-    List<NamedType> namedArgumentTypes = [];
     if (!identical(calleeType, unknownFunction)) {
       LocatedMessage? argMessage = helper.checkArgumentsForType(
           calleeType, arguments, offset,
@@ -2164,13 +2162,10 @@ abstract class InferenceVisitorBase implements InferenceVisitor {
           bool coerceExpression;
           if (i < numPositionalArgs) {
             expression = arguments.positional[positionalShift + i];
-            positionalArgumentTypes.add(actualType);
             coerceExpression = !arguments.positionalAreSuperParameters;
           } else {
             namedExpression = arguments.named[i - numPositionalArgs];
             expression = namedExpression.value;
-            namedArgumentTypes
-                .add(new NamedType(namedExpression.name, actualType));
             coerceExpression = !(arguments.namedSuperParameterNames
                     ?.contains(namedExpression.name) ??
                 false);