mirror of
https://github.com/dart-lang/sdk
synced 2024-09-18 22:01:19 +00:00
In getLibraryLinkedSignature() access just file.
We don't need to configure the analysis context with file specific analysis options, we are not going to resolve this file. R=brianwilkerson@google.com, keertip@google.com Change-Id: Ie0efafc39a35622f12f4110097ff9e804ef87cde Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145663 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Keerti Parthasarathy <keertip@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
parent
806350ab44
commit
087d3166a2
|
@ -126,7 +126,7 @@ class FileResolver {
|
|||
|
||||
return _withLibraryContextReset(() {
|
||||
return logger.run('Get errors for $path', () {
|
||||
var fileContext = getFileContext(path, withLog: true);
|
||||
var fileContext = getFileContext(path);
|
||||
var file = fileContext.file;
|
||||
|
||||
var errorsSignatureBuilder = ApiSignature();
|
||||
|
@ -170,34 +170,18 @@ class FileResolver {
|
|||
});
|
||||
}
|
||||
|
||||
FileContext getFileContext(String path, {bool withLog = false}) {
|
||||
FileContext perform() {
|
||||
FileContext getFileContext(String path) {
|
||||
var analysisOptions = _getAnalysisOptions(path);
|
||||
|
||||
_createContext(path, analysisOptions);
|
||||
|
||||
var file = fsState.getFileForPath(path);
|
||||
return FileContext(analysisOptions, file);
|
||||
}
|
||||
|
||||
if (withLog) {
|
||||
return logger.run('Get file $path', () {
|
||||
try {
|
||||
return getFileContext(path);
|
||||
} finally {
|
||||
fsState.logStatistics();
|
||||
}
|
||||
});
|
||||
} else {
|
||||
return perform();
|
||||
}
|
||||
}
|
||||
|
||||
String getLibraryLinkedSignature(String path) {
|
||||
_throwIfNotAbsoluteNormalizedPath(path);
|
||||
|
||||
var fileContext = getFileContext(path);
|
||||
var file = fileContext.file;
|
||||
var file = fsState.getFileForPath(path);
|
||||
return file.libraryCycle.signatureStr;
|
||||
}
|
||||
|
||||
|
@ -206,7 +190,7 @@ class FileResolver {
|
|||
|
||||
return _withLibraryContextReset(() {
|
||||
return logger.run('Resolve $path', () {
|
||||
var fileContext = getFileContext(path, withLog: true);
|
||||
var fileContext = getFileContext(path);
|
||||
var file = fileContext.file;
|
||||
|
||||
libraryContext.load2(file);
|
||||
|
@ -223,8 +207,7 @@ class FileResolver {
|
|||
fileContext.analysisOptions,
|
||||
contextObjects.declaredVariables,
|
||||
sourceFactory,
|
||||
(_) => true,
|
||||
// _isLibraryUri
|
||||
(_) => true, // _isLibraryUri
|
||||
contextObjects.analysisContext,
|
||||
libraryContext.elementFactory,
|
||||
libraryContext.inheritanceManager,
|
||||
|
|
Loading…
Reference in a new issue