languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 03:36:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

In getLibraryLinkedSignature() access just file.

Browse source 
We don't need to configure the analysis context with file specific
analysis options, we are not going to resolve this file.

R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ie0efafc39a35622f12f4110097ff9e804ef87cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2020-04-30 23:45:46 +00:00 committed by commit-bot@chromium.org
parent 806350ab44
commit 087d3166a2
1 changed files with 9 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
pkg/analyzer/lib/src/dart/micro/resolve_file.dart
View file

@ -126,7 +126,7 @@ class FileResolver {
return _withLibraryContextReset(() {
return logger.run('Get errors for $path', () {
var fileContext = getFileContext(path, withLog: true);
var fileContext = getFileContext(path);
var file = fileContext.file;
var errorsSignatureBuilder = ApiSignature();
@ -170,34 +170,18 @@ class FileResolver {
});
}
FileContext getFileContext(String path, {bool withLog = false}) {
FileContext perform() {
var analysisOptions = _getAnalysisOptions(path);
FileContext getFileContext(String path) {
var analysisOptions = _getAnalysisOptions(path);
_createContext(path, analysisOptions);
_createContext(path, analysisOptions);
var file = fsState.getFileForPath(path);
return FileContext(analysisOptions, file);
}
if (withLog) {
return logger.run('Get file $path', () {
try {
return getFileContext(path);
} finally {
fsState.logStatistics();
}
});
} else {
return perform();
}
var file = fsState.getFileForPath(path);
return FileContext(analysisOptions, file);
}
String getLibraryLinkedSignature(String path) {
_throwIfNotAbsoluteNormalizedPath(path);
var fileContext = getFileContext(path);
var file = fileContext.file;
var file = fsState.getFileForPath(path);
return file.libraryCycle.signatureStr;
}
@ -206,7 +190,7 @@ class FileResolver {
return _withLibraryContextReset(() {
return logger.run('Resolve $path', () {
var fileContext = getFileContext(path, withLog: true);
var fileContext = getFileContext(path);
var file = fileContext.file;
libraryContext.load2(file);
@ -223,8 +207,7 @@ class FileResolver {
fileContext.analysisOptions,
contextObjects.declaredVariables,
sourceFactory,
(_) => true,
// _isLibraryUri
(_) => true, // _isLibraryUri
contextObjects.analysisContext,
libraryContext.elementFactory,
libraryContext.inheritanceManager,