From 08450dc4324d9605d25a0997b6f1dfcc9501a053 Mon Sep 17 00:00:00 2001 From: Zach Anderson Date: Thu, 31 Mar 2016 12:55:31 -0700 Subject: [PATCH] Begin work on ios secure sockets BUG= R=iposva@google.com Review URL: https://codereview.chromium.org/1839123003 . --- runtime/bin/BUILD.gn | 8 +- runtime/bin/io_impl_sources.gypi | 1 + runtime/bin/platform_macos.cc | 18 +- runtime/bin/secure_socket_ios.cc | 1310 ++++++++++++++++++++++++++++ runtime/bin/secure_socket_macos.cc | 4 +- runtime/platform/globals.h | 3 + sdk/lib/io/security_context.dart | 10 +- 7 files changed, 1341 insertions(+), 13 deletions(-) create mode 100644 runtime/bin/secure_socket_ios.cc diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn index 04d7097e1f3..20b2a8a84a0 100644 --- a/runtime/bin/BUILD.gn +++ b/runtime/bin/BUILD.gn @@ -280,7 +280,13 @@ source_set("embedded_dart_io") { } set_sources_assignment_filter(custom_sources_filter) - defines = [ "DART_IO_SECURE_SOCKET_DISABLED" ] + if (is_mac || is_ios) { + libs = [ + "Security.framework", + ] + } else { + defines = [ "DART_IO_SECURE_SOCKET_DISABLED" ] + } sources = io_impl_sources_gypi.sources + builtin_impl_sources_gypi.sources sources += [ diff --git a/runtime/bin/io_impl_sources.gypi b/runtime/bin/io_impl_sources.gypi index af5c7129ca8..ccb050cc631 100644 --- a/runtime/bin/io_impl_sources.gypi +++ b/runtime/bin/io_impl_sources.gypi @@ -51,6 +51,7 @@ 'secure_socket.h', 'secure_socket_boringssl.cc', 'secure_socket_boringssl.h', + 'secure_socket_ios.cc', 'secure_socket_macos.cc', 'secure_socket_macos.h', 'secure_socket_unsupported.cc', diff --git a/runtime/bin/platform_macos.cc b/runtime/bin/platform_macos.cc index 2641ac1b9a9..24c83fdb66a 100644 --- a/runtime/bin/platform_macos.cc +++ b/runtime/bin/platform_macos.cc @@ -76,14 +76,16 @@ bool Platform::LocalHostname(char *buffer, intptr_t buffer_length) { char** Platform::Environment(intptr_t* count) { #if TARGET_OS_IOS - // TODO(iposva): On Mac (desktop), _NSGetEnviron() is used to access the - // environ from shared libraries or bundles. This is present in crt_externs.h - // which is unavailable on iOS. On iOS, everything is statically linked for - // now. So arguably, accessing the environ directly with a "extern char - // **environ" will work. But this approach is brittle as the target with this - // CU could be a dynamic framework (introduced in iOS 8). A more elegant - // approach needs to be devised. - return NULL; + // TODO(zra,chinmaygarde): On iOS, environment variables are seldom used. Wire + // this up if someone needs it. In the meantime, we return an empty array. + char** result; + result = reinterpret_cast(Dart_ScopeAllocate(1 * sizeof(*result))); + if (result == NULL) { + return NULL; + } + result[0] = NULL; + *count = 0; + return result; #else // Using environ directly is only safe as long as we do not // provide access to modifying environment variables. diff --git a/runtime/bin/secure_socket_ios.cc b/runtime/bin/secure_socket_ios.cc new file mode 100644 index 00000000000..c52ffb73b5a --- /dev/null +++ b/runtime/bin/secure_socket_ios.cc @@ -0,0 +1,1310 @@ +// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file +// for details. All rights reserved. Use of this source code is governed by a +// BSD-style license that can be found in the LICENSE file. + +#if !defined(DART_IO_DISABLED) && !defined(DART_IO_SECURE_SOCKET_DISABLED) + +#include "platform/globals.h" +#if TARGET_OS_IOS + +#include "bin/secure_socket.h" +#include "bin/secure_socket_macos.h" + +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include "bin/builtin.h" +#include "bin/dartutils.h" +#include "bin/lockers.h" +#include "bin/log.h" +#include "bin/socket.h" +#include "bin/thread.h" +#include "bin/utils.h" + +#include "platform/text_buffer.h" +#include "platform/utils.h" + +#include "include/dart_api.h" + +// Return the error from the containing function if handle is an error handle. +#define RETURN_IF_ERROR(handle) \ + { \ + Dart_Handle __handle = handle; \ + if (Dart_IsError((__handle))) { \ + return __handle; \ + } \ + } + +// We need to access this private API function to create a SecIdentityRef +// without writing a custom keychain to the filesystem. This is the approach +// taken in WebKit: +// https://webkit.googlesource.com/WebKit/+/master/Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp +extern "C" { +SecIdentityRef SecIdentityCreate(CFAllocatorRef allocator, + SecCertificateRef certificate, + SecKeyRef private_key); +} + +namespace dart { +namespace bin { + +static const int kSSLFilterNativeFieldIndex = 0; +static const int kSecurityContextNativeFieldIndex = 0; +static const int kX509NativeFieldIndex = 0; + +static const bool SSL_LOG_STATUS = false; +static const bool SSL_LOG_DATA = false; +static const int SSL_ERROR_MESSAGE_BUFFER_SIZE = 1000; + +// SSLCertContext wraps the certificates needed for a SecureTransport +// connection. Fields are protected by the mutex_ field, and may only be set +// once. This is to allow access by both the Dart thread and the IOService +// thread. Setters return false if the field was already set. +class SSLCertContext { + public: + SSLCertContext() : + mutex_(new Mutex()), + trust_builtin_(false) {} + + ~SSLCertContext() { + delete mutex_; + } + + bool trust_builtin() { + MutexLocker m(mutex_); + return trust_builtin_; + } + void set_trust_builtin(bool trust_builtin) { + MutexLocker m(mutex_); + trust_builtin_ = trust_builtin; + } + + private: + // The context is accessed both by Dart code and the IOService. This mutex + // protects all fields. + Mutex* mutex_; + bool trust_builtin_; + + DISALLOW_COPY_AND_ASSIGN(SSLCertContext); +}; + +// Handle an error reported from the SecureTransport library. +static void ThrowIOException(OSStatus status, + const char* exception_type, + const char* message) { + TextBuffer status_message(SSL_ERROR_MESSAGE_BUFFER_SIZE); + status_message.Printf("OSStatus = %ld: https://www.osstatus.com", + static_cast(status)); + OSError os_error_struct(status, status_message.buf(), OSError::kBoringSSL); + Dart_Handle os_error = DartUtils::NewDartOSError(&os_error_struct); + Dart_Handle exception = + DartUtils::NewDartIOException(exception_type, message, os_error); + ASSERT(!Dart_IsError(exception)); + Dart_ThrowException(exception); + UNREACHABLE(); +} + + +static void CheckStatus(OSStatus status, + const char* type, + const char* message) { + if (status == noErr) { + return; + } + ThrowIOException(status, type, message); +} + + +static SSLFilter* GetFilter(Dart_NativeArguments args) { + SSLFilter* filter; + Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0)); + ASSERT(Dart_IsInstance(dart_this)); + ThrowIfError(Dart_GetNativeInstanceField( + dart_this, + kSSLFilterNativeFieldIndex, + reinterpret_cast(&filter))); + return filter; +} + + +static void DeleteFilter(void* isolate_data, + Dart_WeakPersistentHandle handle, + void* context_pointer) { + SSLFilter* filter = reinterpret_cast(context_pointer); + delete filter; +} + + +static Dart_Handle SetFilter(Dart_NativeArguments args, SSLFilter* filter) { + ASSERT(filter != NULL); + const int approximate_size_of_filter = 1500; + Dart_Handle dart_this = Dart_GetNativeArgument(args, 0); + RETURN_IF_ERROR(dart_this); + ASSERT(Dart_IsInstance(dart_this)); + Dart_Handle err = Dart_SetNativeInstanceField( + dart_this, + kSSLFilterNativeFieldIndex, + reinterpret_cast(filter)); + RETURN_IF_ERROR(err); + Dart_NewWeakPersistentHandle(dart_this, + reinterpret_cast(filter), + approximate_size_of_filter, + DeleteFilter); + return Dart_Null(); +} + + +static SSLCertContext* GetSecurityContext(Dart_NativeArguments args) { + SSLCertContext* context; + Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0)); + ASSERT(Dart_IsInstance(dart_this)); + ThrowIfError(Dart_GetNativeInstanceField( + dart_this, + kSecurityContextNativeFieldIndex, + reinterpret_cast(&context))); + return context; +} + + +static void DeleteCertContext(void* isolate_data, + Dart_WeakPersistentHandle handle, + void* context_pointer) { + SSLCertContext* context = static_cast(context_pointer); + delete context; +} + + +static Dart_Handle SetSecurityContext(Dart_NativeArguments args, + SSLCertContext* context) { + const int approximate_size_of_context = 1500; + Dart_Handle dart_this = Dart_GetNativeArgument(args, 0); + RETURN_IF_ERROR(dart_this); + ASSERT(Dart_IsInstance(dart_this)); + Dart_Handle err = Dart_SetNativeInstanceField( + dart_this, + kSecurityContextNativeFieldIndex, + reinterpret_cast(context)); + RETURN_IF_ERROR(err); + Dart_NewWeakPersistentHandle(dart_this, + context, + approximate_size_of_context, + DeleteCertContext); + return Dart_Null(); +} + + +static void ReleaseCertificate(void* isolate_data, + Dart_WeakPersistentHandle handle, + void* context_pointer) { + SecCertificateRef cert = reinterpret_cast(context_pointer); + CFRelease(cert); +} + + +static Dart_Handle WrappedX509Certificate(SecCertificateRef certificate) { + const intptr_t approximate_size_of_certificate = 1500; + if (certificate == NULL) { + return Dart_Null(); + } + Dart_Handle x509_type = + DartUtils::GetDartType(DartUtils::kIOLibURL, "X509Certificate"); + if (Dart_IsError(x509_type)) { + return x509_type; + } + Dart_Handle arguments[] = { NULL }; + + Dart_Handle result = + Dart_New(x509_type, DartUtils::NewString("_"), 0, arguments); + if (Dart_IsError(result)) { + return result; + } + ASSERT(Dart_IsInstance(result)); + + // CFRetain in case the returned Dart object outlives the SecurityContext. + // CFRelease is in the Dart object's finalizer + CFRetain(certificate); + Dart_NewWeakPersistentHandle(result, + reinterpret_cast(certificate), + approximate_size_of_certificate, + ReleaseCertificate); + + Dart_Handle status = Dart_SetNativeInstanceField( + result, + kX509NativeFieldIndex, + reinterpret_cast(certificate)); + if (Dart_IsError(status)) { + return status; + } + return result; +} + + +void FUNCTION_NAME(SecureSocket_Init)(Dart_NativeArguments args) { + Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0)); + SSLFilter* filter = new SSLFilter(); // Deleted in DeleteFilter finalizer. + Dart_Handle err = SetFilter(args, filter); + if (Dart_IsError(err)) { + delete filter; + Dart_PropagateError(err); + } + err = filter->Init(dart_this); + if (Dart_IsError(err)) { + // The finalizer was set up by SetFilter. It will delete `filter` if there + // is an error. + filter->Destroy(); + Dart_PropagateError(err); + } +} + + +void FUNCTION_NAME(SecureSocket_Connect)(Dart_NativeArguments args) { + Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0)); + Dart_Handle host_name_object = ThrowIfError(Dart_GetNativeArgument(args, 1)); + Dart_Handle context_object = ThrowIfError(Dart_GetNativeArgument(args, 2)); + bool is_server = DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 3)); + bool request_client_certificate = + DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 4)); + bool require_client_certificate = + DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 5)); + + const char* host_name = NULL; + // TODO(whesse): Is truncating a Dart string containing \0 what we want? + ThrowIfError(Dart_StringToCString(host_name_object, &host_name)); + + SSLCertContext* context = NULL; + if (!Dart_IsNull(context_object)) { + ThrowIfError(Dart_GetNativeInstanceField( + context_object, + kSecurityContextNativeFieldIndex, + reinterpret_cast(&context))); + } + + GetFilter(args)->Connect(dart_this, + host_name, + context, + is_server, + request_client_certificate, + require_client_certificate); +} + + +void FUNCTION_NAME(SecureSocket_Destroy)(Dart_NativeArguments args) { + SSLFilter* filter = GetFilter(args); + // The SSLFilter is deleted in the finalizer for the Dart object created by + // SetFilter. There is no need to NULL-out the native field for the SSLFilter + // here because the SSLFilter won't be deleted until the finalizer for the + // Dart object runs while the Dart object is being GCd. This approach avoids a + // leak if Destroy isn't called, and avoids a NULL-dereference if Destroy is + // called more than once. + filter->Destroy(); +} + + +void FUNCTION_NAME(SecureSocket_Handshake)(Dart_NativeArguments args) { + OSStatus status = GetFilter(args)->CheckHandshake(); + CheckStatus(status, "HandshakeException", "Handshake error"); +} + + +void FUNCTION_NAME(SecureSocket_GetSelectedProtocol)( + Dart_NativeArguments args) { + Dart_SetReturnValue(args, Dart_Null()); +} + + +void FUNCTION_NAME(SecureSocket_Renegotiate)(Dart_NativeArguments args) { + bool use_session_cache = + DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 1)); + bool request_client_certificate = + DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 2)); + bool require_client_certificate = + DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 3)); + GetFilter(args)->Renegotiate(use_session_cache, + request_client_certificate, + require_client_certificate); +} + + +void FUNCTION_NAME(SecureSocket_RegisterHandshakeCompleteCallback)( + Dart_NativeArguments args) { + Dart_Handle handshake_complete = + ThrowIfError(Dart_GetNativeArgument(args, 1)); + if (!Dart_IsClosure(handshake_complete)) { + Dart_ThrowException(DartUtils::NewDartArgumentError( + "Illegal argument to RegisterHandshakeCompleteCallback")); + } + GetFilter(args)->RegisterHandshakeCompleteCallback(handshake_complete); +} + + +void FUNCTION_NAME(SecureSocket_RegisterBadCertificateCallback)( + Dart_NativeArguments args) { + Dart_Handle callback = + ThrowIfError(Dart_GetNativeArgument(args, 1)); + if (!Dart_IsClosure(callback) && !Dart_IsNull(callback)) { + Dart_ThrowException(DartUtils::NewDartArgumentError( + "Illegal argument to RegisterBadCertificateCallback")); + } + GetFilter(args)->RegisterBadCertificateCallback(callback); +} + + +void FUNCTION_NAME(SecureSocket_PeerCertificate)(Dart_NativeArguments args) { + Dart_SetReturnValue(args, GetFilter(args)->PeerCertificate()); +} + + +void FUNCTION_NAME(SecureSocket_FilterPointer)(Dart_NativeArguments args) { + intptr_t filter_pointer = reinterpret_cast(GetFilter(args)); + Dart_SetReturnValue(args, Dart_NewInteger(filter_pointer)); +} + + +void FUNCTION_NAME(SecurityContext_Allocate)(Dart_NativeArguments args) { + SSLCertContext* cert_context = new SSLCertContext(); + // cert_context deleted in DeleteCertContext finalizer. + Dart_Handle err = SetSecurityContext(args, cert_context); + if (Dart_IsError(err)) { + delete cert_context; + Dart_PropagateError(err); + } +} + + +void FUNCTION_NAME(SecurityContext_UsePrivateKeyBytes)( + Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "SecurityContext.usePrivateKeyBytes is not yet implemented.")); +} + + +void FUNCTION_NAME(SecurityContext_SetTrustedCertificatesBytes)( + Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "SecurityContext.setTrustedCertificatesBytes is not yet implemented.")); +} + + +void FUNCTION_NAME(SecurityContext_AlpnSupported)(Dart_NativeArguments args) { + Dart_SetReturnValue(args, Dart_NewBoolean(false)); +} + + +void FUNCTION_NAME(SecurityContext_TrustBuiltinRoots)( + Dart_NativeArguments args) { + SSLCertContext* context = GetSecurityContext(args); + context->set_trust_builtin(true); +} + + +void FUNCTION_NAME(SecurityContext_UseCertificateChainBytes)( + Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "SecurityContext.useCertificateChainBytes is not yet implemented.")); +} + + +void FUNCTION_NAME(SecurityContext_SetClientAuthoritiesBytes)( + Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "SecurityContext.setClientAuthoritiesBytes is not yet implemented.")); +} + + +void FUNCTION_NAME(SecurityContext_SetAlpnProtocols)( + Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "ALPN is not supported on this platform")); +} + + +void FUNCTION_NAME(X509_Subject)(Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "X509Certificate.subject is not yet implemented.")); +} + + +void FUNCTION_NAME(X509_Issuer)(Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "X509Certificate.issuer is not supported on this platform.")); +} + + +void FUNCTION_NAME(X509_StartValidity)(Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "X509Certificate.startValidity is not supported on this platform.")); +} + + +void FUNCTION_NAME(X509_EndValidity)(Dart_NativeArguments args) { + Dart_ThrowException(DartUtils::NewDartUnsupportedError( + "X509Certificate.endValidity is not supported on this platform.")); +} + + +// Pushes data through the SSL filter, reading and writing from circular +// buffers shared with Dart. Called from the IOService thread. +// +// The Dart _SecureFilterImpl class contains 4 ExternalByteArrays used to +// pass encrypted and plaintext data to and from the C++ SSLFilter object. +// +// ProcessFilter is called with a CObject array containing the pointer to +// the SSLFilter, encoded as an int, and the start and end positions of the +// valid data in the four circular buffers. The function only reads from +// the valid data area of the input buffers, and only writes to the free +// area of the output buffers. The function returns the new start and end +// positions in the buffers, but it only updates start for input buffers, and +// end for output buffers. Therefore, the Dart thread can simultaneously +// write to the free space and end pointer of input buffers, and read from +// the data space of output buffers, and modify the start pointer. +// +// When ProcessFilter returns, the Dart thread is responsible for combining +// the updated pointers from Dart and C++, to make the new valid state of +// the circular buffer. +CObject* SSLFilter::ProcessFilterRequest(const CObjectArray& request) { + CObjectIntptr filter_object(request[0]); + SSLFilter* filter = reinterpret_cast(filter_object.Value()); + bool in_handshake = CObjectBool(request[1]).Value(); + intptr_t starts[SSLFilter::kNumBuffers]; + intptr_t ends[SSLFilter::kNumBuffers]; + for (intptr_t i = 0; i < SSLFilter::kNumBuffers; ++i) { + starts[i] = CObjectInt32(request[2 * i + 2]).Value(); + ends[i] = CObjectInt32(request[2 * i + 3]).Value(); + } + + OSStatus status = filter->ProcessAllBuffers(starts, ends, in_handshake); + if (status == noErr) { + CObjectArray* result = new CObjectArray( + CObject::NewArray(SSLFilter::kNumBuffers * 2)); + for (intptr_t i = 0; i < SSLFilter::kNumBuffers; ++i) { + result->SetAt(2 * i, new CObjectInt32(CObject::NewInt32(starts[i]))); + result->SetAt(2 * i + 1, new CObjectInt32(CObject::NewInt32(ends[i]))); + } + return result; + } else { + TextBuffer status_message(SSL_ERROR_MESSAGE_BUFFER_SIZE); + status_message.Printf("OSStatus = %ld: https://www.osstatus.com", + static_cast(status)); + CObjectArray* result = new CObjectArray(CObject::NewArray(2)); + result->SetAt(0, new CObjectInt32(CObject::NewInt32(status))); + result->SetAt(1, new CObjectString(CObject::NewString( + status_message.buf()))); + return result; + } +} + + +// Usually buffer_starts_ and buffer_ends_ are populated by ProcessAllBuffers, +// called from ProcessFilterRequest, called from the IOService thread. +// However, the first call to SSLHandshake comes from the Dart thread, and so +// doesn't go through there. This results in calls to SSLReadCallback and +// SSLWriteCallback in which buffer_starts_ and buffer_ends_ haven't been set +// up. In that case, since we're coming from Dart anyway, we can access the +// fieds directly from the Dart objects. +intptr_t SSLFilter::GetBufferStart(intptr_t idx) const { + if (buffer_starts_[idx] != NULL) { + return *buffer_starts_[idx]; + } + Dart_Handle buffer_handle = + ThrowIfError(Dart_HandleFromPersistent(dart_buffer_objects_[idx])); + Dart_Handle start_handle = + ThrowIfError(Dart_GetField(buffer_handle, DartUtils::NewString("start"))); + int64_t start = DartUtils::GetIntegerValue(start_handle); + return static_cast(start); +} + + +intptr_t SSLFilter::GetBufferEnd(intptr_t idx) const { + if (buffer_ends_[idx] != NULL) { + return *buffer_ends_[idx]; + } + Dart_Handle buffer_handle = + ThrowIfError(Dart_HandleFromPersistent(dart_buffer_objects_[idx])); + Dart_Handle end_handle = + ThrowIfError(Dart_GetField(buffer_handle, DartUtils::NewString("end"))); + int64_t end = DartUtils::GetIntegerValue(end_handle); + return static_cast(end); +} + + +void SSLFilter::SetBufferStart(intptr_t idx, intptr_t value) { + if (buffer_starts_[idx] != NULL) { + *buffer_starts_[idx] = value; + return; + } + Dart_Handle buffer_handle = + ThrowIfError(Dart_HandleFromPersistent(dart_buffer_objects_[idx])); + ThrowIfError(DartUtils::SetIntegerField( + buffer_handle, "start", static_cast(value))); +} + + +void SSLFilter::SetBufferEnd(intptr_t idx, intptr_t value) { + if (buffer_ends_[idx] != NULL) { + *buffer_ends_[idx] = value; + return; + } + Dart_Handle buffer_handle = + ThrowIfError(Dart_HandleFromPersistent(dart_buffer_objects_[idx])); + ThrowIfError(DartUtils::SetIntegerField( + buffer_handle, "end", static_cast(value))); +} + + +OSStatus SSLFilter::ProcessAllBuffers(intptr_t starts[kNumBuffers], + intptr_t ends[kNumBuffers], + bool in_handshake) { + for (intptr_t i = 0; i < kNumBuffers; ++i) { + buffer_starts_[i] = &starts[i]; + buffer_ends_[i] = &ends[i]; + } + + if (in_handshake) { + OSStatus status = Handshake(); + if (status != noErr) { + return status; + } + } else { + for (intptr_t i = 0; i < kNumBuffers; ++i) { + intptr_t start = starts[i]; + intptr_t end = ends[i]; + intptr_t size = + isBufferEncrypted(i) ? encrypted_buffer_size_ : buffer_size_; + if (start < 0 || end < 0 || start >= size || end >= size) { + FATAL("Out-of-bounds internal buffer access in dart:io SecureSocket"); + } + switch (i) { + case kReadPlaintext: + // Write data to the circular buffer's free space. If the buffer + // is full, neither if statement is executed and nothing happens. + if (start <= end) { + // If the free space may be split into two segments, + // then the first is [end, size), unless start == 0. + // Then, since the last free byte is at position start - 2, + // the interval is [end, size - 1). + intptr_t buffer_end = (start == 0) ? size - 1 : size; + intptr_t bytes = 0; + OSStatus status = + ProcessReadPlaintextBuffer(end, buffer_end, &bytes); + if ((status != noErr) && (status != errSSLWouldBlock)) { + return status; + } + end += bytes; + ASSERT(end <= size); + if (end == size) { + end = 0; + } + } + if (start > end + 1) { + intptr_t bytes = 0; + OSStatus status = + ProcessReadPlaintextBuffer(end, start - 1, &bytes); + if ((status != noErr) && (status != errSSLWouldBlock)) { + return status; + } + end += bytes; + ASSERT(end < start); + } + ends[i] = end; + break; + case kWritePlaintext: + // Read/Write data from circular buffer. If the buffer is empty, + // neither if statement's condition is true. + if (end < start) { + // Data may be split into two segments. In this case, + // the first is [start, size). + intptr_t bytes = 0; + OSStatus status = ProcessWritePlaintextBuffer(start, size, &bytes); + if ((status != noErr) && (status != errSSLWouldBlock)) { + return status; + } + start += bytes; + ASSERT(start <= size); + if (start == size) { + start = 0; + } + } + if (start < end) { + intptr_t bytes = 0; + OSStatus status = ProcessWritePlaintextBuffer(start, end, &bytes); + if ((status != noErr) && (status != errSSLWouldBlock)) { + return status; + } + start += bytes; + ASSERT(start <= end); + } + starts[i] = start; + break; + case kReadEncrypted: + case kWriteEncrypted: + // These buffers are advanced through SSLReadCallback and + // SSLWriteCallback, which are called from SSLRead, SSLWrite, and + // SSLHandshake. + break; + default: + UNREACHABLE(); + } + } + } + + for (intptr_t i = 0; i < kNumBuffers; ++i) { + buffer_starts_[i] = NULL; + buffer_ends_[i] = NULL; + } + return noErr; +} + + +Dart_Handle SSLFilter::Init(Dart_Handle dart_this) { + ASSERT(string_start_ == NULL); + string_start_ = Dart_NewPersistentHandle(DartUtils::NewString("start")); + ASSERT(string_start_ != NULL); + ASSERT(string_length_ == NULL); + string_length_ = Dart_NewPersistentHandle(DartUtils::NewString("length")); + ASSERT(string_length_ != NULL); + ASSERT(bad_certificate_callback_ == NULL); + bad_certificate_callback_ = Dart_NewPersistentHandle(Dart_Null()); + ASSERT(bad_certificate_callback_ != NULL); + + // Caller handles cleanup on an error. + return InitializeBuffers(dart_this); +} + + +Dart_Handle SSLFilter::InitializeBuffers(Dart_Handle dart_this) { + // Create SSLFilter buffers as ExternalUint8Array objects. + Dart_Handle buffers_string = DartUtils::NewString("buffers"); + RETURN_IF_ERROR(buffers_string); + Dart_Handle dart_buffers_object = Dart_GetField(dart_this, buffers_string); + RETURN_IF_ERROR(dart_buffers_object); + Dart_Handle secure_filter_impl_type = Dart_InstanceGetType(dart_this); + RETURN_IF_ERROR(secure_filter_impl_type); + Dart_Handle size_string = DartUtils::NewString("SIZE"); + RETURN_IF_ERROR(size_string); + Dart_Handle dart_buffer_size = Dart_GetField( + secure_filter_impl_type, size_string); + RETURN_IF_ERROR(dart_buffer_size); + + int64_t buffer_size = 0; + Dart_Handle err = Dart_IntegerToInt64(dart_buffer_size, &buffer_size); + RETURN_IF_ERROR(err); + + Dart_Handle encrypted_size_string = DartUtils::NewString("ENCRYPTED_SIZE"); + RETURN_IF_ERROR(encrypted_size_string); + + Dart_Handle dart_encrypted_buffer_size = Dart_GetField( + secure_filter_impl_type, encrypted_size_string); + RETURN_IF_ERROR(dart_encrypted_buffer_size); + + int64_t encrypted_buffer_size = 0; + err = Dart_IntegerToInt64(dart_encrypted_buffer_size, &encrypted_buffer_size); + RETURN_IF_ERROR(err); + + if (buffer_size <= 0 || buffer_size > 1 * MB) { + FATAL("Invalid buffer size in _ExternalBuffer"); + } + if (encrypted_buffer_size <= 0 || encrypted_buffer_size > 1 * MB) { + FATAL("Invalid encrypted buffer size in _ExternalBuffer"); + } + buffer_size_ = static_cast(buffer_size); + encrypted_buffer_size_ = static_cast(encrypted_buffer_size); + + Dart_Handle data_identifier = DartUtils::NewString("data"); + RETURN_IF_ERROR(data_identifier); + + for (int i = 0; i < kNumBuffers; i++) { + int size = isBufferEncrypted(i) ? encrypted_buffer_size_ : buffer_size_; + buffers_[i] = new uint8_t[size]; + ASSERT(buffers_[i] != NULL); + buffer_starts_[i] = NULL; + buffer_ends_[i] = NULL; + dart_buffer_objects_[i] = NULL; + } + + Dart_Handle result = Dart_Null(); + for (int i = 0; i < kNumBuffers; ++i) { + int size = isBufferEncrypted(i) ? encrypted_buffer_size_ : buffer_size_; + result = Dart_ListGetAt(dart_buffers_object, i); + if (Dart_IsError(result)) { + break; + } + + dart_buffer_objects_[i] = Dart_NewPersistentHandle(result); + ASSERT(dart_buffer_objects_[i] != NULL); + Dart_Handle data = + Dart_NewExternalTypedData(Dart_TypedData_kUint8, buffers_[i], size); + if (Dart_IsError(data)) { + result = data; + break; + } + result = Dart_HandleFromPersistent(dart_buffer_objects_[i]); + if (Dart_IsError(result)) { + break; + } + result = Dart_SetField(result, data_identifier, data); + if (Dart_IsError(result)) { + break; + } + } + + // Caller handles cleanup on an error. + return result; +} + + +void SSLFilter::RegisterHandshakeCompleteCallback(Dart_Handle complete) { + ASSERT(NULL == handshake_complete_); + handshake_complete_ = Dart_NewPersistentHandle(complete); + ASSERT(handshake_complete_ != NULL); +} + + +void SSLFilter::RegisterBadCertificateCallback(Dart_Handle callback) { + ASSERT(bad_certificate_callback_ != NULL); + Dart_DeletePersistentHandle(bad_certificate_callback_); + bad_certificate_callback_ = Dart_NewPersistentHandle(callback); + ASSERT(bad_certificate_callback_ != NULL); +} + + +Dart_Handle SSLFilter::PeerCertificate() { + if (peer_certs_ == NULL) { + return Dart_Null(); + } + + CFTypeRef item = CFArrayGetValueAtIndex(peer_certs_, 0); + ASSERT(CFGetTypeID(item) == SecCertificateGetTypeID()); + SecCertificateRef cert = + reinterpret_cast(const_cast(item)); + if (cert == NULL) { + return Dart_Null(); + } + + return WrappedX509Certificate(cert); +} + + +void SSLFilter::Connect(Dart_Handle dart_this, + const char* hostname, + SSLCertContext* context, + bool is_server, + bool request_client_certificate, + bool require_client_certificate) { + if (in_handshake_) { + FATAL("Connect called twice on the same _SecureFilter."); + } + + // Create the underlying context + SSLContextRef ssl_context = SSLCreateContext( + NULL, is_server ? kSSLServerSide : kSSLClientSide, kSSLStreamType); + + // Configure the context. + OSStatus status; + status = SSLSetPeerDomainName(ssl_context, hostname, strlen(hostname)); + CheckStatus(status, + "TlsException", + "Failed to set peer domain name"); + + status = SSLSetIOFuncs( + ssl_context, SSLFilter::SSLReadCallback, SSLFilter::SSLWriteCallback); + CheckStatus(status, + "TlsException", + "Failed to set IO Callbacks"); + + status = SSLSetConnection( + ssl_context, reinterpret_cast(this)); + CheckStatus(status, + "TlsException", + "Failed to set connection object"); + + // Always evaluate the certs manually so that we can cache the peer + // certificates in the context for calls to peerCertificate. + status = SSLSetSessionOption( + ssl_context, kSSLSessionOptionBreakOnServerAuth, true); + CheckStatus(status, + "TlsException", + "Failed to set BreakOnServerAuth option"); + + status = SSLSetProtocolVersionMin(ssl_context, kTLSProtocol1); + CheckStatus(status, + "TlsException", + "Failed to set minimum protocol version to kTLSProtocol1"); + + if (is_server) { + SSLAuthenticate auth = + require_client_certificate + ? kAlwaysAuthenticate + : (request_client_certificate ? kTryAuthenticate : kNeverAuthenticate); + status = SSLSetClientSideAuthenticate(ssl_context, auth); + CheckStatus(status, + "TlsException", + "Failed to set client authentication mode"); + + // If we're at least trying client authentication, then break handshake + // for client authentication. + if (auth != kNeverAuthenticate) { + status = SSLSetSessionOption( + ssl_context, kSSLSessionOptionBreakOnClientAuth, true); + CheckStatus(status, + "TlsException", + "Failed to set client authentication mode"); + } + } + + // Add the contexts to our wrapper. + cert_context_ = context; + ssl_context_ = ssl_context; + is_server_ = is_server; + + // Kick-off the handshake. Expect the handshake to need more data. + // SSLHandshake calls our SSLReadCallback and SSLWriteCallback. + status = SSLHandshake(ssl_context); + ASSERT(status != noErr); + if (status == errSSLWouldBlock) { + status = noErr; + in_handshake_ = true; + } + CheckStatus(status, + "HandshakeException", + is_server_ ? "Handshake error in server" : "Handshake error in client"); +} + + +OSStatus SSLFilter::EvaluatePeerTrust() { + OSStatus status = noErr; + + if (SSL_LOG_STATUS) { + Log::Print("Handshake evaluating trust.\n"); + } + SecTrustRef peer_trust = NULL; + status = SSLCopyPeerTrust(ssl_context_, &peer_trust); + if (status != noErr) { + if (is_server_ && (status == errSSLBadCert)) { + // A client certificate was requested, but not required, and wasn't sent. + return noErr; + } + if (SSL_LOG_STATUS) { + Log::Print("Handshake error from SSLCopyPeerTrust(): %ld.\n", + static_cast(status)); + } + return status; + } + + CFArrayRef trusted_certs = + CFArrayCreate(NULL, NULL, 0, &kCFTypeArrayCallBacks); + + status = SecTrustSetAnchorCertificates(peer_trust, trusted_certs); + if (status != noErr) { + if (SSL_LOG_STATUS) { + Log::Print("Handshake error from SecTrustSetAnchorCertificates: %ld\n", + static_cast(status)); + } + CFRelease(trusted_certs); + CFRelease(peer_trust); + return status; + } + + if (SSL_LOG_STATUS) { + Log::Print("Handshake %s built in root certs\n", + cert_context_->trust_builtin() ? "trusting" : "not trusting"); + } + + status = SecTrustSetAnchorCertificatesOnly( + peer_trust, !cert_context_->trust_builtin()); + if (status != noErr) { + CFRelease(trusted_certs); + CFRelease(peer_trust); + return status; + } + + SecTrustResultType trust_result; + status = SecTrustEvaluate(peer_trust, &trust_result); + if (status != noErr) { + CFRelease(trusted_certs); + CFRelease(peer_trust); + return status; + } + + // Grab the peer's certificate chain. + CFIndex peer_chain_length = SecTrustGetCertificateCount(peer_trust); + CFMutableArrayRef peer_certs = + CFArrayCreateMutable(NULL, peer_chain_length, &kCFTypeArrayCallBacks); + for (CFIndex i = 0; i < peer_chain_length; ++i) { + CFArrayAppendValue(peer_certs, + SecTrustGetCertificateAtIndex(peer_trust, i)); + } + peer_certs_ = peer_certs; + + CFRelease(trusted_certs); + CFRelease(peer_trust); + + if ((trust_result == kSecTrustResultProceed) || + (trust_result == kSecTrustResultUnspecified)) { + // Trusted. + return noErr; + } else { + if (SSL_LOG_STATUS) { + Log::Print("Trust eval failed: trust_restul = %d\n", trust_result); + } + bad_cert_ = true; + return errSSLBadCert; + } +} + + +OSStatus SSLFilter::Handshake() { + ASSERT(cert_context_ != NULL); + ASSERT(ssl_context_ != NULL); + // Try and push handshake along. + if (SSL_LOG_STATUS) { + Log::Print("Doing SSLHandshake\n"); + } + OSStatus status = SSLHandshake(ssl_context_); + if (SSL_LOG_STATUS) { + Log::Print("SSLHandshake returned %ld\n", static_cast(status)); + } + + if ((status == errSSLServerAuthCompleted) || + (status == errSSLClientAuthCompleted)) { + status = EvaluatePeerTrust(); + if (status == errSSLBadCert) { + // Need to invoke the bad certificate callback. + return noErr; + } else if (status != noErr) { + return status; + } + // When trust evaluation succeeds, we can call SSLHandshake again + // immediately. + status = SSLHandshake(ssl_context_); + } + + if (status == errSSLWouldBlock) { + in_handshake_ = true; + return noErr; + } + + // Handshake succeeded. + if ((in_handshake_) && (status == noErr)) { + if (SSL_LOG_STATUS) { + Log::Print("Finished with the Handshake\n"); + } + connected_ = true; + } + return status; +} + + +// Returns false if Handshake should fail, and true if Handshake should +// proceed. +Dart_Handle SSLFilter::InvokeBadCertCallback(SecCertificateRef peer_cert) { + Dart_Handle callback = bad_certificate_callback_; + if (Dart_IsNull(callback)) { + return callback; + } + Dart_Handle args[1]; + args[0] = WrappedX509Certificate(peer_cert); + if (Dart_IsError(args[0])) { + return args[0]; + } + Dart_Handle result = Dart_InvokeClosure(callback, 1, args); + if (!Dart_IsError(result) && !Dart_IsBoolean(result)) { + result = Dart_NewUnhandledExceptionError(DartUtils::NewDartIOException( + "HandshakeException", + "BadCertificateCallback returned a value that was not a boolean", + Dart_Null())); + } + return result; +} + + +OSStatus SSLFilter::CheckHandshake() { + if (bad_cert_ && in_handshake_) { + if (SSL_LOG_STATUS) { + Log::Print("Invoking bad certificate callback\n"); + } + ASSERT(peer_certs_ != NULL); + CFIndex peer_certs_len = CFArrayGetCount(peer_certs_); + ASSERT(peer_certs_len > 0); + CFTypeRef item = CFArrayGetValueAtIndex(peer_certs_, peer_certs_len - 1); + ASSERT(item != NULL); + ASSERT(CFGetTypeID(item) == SecCertificateGetTypeID()); + SecCertificateRef peer_cert = + reinterpret_cast(const_cast(item)); + Dart_Handle result = InvokeBadCertCallback(peer_cert); + ThrowIfError(result); + if (Dart_IsNull(result)) { + return errSSLBadCert; + } else { + bool good_cert = DartUtils::GetBooleanValue(result); + bad_cert_ = !good_cert; + return good_cert ? noErr : errSSLBadCert; + } + } + + if (connected_ && in_handshake_) { + if (SSL_LOG_STATUS) { + Log::Print("Invoking handshake complete callback\n"); + } + ThrowIfError(Dart_InvokeClosure( + Dart_HandleFromPersistent(handshake_complete_), 0, NULL)); + in_handshake_ = false; + } + return noErr; +} + + +void SSLFilter::Renegotiate(bool use_session_cache, + bool request_client_certificate, + bool require_client_certificate) { + // The SSL_REQUIRE_CERTIFICATE option only takes effect if the + // SSL_REQUEST_CERTIFICATE option is also set, so set it. + request_client_certificate = + request_client_certificate || require_client_certificate; + // TODO(24070, 24069): Implement setting the client certificate parameters, + // and triggering rehandshake. +} + + +SSLFilter::~SSLFilter() { + // cert_context_ deleted by finalizer. Don't delete here. + cert_context_ = NULL; + if (ssl_context_ != NULL) { + CFRelease(ssl_context_); + ssl_context_ = NULL; + } + if (peer_certs_ != NULL) { + CFRelease(peer_certs_); + peer_certs_ = NULL; + } + if (hostname_ != NULL) { + free(hostname_); + hostname_ = NULL; + } + for (int i = 0; i < kNumBuffers; ++i) { + if (buffers_[i] != NULL) { + delete[] buffers_[i]; + buffers_[i] = NULL; + } + } +} + + +void SSLFilter::Destroy() { + if (ssl_context_ != NULL) { + SSLClose(ssl_context_); + } + for (int i = 0; i < kNumBuffers; ++i) { + if (dart_buffer_objects_[i] != NULL) { + Dart_DeletePersistentHandle(dart_buffer_objects_[i]); + dart_buffer_objects_[i] = NULL; + } + } + if (string_start_ != NULL) { + Dart_DeletePersistentHandle(string_start_); + string_start_ = NULL; + } + if (string_length_ != NULL) { + Dart_DeletePersistentHandle(string_length_); + string_length_ = NULL; + } + if (handshake_complete_ != NULL) { + Dart_DeletePersistentHandle(handshake_complete_); + handshake_complete_ = NULL; + } + if (bad_certificate_callback_ != NULL) { + Dart_DeletePersistentHandle(bad_certificate_callback_); + bad_certificate_callback_ = NULL; + } +} + + +OSStatus SSLFilter::SSLReadCallback(SSLConnectionRef connection, + void* data, size_t* data_requested) { + // Copy at most `data_requested` bytes from `buffers_[kReadEncrypted]` into + // `data` + ASSERT(connection != NULL); + ASSERT(data != NULL); + ASSERT(data_requested != NULL); + + SSLFilter* filter = + const_cast(reinterpret_cast(connection)); + uint8_t* datap = reinterpret_cast(data); + uint8_t* buffer = filter->buffers_[kReadEncrypted]; + intptr_t start = filter->GetBufferStart(kReadEncrypted); + intptr_t end = filter->GetBufferEnd(kReadEncrypted); + intptr_t size = filter->encrypted_buffer_size_; + intptr_t requested = static_cast(*data_requested); + intptr_t data_read = 0; + + if (end < start) { + // Data may be split into two segments. In this case, + // the first is [start, size). + intptr_t buffer_end = (start == 0) ? size - 1 : size; + intptr_t available = buffer_end - start; + intptr_t bytes = requested < available ? requested : available; + memmove(datap, &buffer[start], bytes); + start += bytes; + datap += bytes; + data_read += bytes; + requested -= bytes; + ASSERT(start <= size); + if (start == size) { + start = 0; + } + } + if ((requested > 0) && (start < end)) { + intptr_t available = end - start; + intptr_t bytes = requested < available ? requested : available; + memmove(datap, &buffer[start], bytes); + start += bytes; + datap += bytes; + data_read += bytes; + requested -= bytes; + ASSERT(start <= end); + } + + if (SSL_LOG_DATA) { + Log::Print("SSLReadCallback: requested: %ld, read %ld bytes\n", + *data_requested, data_read); + } + + filter->SetBufferStart(kReadEncrypted, start); + bool short_read = data_read < static_cast(*data_requested); + *data_requested = data_read; + return short_read ? errSSLWouldBlock : noErr; +} + + +// Read decrypted data from the filter to the circular buffer. +OSStatus SSLFilter::ProcessReadPlaintextBuffer(intptr_t start, + intptr_t end, + intptr_t* bytes_processed) { + ASSERT(bytes_processed != NULL); + intptr_t length = end - start; + OSStatus status = noErr; + size_t bytes = 0; + if (length > 0) { + status = SSLRead( + ssl_context_, + reinterpret_cast((buffers_[kReadPlaintext] + start)), + length, + &bytes); + if (SSL_LOG_STATUS) { + Log::Print("SSLRead: status = %ld\n", static_cast(status)); + } + if ((status != noErr) && (status != errSSLWouldBlock)) { + *bytes_processed = 0; + return status; + } + } + if (SSL_LOG_DATA) { + Log::Print("ProcessReadPlaintextBuffer: requested: %ld, read %ld bytes\n", + length, bytes); + } + *bytes_processed = static_cast(bytes); + return status; +} + + +OSStatus SSLFilter::SSLWriteCallback(SSLConnectionRef connection, + const void* data, size_t* data_provided) { + // Copy at most `data_provided` bytes from data into + // `buffers_[kWriteEncrypted]`. + ASSERT(connection != NULL); + ASSERT(data != NULL); + ASSERT(data_provided != NULL); + + SSLFilter* filter = + const_cast(reinterpret_cast(connection)); + const uint8_t* datap = reinterpret_cast(data); + uint8_t* buffer = filter->buffers_[kWriteEncrypted]; + intptr_t start = filter->GetBufferStart(kWriteEncrypted); + intptr_t end = filter->GetBufferEnd(kWriteEncrypted); + intptr_t size = filter->encrypted_buffer_size_; + intptr_t provided = static_cast(*data_provided); + intptr_t data_written = 0; + + // is full, neither if statement is executed and nothing happens. + if (start <= end) { + // If the free space may be split into two segments, + // then the first is [end, size), unless start == 0. + // Then, since the last free byte is at position start - 2, + // the interval is [end, size - 1). + intptr_t buffer_end = (start == 0) ? size - 1 : size; + intptr_t available = buffer_end - end; + intptr_t bytes = provided < available ? provided : available; + memmove(&buffer[end], datap, bytes); + end += bytes; + datap += bytes; + data_written += bytes; + provided -= bytes; + ASSERT(end <= size); + if (end == size) { + end = 0; + } + } + if ((provided > 0) && (start > end + 1)) { + intptr_t available = (start - 1) - end; + intptr_t bytes = provided < available ? provided : available; + memmove(&buffer[end], datap, bytes); + end += bytes; + datap += bytes; + data_written += bytes; + provided -= bytes; + ASSERT(end < start); + } + + if (SSL_LOG_DATA) { + Log::Print("SSLWriteCallback: provided: %ld, written %ld bytes\n", + *data_provided, data_written); + } + + filter->SetBufferEnd(kWriteEncrypted, end); + *data_provided = data_written; + return (data_written == 0) ? errSSLWouldBlock : noErr; +} + + +OSStatus SSLFilter::ProcessWritePlaintextBuffer(intptr_t start, + intptr_t end, + intptr_t* bytes_processed) { + ASSERT(bytes_processed != NULL); + intptr_t length = end - start; + OSStatus status = noErr; + size_t bytes = 0; + if (length > 0) { + status = SSLWrite( + ssl_context_, + reinterpret_cast(buffers_[kWritePlaintext] + start), + length, + &bytes); + if (SSL_LOG_STATUS) { + Log::Print("SSLWrite: status = %ld\n", static_cast(status)); + } + if ((status != noErr) && (status != errSSLWouldBlock)) { + *bytes_processed = 0; + return status; + } + } + if (SSL_LOG_DATA) { + Log::Print("ProcessWritePlaintextBuffer: requested: %ld, written: %ld\n", + length, bytes); + } + *bytes_processed = static_cast(bytes); + return status; +} + +} // namespace bin +} // namespace dart + +#endif // TARGET_OS_IOS + +#endif // !defined(DART_IO_SECURE_SOCKET_DISABLED) diff --git a/runtime/bin/secure_socket_macos.cc b/runtime/bin/secure_socket_macos.cc index 5e6e320f20c..ab00cc32faf 100644 --- a/runtime/bin/secure_socket_macos.cc +++ b/runtime/bin/secure_socket_macos.cc @@ -5,7 +5,7 @@ #if !defined(DART_IO_DISABLED) && !defined(DART_IO_SECURE_SOCKET_DISABLED) #include "platform/globals.h" -#if defined(TARGET_OS_MACOS) +#if defined(TARGET_OS_MACOS) && !TARGET_OS_IOS #include "bin/secure_socket.h" #include "bin/secure_socket_macos.h" @@ -2022,7 +2022,7 @@ OSStatus SSLFilter::ProcessWritePlaintextBuffer(intptr_t start, } // namespace bin } // namespace dart -#endif // defined(TARGET_OS_MACOS) +#endif // defined(TARGET_OS_MACOS) && !TARGET_OS_IOS #endif // !defined(DART_IO_DISABLED) && // !defined(DART_IO_SECURE_SOCKET_DISABLED) diff --git a/runtime/platform/globals.h b/runtime/platform/globals.h index d1c6ef63616..82f5719e31a 100644 --- a/runtime/platform/globals.h +++ b/runtime/platform/globals.h @@ -102,6 +102,9 @@ // the value defined in TargetConditionals.h #define TARGET_OS_MACOS 1 #if TARGET_OS_IPHONE +// Test for this #define by saying '#if TARGET_OS_IOS' rather than the usual +// '#if defined(TARGET_OS_IOS)'. TARGET_OS_IOS is defined to be 0 in +// XCode >= 7.0. See Issue #24453. #define TARGET_OS_IOS 1 #endif diff --git a/sdk/lib/io/security_context.dart b/sdk/lib/io/security_context.dart index 1e169af9d6e..41464206d21 100644 --- a/sdk/lib/io/security_context.dart +++ b/sdk/lib/io/security_context.dart @@ -14,6 +14,10 @@ part of dart.io; * * Certificates and keys can be added to a SecurityContext from either PEM * or PKCS12 containers. + * + * iOS note: methods to add, remove, and inspect certificates are not yet + * implemented. That is, only the platform's built-in trusted certificates can + * be used, by way of [SecurityContext.defaultContext]. */ abstract class SecurityContext { external factory SecurityContext(); @@ -24,8 +28,10 @@ abstract class SecurityContext { * This object can also be accessed, and modified, directly. * Each isolate has a different [defaultContext] object. * The [defaultContext] object uses a list of well-known trusted - * certificate authorities as its trusted roots. This list is - * taken from Mozilla, who maintains it as part of Firefox. + * certificate authorities as its trusted roots. On Linux and Windows, this + * list is taken from Mozilla, who maintains it as part of Firefox. On, + * MacOS, iOS, and Android, this list comes from the trusted certificates + * stores built in to the platforms. */ external static SecurityContext get defaultContext;