mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 00:39:49 +00:00
Evaluate several diagnostics for fixes
Change-Id: I223aa59b3e0833ce6d3a11a223efa706e30afbc1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260063 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
parent
7578614639
commit
065b7d6d62
|
@ -24,10 +24,10 @@
|
||||||
# issue created for it.
|
# issue created for it.
|
||||||
#
|
#
|
||||||
# Stats:
|
# Stats:
|
||||||
# - 736 "needsEvaluation"
|
# - 726 "needsEvaluation"
|
||||||
# - 48 "needsFix"
|
# - 58 "needsFix"
|
||||||
# - 285 "hasFix"
|
# - 287 "hasFix"
|
||||||
# - 47 "noFix"
|
# - 48 "noFix"
|
||||||
|
|
||||||
AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
|
AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
|
||||||
status: noFix
|
status: noFix
|
||||||
|
@ -1543,31 +1543,63 @@ HintCode.UNUSED_RESULT_WITH_MESSAGE:
|
||||||
HintCode.UNUSED_SHOWN_NAME:
|
HintCode.UNUSED_SHOWN_NAME:
|
||||||
status: hasFix
|
status: hasFix
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_FIELD:
|
LanguageCode.IMPLICIT_DYNAMIC_FIELD:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_FUNCTION:
|
LanguageCode.IMPLICIT_DYNAMIC_FUNCTION:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_INVOKE:
|
LanguageCode.IMPLICIT_DYNAMIC_INVOKE:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_LIST_LITERAL:
|
LanguageCode.IMPLICIT_DYNAMIC_LIST_LITERAL:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_MAP_LITERAL:
|
LanguageCode.IMPLICIT_DYNAMIC_MAP_LITERAL:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_METHOD:
|
LanguageCode.IMPLICIT_DYNAMIC_METHOD:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_PARAMETER:
|
LanguageCode.IMPLICIT_DYNAMIC_PARAMETER:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_RETURN:
|
LanguageCode.IMPLICIT_DYNAMIC_RETURN:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_TYPE:
|
LanguageCode.IMPLICIT_DYNAMIC_TYPE:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LanguageCode.IMPLICIT_DYNAMIC_VARIABLE:
|
LanguageCode.IMPLICIT_DYNAMIC_VARIABLE:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
The correction says to add an explicit type or remove implicit-dynamic from
|
||||||
|
analysis options. We can add a fix to add an explicit `dynamic`.
|
||||||
LintCode.always_declare_return_types:
|
LintCode.always_declare_return_types:
|
||||||
status: hasFix
|
status: hasFix
|
||||||
LintCode.always_put_control_body_on_new_line:
|
LintCode.always_put_control_body_on_new_line:
|
||||||
status: hasFix
|
status: hasFix
|
||||||
LintCode.always_put_required_named_parameters_first:
|
LintCode.always_put_required_named_parameters_first:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
Can fix by moving required named parameters before non-required ones.
|
||||||
LintCode.always_require_non_null_named_parameters:
|
LintCode.always_require_non_null_named_parameters:
|
||||||
status: hasFix
|
status: hasFix
|
||||||
LintCode.always_specify_types:
|
LintCode.always_specify_types:
|
||||||
|
@ -1579,9 +1611,15 @@ LintCode.annotate_overrides:
|
||||||
LintCode.avoid_annotating_with_dynamic:
|
LintCode.avoid_annotating_with_dynamic:
|
||||||
status: hasFix
|
status: hasFix
|
||||||
LintCode.avoid_as:
|
LintCode.avoid_as:
|
||||||
status: needsEvaluation
|
status: noFix
|
||||||
|
notes: |-
|
||||||
|
We could try to account for special situations, but this cannot be fixed
|
||||||
|
universally, and the lint rule is deprecated.
|
||||||
LintCode.avoid_bool_literals_in_conditional_expressions:
|
LintCode.avoid_bool_literals_in_conditional_expressions:
|
||||||
status: needsEvaluation
|
status: needsFix
|
||||||
|
notes: |-
|
||||||
|
Each expression like `condition ? true : boolExpression` can be universally
|
||||||
|
fixed to not contain a bool literal.
|
||||||
LintCode.avoid_catches_without_on_clauses:
|
LintCode.avoid_catches_without_on_clauses:
|
||||||
status: needsEvaluation
|
status: needsEvaluation
|
||||||
LintCode.avoid_catching_errors:
|
LintCode.avoid_catching_errors:
|
||||||
|
|
Loading…
Reference in a new issue