Avoid non-web integer literal in corelib_2/int_round_test

Also fix precedence bug.

Change-Id: I4b4746e0adfd0ff354d85519665ae23742f8703a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107838
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2019-07-03 16:20:07 +00:00 committed by commit-bot@chromium.org
parent 480337106e
commit 052874e93e
2 changed files with 14 additions and 14 deletions

View file

@ -38,7 +38,6 @@ int_parse_radix_int64_test/01: CompileTimeError, OK # Error if web int literal c
int_parse_radix_int64_test/02: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_parse_radix_int64_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_parse_radix_test/01: RuntimeError
int_round_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_round_to_double_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_to_int_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_truncate_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
@ -323,7 +322,6 @@ int_parse_radix_int64_test/02: CompileTimeError, OK # Error if web int literal c
int_parse_radix_int64_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_parse_radix_test/01: RuntimeError # Issue 29921
int_parse_with_limited_ints_test: Skip # Requires fixed-size int64 support.
int_round_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_round_to_double_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_to_int_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
int_truncate_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351

View file

@ -5,27 +5,29 @@
import 'package:expect/expect.dart';
main() {
const int big = 0x123456789AB0000 + 0xCDEF; // truncating arithmetic on web.
Expect.equals(0, 0.round());
Expect.equals(1, 1.round());
Expect.equals(0x1234, 0x1234.round());
Expect.equals(0x12345678, 0x12345678.round());
Expect.equals(0x123456789AB, 0x123456789AB.round());
Expect.equals(0x123456789ABCDEF, 0x123456789ABCDEF.round());
Expect.equals(-1, -1.round());
Expect.equals(-0x1234, -0x1234.round());
Expect.equals(-0x12345678, -0x12345678.round());
Expect.equals(-0x123456789AB, -0x123456789AB.round());
Expect.equals(-0x123456789ABCDEF, -0x123456789ABCDEF.round());
Expect.equals(big, big.round());
Expect.equals(-1, (-1).round());
Expect.equals(-0x1234, (-0x1234).round());
Expect.equals(-0x12345678, (-0x12345678).round());
Expect.equals(-0x123456789AB, (-0x123456789AB).round());
Expect.equals(-big, (-big).round());
Expect.isTrue(0.round() is int);
Expect.isTrue(1.round() is int);
Expect.isTrue(0x1234.round() is int);
Expect.isTrue(0x12345678.round() is int);
Expect.isTrue(0x123456789AB.round() is int);
Expect.isTrue(0x123456789ABCDEF.round() is int);
Expect.isTrue(-1.round() is int);
Expect.isTrue(-0x1234.round() is int);
Expect.isTrue(-0x12345678.round() is int);
Expect.isTrue(-0x123456789AB.round() is int);
Expect.isTrue(-0x123456789ABCDEF.round() is int);
Expect.isTrue(big.round() is int);
Expect.isTrue((-1).round() is int);
Expect.isTrue((-0x1234).round() is int);
Expect.isTrue((-0x12345678).round() is int);
Expect.isTrue((-0x123456789AB).round() is int);
Expect.isTrue((-big).round() is int);
}