From 04c66f8bab7e0a6be4bf3c5a5d527a8e2134aa50 Mon Sep 17 00:00:00 2001 From: Asger Feldthaus Date: Wed, 30 Nov 2016 08:25:53 +0100 Subject: [PATCH] Support --strong when running dartk from test.py. BUG= R=kmillikin@google.com Review URL: https://codereview.chromium.org/2536143003 . --- .../testing/dart/compiler_configuration.dart | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart index 0a15772ece9..f0f8bc71c13 100644 --- a/tools/testing/dart/compiler_configuration.dart +++ b/tools/testing/dart/compiler_configuration.dart @@ -94,7 +94,8 @@ abstract class CompilerConfiguration { return ComposedCompilerConfiguration.createDartKConfiguration( isHostChecked: isHostChecked, useSdk: useSdk, - verify: verifyKernel); + verify: verifyKernel, + strong: isStrong); case 'dartkp': return ComposedCompilerConfiguration.createDartKPConfiguration( isHostChecked: isHostChecked, @@ -102,7 +103,8 @@ abstract class CompilerConfiguration { useBlobs: useBlobs, isAndroid: configuration['system'] == 'android', useSdk: useSdk, - verify: verifyKernel); + verify: verifyKernel, + strong: isStrong); case 'none': return new NoneCompilerConfiguration( isDebug: isDebug, @@ -215,9 +217,10 @@ class NoneCompilerConfiguration extends CompilerConfiguration { /// The "dartk" compiler. class DartKCompilerConfiguration extends CompilerConfiguration { - final bool verify; + final bool verify, strong; - DartKCompilerConfiguration({bool isHostChecked, bool useSdk, this.verify}) + DartKCompilerConfiguration({bool isHostChecked, bool useSdk, this.verify, + this.strong}) : super._subclass(isHostChecked: isHostChecked, useSdk: useSdk); @override @@ -236,6 +239,7 @@ class DartKCompilerConfiguration extends CompilerConfiguration { '$buildDir/patched_sdk', '--link', '--target=vm', + strong ? '--strong' : null, verify ? '--verify-ir' : null, '--out', outputFileName @@ -367,13 +371,13 @@ class ComposedCompilerConfiguration extends CompilerConfiguration { static ComposedCompilerConfiguration createDartKPConfiguration( {bool isHostChecked, String arch, bool useBlobs, bool isAndroid, - bool useSdk, bool verify}) { + bool useSdk, bool verify, bool strong}) { var nested = []; // Compile with dartk. nested.add(new PipelineCommand.runWithGlobalArguments( new DartKCompilerConfiguration(isHostChecked: isHostChecked, - useSdk: useSdk, verify: verify))); + useSdk: useSdk, verify: verify, strong: strong))); // Run the normal precompiler. nested.add(new PipelineCommand.runWithPreviousKernelOutput( @@ -384,13 +388,13 @@ class ComposedCompilerConfiguration extends CompilerConfiguration { } static ComposedCompilerConfiguration createDartKConfiguration( - {bool isHostChecked, bool useSdk, bool verify}) { + {bool isHostChecked, bool useSdk, bool verify, bool strong}) { var nested = []; // Compile with dartk. nested.add(new PipelineCommand.runWithGlobalArguments( new DartKCompilerConfiguration(isHostChecked: isHostChecked, - useSdk: useSdk, verify: verify))); + useSdk: useSdk, verify: verify, strong: strong))); return new ComposedCompilerConfiguration(nested, isPrecompiler: false); }