From 033a81d924b91cc713463efa001d575d98c54e54 Mon Sep 17 00:00:00 2001 From: William Hesse Date: Fri, 31 Jul 2020 20:49:29 +0000 Subject: [PATCH] [build] Add dependencies to the strong summary generation Change-Id: If3615f95ad60f5b33250bd0387fb35141cff0bee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156687 Reviewed-by: Konstantin Shcheglov Commit-Queue: William Hesse --- sdk/BUILD.gn | 5 ++++- utils/dartanalyzer/BUILD.gn | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn index b7c7e6192a9..ea136e664b9 100644 --- a/sdk/BUILD.gn +++ b/sdk/BUILD.gn @@ -808,7 +808,10 @@ group("copy_libraries") { # This rule writes the version file. action("write_version_file") { - visibility = [ ":create_common_sdk" ] + visibility = [ + ":create_common_sdk", + "../utils/dartanalyzer:generate_summary_strong", + ] inputs = [ "../tools/VERSION", "$default_git_folder/logs/HEAD", diff --git a/utils/dartanalyzer/BUILD.gn b/utils/dartanalyzer/BUILD.gn index 48c9dcf8668..78c84b0d7ae 100644 --- a/utils/dartanalyzer/BUILD.gn +++ b/utils/dartanalyzer/BUILD.gn @@ -38,7 +38,11 @@ sdk_lib_files = exec_script("../../tools/list_dart_files.py", ], "list lines") -prebuilt_dart_action("generate_summary_strong") { +dart_action("generate_summary_strong") { + deps = [ + "../../sdk:copy_libraries", + "../../sdk:write_version_file", + ] script = "../../pkg/analyzer/tool/summary/build_sdk_summaries.dart" packages = "../../.packages" inputs = sdk_lib_files + analyzer_files @@ -48,6 +52,6 @@ prebuilt_dart_action("generate_summary_strong") { args = [ "build", rebase_path(output), - rebase_path("../../sdk"), + rebase_path("$root_out_dir/dart-sdk"), ] }