Address issues found with analyzer

R=kasperl@google.com

Review URL: https://codereview.chromium.org//342283004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37600 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
ahe@google.com 2014-06-23 13:24:31 +00:00
parent 6d13079205
commit 01bddd1c9c
3 changed files with 5 additions and 20 deletions

View file

@ -11,3 +11,8 @@ all:
| grep -v DEPRECATED_MEMBER_USE \
| sed -e "s,$(PWD)/,," \
| awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }'
$(SDK_DIR)/bin/dartanalyzer -p $(PACKAGE_ROOT) \
--package-warnings --machine compiler_isolate.dart 2>&1 \
| grep -v DEPRECATED_MEMBER_USE \
| sed -e "s,$(PWD)/,," \
| awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }'

View file

@ -26,8 +26,6 @@ import 'package:compiler/implementation/js_backend/js_backend.dart' show
import 'package:compiler/implementation/elements/elements.dart' show
LibraryElement;
import 'package:compiler/implementation/native_handler.dart' as native;
void clearLibraryLoader(LibraryLoaderTask libraryLoader) {
// TODO(ahe): Move this method to [LibraryLoader].
libraryLoader

View file

@ -14,9 +14,6 @@ import 'dart:html' show
Worker,
window;
import 'dart:async' show
Timer;
import 'dart:isolate' show
ReceivePort,
SendPort;
@ -289,18 +286,3 @@ self.importScripts("$url");
console.appendText('$message\n');
}
}
void compilerIsolate(SendPort port) {
// TODO(ahe): Restore when restoring deferred loading.
// lazy.load().then((_) => port.listen(compile));
ReceivePort replyTo = new ReceivePort();
port.send(replyTo.sendPort);
replyTo.listen((message) {
List list = message as List;
try {
compile(list[0], list[1]);
} catch (exception, stack) {
port.send('$exception\n$stack');
}
});
}