Spelling pkg dev compiler

Closes https://github.com/dart-lang/sdk/pull/50861

GitOrigin-RevId: 71005e6f5bf5a151cb5c1aefb6a2a300fc40f592
Change-Id: Iadfafb5787a62e9a379437f6a3763d31f99ba7c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277743
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This commit is contained in:
Josh Soref 2023-01-26 09:12:41 +00:00 committed by Commit Queue
parent c3d8f46c5b
commit 01b28894e7
63 changed files with 88 additions and 88 deletions

View file

@ -6883,7 +6883,7 @@ Patch release, resolves one issue:
`dart:indexed_db`, `dart:svg`, `dart:web_audio`, and `dart:web_gl` that
correspond to changes to Chrome APIs between v39 and v45. Many of the breaking
changes represent APIs that would have caused runtime exceptions when compiled
to Javascript and run on recent Chrome releases.
to JavaScript and run on recent Chrome releases.
- `dart:io`
- Added `SecurityContext.alpnSupported`, which is true if a platform supports
@ -7265,7 +7265,7 @@ Patch release, resolves three issues:
### Tool changes
- `dart2js` and Dartium now support improved Javascript Interoperability via the
- `dart2js` and Dartium now support improved JavaScript Interoperability via the
[js package](https://pub.dev/packages/js).
- `docgen` and `dartdocgen` no longer ship in the SDK. The `docgen` sources have
@ -7626,7 +7626,7 @@ Patch release, resolves three issues:
This is a bug fix release which merges a number of commits from `bleeding_edge`.
- dart2js: Addresses as issue with minified Javascript output with CSP enabled -
- dart2js: Addresses as issue with minified JavaScript output with CSP enabled -
[r44453](https://code.google.com/p/dart/source/detail?r=44453)
- Editor: Fixes accidental updating of files in the pub cache during rename

View file

@ -8,7 +8,7 @@ bin/ Binaries/scripts to compile, run, and manage Dart apps.
dart Command line Dart tool
dartaotruntime Minimal Dart runtime for running AOT modules
dart2js Dart to JavaScript production compiler
dartdevc Dart to Javascript development compiler
dartdevc Dart to JavaScript development compiler
dartdoc Dart documentation generator
analyze_snapshot Standalone tool to dump information on AOT snapshots

View file

@ -12425,7 +12425,7 @@ const Template<
problemMessageTemplate:
r"""The integer literal #string can't be represented exactly in JavaScript.""",
correctionMessageTemplate:
r"""Try changing the literal to something that can be represented in Javascript. In Javascript #string2 is the nearest value that can be represented exactly.""",
r"""Try changing the literal to something that can be represented in JavaScript. In JavaScript #string2 is the nearest value that can be represented exactly.""",
withArguments: _withArgumentsWebLiteralCannotBeRepresentedExactly);
// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
@ -12443,7 +12443,7 @@ Message _withArgumentsWebLiteralCannotBeRepresentedExactly(
return new Message(codeWebLiteralCannotBeRepresentedExactly,
problemMessage:
"""The integer literal ${string} can't be represented exactly in JavaScript.""",
correctionMessage: """Try changing the literal to something that can be represented in Javascript. In Javascript ${string2} is the nearest value that can be represented exactly.""",
correctionMessage: """Try changing the literal to something that can be represented in JavaScript. In JavaScript ${string2} is the nearest value that can be represented exactly.""",
arguments: {'string': string, 'string2': string2});
}

View file

@ -657,7 +657,7 @@ class Listener implements UnescapeErrorListener {
}
/// Handle the beginning of a named function expression which isn't legal
/// syntax in Dart. Useful for recovering from Javascript code being pasted
/// syntax in Dart. Useful for recovering from JavaScript code being pasted
/// into a Dart program, as it will interpret `function foo() {}` as a named
/// function expression with return type `function` and name `foo`.
///
@ -666,7 +666,7 @@ class Listener implements UnescapeErrorListener {
void beginNamedFunctionExpression(Token token) {}
/// A named function expression which isn't legal syntax in Dart.
/// Useful for recovering from Javascript code being pasted into a Dart
/// Useful for recovering from JavaScript code being pasted into a Dart
/// program, as it will interpret `function foo() {}` as a named function
/// expression with return type `function` and name `foo`.
///

View file

@ -4996,7 +4996,7 @@ class Parser {
///
/// If [isFunctionExpression] is true, this method parses the rest of named
/// function expression which isn't legal syntax in Dart. Useful for
/// recovering from Javascript code being pasted into a Dart program, as it
/// recovering from JavaScript code being pasted into a Dart program, as it
/// will interpret `function foo() {}` as a named function expression with
/// return type `function` and name `foo`.
///

View file

@ -443,7 +443,7 @@ class Response {
/// Initialize a newly created instance to represent an error condition caused
/// by a [request] that had invalid parameter. [path] is the path to the
/// invalid parameter, in Javascript notation (e.g. "foo.bar" means that the
/// invalid parameter, in JavaScript notation (e.g. "foo.bar" means that the
/// parameter "foo" contained a key "bar" whose value was the wrong type).
/// [expectation] is a description of the type of data that was expected.
Response.invalidParameter(Request request, String path, String expectation)

View file

@ -425,7 +425,7 @@ class Response {
/// Initialize a newly created instance to represent an error condition caused
/// by a [request] that had invalid parameter. [path] is the path to the
/// invalid parameter, in Javascript notation (e.g. "foo.bar" means that the
/// invalid parameter, in JavaScript notation (e.g. "foo.bar" means that the
/// parameter "foo" contained a key "bar" whose value was the wrong type).
/// [expectation] is a description of the type of data that was expected.
Response.invalidParameter(Request request, String path, String expectation)

View file

@ -242,7 +242,7 @@ class RequestErrorFactory {
/// Return a request error representing an error condition caused by a request
/// that had an invalid parameter. The [path] is the path to the invalid
/// parameter, in Javascript notation (e.g. "foo.bar" means that the parameter
/// parameter, in JavaScript notation (e.g. "foo.bar" means that the parameter
/// "foo" contained a key "bar" whose value was the wrong type). The
/// [expectation] is a description of the type of data that was expected.
static RequestError invalidParameter(String path, String expectation) =>

View file

@ -227,7 +227,7 @@ functionality is publicly exposed.
to elements that are understood directly in Dart.
* `lib/src/js_backend/backend_helpers.dart`: provides a way to lookup internal
elements of the Javascript backend, like our internal
elements of the JavaScript backend, like our internal
representation of JSInt31, JSArray, and other implementation-specific
elements.

View file

@ -1157,7 +1157,7 @@ class DumpInfoTask extends CompilerTask implements InfoReporter {
/// [registerEntityAst] is called.
final Map<jsAst.Node, CodeSpan> _nodeData = <jsAst.Node, CodeSpan>{};
// A mapping from Dart Entities to Javascript AST Nodes.
// A mapping from Dart Entities to JavaScript AST Nodes.
final Map<Entity, List<jsAst.Node>> _entityToNodes =
<Entity, List<jsAst.Node>>{};
final Map<ConstantValue, jsAst.Node> _constantToNode =

View file

@ -71,7 +71,7 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
final String Function(String) safeVariableName;
// All the <x>Name variables are names of Javascript variables used in the
// All the <x>Name variables are names of JavaScript variables used in the
// transformed code.
/// Contains the result of an awaited expression, or a conditional or
@ -567,7 +567,7 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
Iterable<js.VariableInitialization> variableInitializations(
js.JavaScriptNodeSourceInformation? sourceInformation);
/// Rewrites an async/sync*/async* function to a normal Javascript function.
/// Rewrites an async/sync*/async* function to a normal JavaScript function.
///
/// The control flow is flattened by simulating 'goto' using a switch in a
/// loop and a state variable [goto] inside a nested function [body]
@ -1138,7 +1138,7 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
@override
void visitForIn(js.ForIn node) {
// The dart output currently never uses for-in loops.
throw "Javascript for-in not implemented yet in the await transformation";
throw "JavaScript for-in not implemented yet in the await transformation";
}
@override

View file

@ -13,7 +13,7 @@ import '../js_backend/string_reference.dart';
import '../js_backend/type_reference.dart';
import '../js_emitter/metadata_collector.dart';
/// Estimates the size of the Javascript AST represented by the provided [Node].
/// Estimates the size of the JavaScript AST represented by the provided [Node].
int estimateSize(Node node) {
var estimator = SizeEstimator();
estimator.visit(node);

View file

@ -91,9 +91,9 @@ class CustomElementsResolutionAnalysis extends CustomElementsAnalysisBase {
: join = CustomElementsAnalysisJoin(
elementEnvironment, commonElements, nativeData,
backendUsageBuilder: backendUsageBuilder) {
// TODO(sra): Remove this work-around. We should mark allClassesSelected in
// TODO(sra): Remove this workaround. We should mark allClassesSelected in
// both joins only when we see a construct generating an unknown [Type] but
// we can't currently recognize all cases. In particular, the work-around
// we can't currently recognize all cases. In particular, the workaround
// for the unimplemented `ClassMirror.reflectedType` is not recognizable.
// TODO(12607): Match on [ClassMirror.reflectedType]
join.allClassesSelected = true;
@ -124,9 +124,9 @@ class CustomElementsCodegenAnalysis extends CustomElementsAnalysisBase {
: join = CustomElementsAnalysisJoin(
elementEnvironment, commonElements, nativeData),
super(elementEnvironment, commonElements, nativeData) {
// TODO(sra): Remove this work-around. We should mark allClassesSelected in
// TODO(sra): Remove this workaround. We should mark allClassesSelected in
// both joins only when we see a construct generating an unknown [Type] but
// we can't currently recognize all cases. In particular, the work-around
// we can't currently recognize all cases. In particular, the workaround
// for the unimplemented `ClassMirror.reflectedType` is not recognizable.
// TODO(12607): Match on [ClassMirror.reflectedType]
join.allClassesSelected = true;

View file

@ -56,7 +56,7 @@ import '../model.dart';
/// cleanly, we use various abstractions to merge [OutputUnits].
///
/// First, we emit the code for each [OutputUnit] into an [EmittedOutputUnit].
/// An [EmittedOutputUnit] is the Javascript representation of an [OutputUnit].
/// An [EmittedOutputUnit] is the JavaScript representation of an [OutputUnit].
/// [EmittedOutputUnits] map 1:1 to [OutputUnits].
///
/// We wrap each [EmittedOutputUnit] in a [PreFragment], which is just a wrapper
@ -65,7 +65,7 @@ import '../model.dart';
/// threshold.
///
/// Once we are finished merging [PreFragments], we must now decide on their
/// final representation in Javascript.
/// final representation in JavaScript.
///
/// Depending on the results of the merge, we chose one of two representations.
/// For example, say we merge {a, b} and {a} into {a, b}+{a}. In this case our

View file

@ -21,7 +21,7 @@ export 'native_throw_behavior.dart';
typedef TypeLookup = Object? /*DartType|SpecialType*/
Function(String typeString, {bool required});
/// This class is a temporary work-around until we get a more powerful DartType.
/// This class is a temporary workaround until we get a more powerful DartType.
class SpecialType {
final String name;
const SpecialType._(this.name);

View file

@ -1929,7 +1929,7 @@ class SsaInstructionSimplifier extends HBaseVisitor<HInstruction>
if (value is IntConstantValue) {
// Only constant-fold int.toString() when Dart and JS results the
// same.
// TODO(18103): We should be able to remove this work-around when
// TODO(18103): We should be able to remove this workaround when
// issue 18103 is resolved by providing the correct string.
if (!value.isUInt32()) return null;
return asString('${value.intValue}');

View file

@ -25,7 +25,7 @@ part of touch;
/// properties of the drag to you while the touch is happening and at the
/// end of the drag sequence. This behavior will NOT perform the actual
/// dragging (redrawing the element) for you, this responsibility is left to
/// the client code. This behavior contains a work around for a mobile
/// the client code. This behavior contains a workaround for a mobile
/// safari bug where the 'touchend' event is not dispatched when the touch
/// goes past the bottom of the browser window.
/// This is intended to work well in iframes.

View file

@ -21,7 +21,7 @@
/// environment flag. The flag only works dart2js version 1.13.0 or newer.
///
/// * Launch the coverage server tool (in this package) to serve up the
/// Javascript code in your app:
/// JavaScript code in your app:
///
/// dart tool/coverage_log_server.dart main.dart.js
///

View file

@ -319,7 +319,7 @@ class Printer implements NodeVisitor {
var elsePart = node.otherwise;
bool hasElse = node.hasElse;
// Handle dangling elses and a work-around for Android 4.0 stock browser.
// Handle dangling elses and a workaround for Android 4.0 stock browser.
// Android 4.0 requires braces for a single do-while in the `then` branch.
// See issue 10923.
if (hasElse) {

View file

@ -736,7 +736,7 @@ JSCode jsProgramToCode(js_ast.Program moduleTree, ModuleFormat format,
/// names used when outputting the JavaScript.
ModuleSymbols _emitSymbols(ProgramCompiler compiler, String moduleName,
Map<js_ast.Identifier, String> identifierNames, Component component) {
/// Returns the name selected in the final Javascript for [id].
/// Returns the name selected in the final JavaScript for [id].
String lookupName(js_ast.Identifier id) {
var name = identifierNames[id];
if (name == null) {

View file

@ -220,7 +220,7 @@ class FileEndOffsetCalculator extends Visitor<int?> with VisitorNullMixin<int> {
/// can give such information for a given [node], i.e. satisfies one
/// of the following conditions:
///
/// - a node with with a greater start offset that is a child of the
/// - a node with a greater start offset that is a child of the
/// closest ancestor. The start offset of this child is used as a
/// file end offset of the [node].
///

View file

@ -67,7 +67,7 @@ class ModuleSymbolsCollector extends RecursiveVisitor {
@override
void visitClass(Class node) {
// Some class names are not emitted, i.e. mixin aplications.
// Some class names are not emitted, i.e. mixin applications.
if (_classJsNames[node] != null) {
var classSymbol = ClassSymbol(
name: node.name,

View file

@ -226,7 +226,7 @@ class TypeTable {
// This is only reached when [type] is itself a bound that depends on a
// free type parameter.
// TODO(markzipan): Bounds are locally hoisted to their own JS identifiers,
// but we don't do this this for other types that depend on free variables,
// but we don't do this for other types that depend on free variables,
// resulting in some duplicated runtime code. We may get some performance
// wins if we just locally hoist everything.
if (freeVariables.isNotEmpty) {

View file

@ -4,7 +4,7 @@
// BSD-style license that can be found in the LICENSE file.
/// Tool that consumes the .dill file of an entire dart-sdk and produces the
/// corresponding Javascript module.
/// corresponding JavaScript module.
import 'dart:io';
import 'package:dev_compiler/src/kernel/command.dart';

View file

@ -62,7 +62,7 @@ See [How to test Fasta](TESTING.md)
./sdk/bin/dart pkg/compiler/lib/src/dart2js.dart.dill pkg/front_end/test/fasta/hello.dart
```
The output of dart2js will be `out.js`, and it can be run on any Javascript engine, for example, d8 which is included with the Dart SDK sources:
The output of dart2js will be `out.js`, and it can be run on any JavaScript engine, for example, d8 which is included with the Dart SDK sources:
```
./third_party/d8/<OS>/d8 out.js

View file

@ -114,7 +114,7 @@ class RedirectingFactoryBody extends ReturnStatement {
}
static void restoreFromDill(Procedure factory) {
// This is a hack / work around for storing redirecting constructors in
// This is a hack / workaround for storing redirecting constructors in
// dill files. See `ClassBuilder.addRedirectingConstructor` in
// [kernel_class_builder.dart](kernel_class_builder.dart).
FunctionNode function = factory.function;

View file

@ -4228,7 +4228,7 @@ InitializeFromDillUnknownProblemNoDump:
WebLiteralCannotBeRepresentedExactly:
problemMessage: "The integer literal #string can't be represented exactly in JavaScript."
correctionMessage: "Try changing the literal to something that can be represented in Javascript. In Javascript #string2 is the nearest value that can be represented exactly."
correctionMessage: "Try changing the literal to something that can be represented in JavaScript. In JavaScript #string2 is the nearest value that can be represented exactly."
BoundIssueViaRawTypeWithNonSimpleBounds:
problemMessage: "Generic type '#name' can't be used without type arguments in a type variable bound."

View file

@ -395,7 +395,7 @@ class FrontendCompiler implements CompilerInterface {
late bool _printIncrementalDependencies;
late ProcessedOptions _processedOptions;
/// Initialized in [writeJavascriptBundle]
/// Initialized in [writeJavaScriptBundle]
IncrementalJavaScriptBundler? _bundler;
/// Nullable fields
@ -605,7 +605,7 @@ class FrontendCompiler implements CompilerInterface {
transformer?.transform(results.component!);
if (_compilerOptions.target!.name == 'dartdevc') {
await writeJavascriptBundle(results, _kernelBinaryFilename,
await writeJavaScriptBundle(results, _kernelBinaryFilename,
options['filesystem-scheme'], options['dartdevc-module-format'],
fullComponent: true);
}
@ -666,7 +666,7 @@ class FrontendCompiler implements CompilerInterface {
}
/// Write a JavaScript bundle containing the provided component.
Future<void> writeJavascriptBundle(KernelCompilationResults results,
Future<void> writeJavaScriptBundle(KernelCompilationResults results,
String filename, String fileSystemScheme, String moduleFormat,
{required bool fullComponent}) async {
// ignore: unnecessary_null_comparison
@ -851,7 +851,7 @@ class FrontendCompiler implements CompilerInterface {
deltaProgram.uriToSource.keys);
if (_compilerOptions.target!.name == 'dartdevc') {
await writeJavascriptBundle(results, _kernelBinaryFilename,
await writeJavaScriptBundle(results, _kernelBinaryFilename,
_options['filesystem-scheme'], _options['dartdevc-module-format'],
fullComponent: false);
} else {

View file

@ -40,7 +40,7 @@ class StrongComponents {
/// The libraries loaded from a dill file that should not be processed.
final Set<Library> loadedLibraries;
/// The main URI for thiis application.
/// The main URI for this application.
final Uri mainUri;
/// The filesystem instance for resolving files.

View file

@ -2488,7 +2488,7 @@ e() {
frontendServer.close();
});
test('compile expression to Javascript', () async {
test('compile expression to JavaScript', () async {
var file = File('${tempDir.path}/foo.dart')..createSync();
file.writeAsStringSync("main() {\n}\n");
var packageConfig = File('${tempDir.path}/.dart_tool/package_config.json')
@ -2576,7 +2576,7 @@ e() {
expect(count, 3);
});
test('compiled Javascript includes web library environment defines',
test('compiled JavaScript includes web library environment defines',
() async {
var file = File('${tempDir.path}/foo.dart')..createSync();
file.writeAsStringSync(

View file

@ -376,7 +376,7 @@ class Printer implements NodeVisitor<void> {
Statement elsePart = node.otherwise;
bool hasElse = node.hasElse;
// Handle dangling elses and a work-around for Android 4.0 stock browser.
// Handle dangling elses and a workaround for Android 4.0 stock browser.
// Android 4.0 requires braces for a single do-while in the `then` branch.
// See issue 10923.
if (hasElse) {

View file

@ -8305,7 +8305,7 @@ class StringLiteral extends BasicLiteral {
class IntLiteral extends BasicLiteral {
/// Note that this value holds a uint64 value.
/// E.g. "0x8000000000000000" will be saved as "-9223372036854775808" despite
/// technically (on some platforms, particularly Javascript) being positive.
/// technically (on some platforms, particularly JavaScript) being positive.
/// If the number is meant to be negative it will be wrapped in a "unary-".
@override
int value;

View file

@ -389,8 +389,8 @@ abstract class Target {
bool get nativeExtensionExpectsString => false;
/// Whether integer literals that cannot be represented exactly on the web
/// (i.e. in Javascript) should cause an error to be issued.
/// An example of such a number is `2^53 + 1` where in Javascript - because
/// (i.e. in JavaScript) should cause an error to be issued.
/// An example of such a number is `2^53 + 1` where in JavaScript - because
/// integers are represented as doubles
/// `Math.pow(2, 53) = Math.pow(2, 53) + 1`.
bool get errorOnUnexactWebIntLiterals => false;

View file

@ -1020,7 +1020,7 @@ LayoutTests/fast/dom/DOMException/dispatch-event-exception_t01: RuntimeError # h
LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/DOMImplementation/createDocumentType-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/basic_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox_t01: Pass, RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox_t01: Pass, RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/replace-element_t01: RuntimeError # Please triage this failure.
@ -2117,7 +2117,7 @@ LayoutTests/fast/dom/DOMException/dispatch-event-exception_t01: RuntimeError # P
LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/DOMImplementation/createDocumentType-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/basic_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-user-select-none_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style_t01: RuntimeError # Please triage this failure
@ -3455,7 +3455,7 @@ LayoutTests/fast/dom/DOMException/XPathException_t01: RuntimeError # Please tria
LayoutTests/fast/dom/DOMException/dispatch-event-exception_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/basic_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-user-select-none_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style_t01: RuntimeError # Please triage this failure
@ -4812,7 +4812,7 @@ LayoutTests/fast/dom/DOMException/XPathException_t01: RuntimeError # Please tria
LayoutTests/fast/dom/DOMException/dispatch-event-exception_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/basic_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-user-select-none_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll_t01: RuntimeError # Please triage this failure
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style_t01: RuntimeError # Please triage this failure

View file

@ -21,9 +21,9 @@ This package is not:
We want to test tool chains, for example, a Dart compiler. Depending on the tool chain, it may comprise several individual steps. For example, to test dart2js, you have these steps:
1. Run dart2js on a Dart source file to produce a Javascript output file.
1. Run dart2js on a Dart source file to produce a JavaScript output file.
2. Run the Javascript file from step 1 on a Javascript interpreter and report if the program threw an exception.
2. Run the JavaScript file from step 1 on a JavaScript interpreter and report if the program threw an exception.
On the other hand, to test a Dart VM, there's only one step:

View file

@ -65,7 +65,7 @@ DEFINE_NATIVE_ENTRY(List_slice, 0, 4) {
// Private factory, expects correct arguments.
DEFINE_NATIVE_ENTRY(ImmutableList_from, 0, 4) {
// Ignore first argument of a thsi factory (type argument).
// Ignore first argument of this factory (type argument).
const Array& from_array =
Array::CheckedHandle(zone, arguments->NativeArgAt(1));
const Smi& smi_offset = Smi::CheckedHandle(zone, arguments->NativeArgAt(2));

View file

@ -83,7 +83,7 @@ Future asyncStepOver(Isolate isolate) async {
}
}
// Complete futures with with error.
// Complete futures with error.
completeError(error) {
if (!pausedAtSyntheticBreakpoint.isCompleted) {
pausedAtSyntheticBreakpoint.completeError(error);

View file

@ -85,7 +85,7 @@ Future asyncStepOver(Isolate isolate) async {
}
}
// Complete futures with with error.
// Complete futures with error.
completeError(error) {
if (!pausedAtSyntheticBreakpoint.isCompleted) {
pausedAtSyntheticBreakpoint.completeError(error);

View file

@ -461,7 +461,7 @@ class Utils {
// dart2js represents integers as double precision floats, which can
// represent anything in the range -2^53 ... 2^53.
static bool IsJavascriptInt(int64_t value) {
static bool IsJavaScriptInt(int64_t value) {
return ((-0x20000000000000LL <= value) && (value <= 0x20000000000000LL));
}

View file

@ -3393,7 +3393,7 @@ static void GenerateIdenticalWithNumberCheckStub(Assembler* assembler,
__ CompareObjectRegisters(left, right);
// None of the branches above go directly here to avoid generating a
// conditional branch to a ret instruction.
// This is an attempt to work-around a possible CPU on Exynos 2100 SoC.
// This is an attempt to workaround a possible CPU on Exynos 2100 SoC.
// See https://github.com/flutter/flutter/issues/88261
__ ret();
}

View file

@ -539,10 +539,10 @@ char* Dart::Init(const Dart_InitializeParams* params) {
}
static void DumpAliveIsolates(intptr_t num_attempts,
bool only_aplication_isolates) {
bool only_application_isolates) {
IsolateGroup::ForEach([&](IsolateGroup* group) {
group->ForEachIsolate([&](Isolate* isolate) {
if (!only_aplication_isolates || !Isolate::IsSystemIsolate(isolate)) {
if (!only_application_isolates || !Isolate::IsSystemIsolate(isolate)) {
OS::PrintErr("Attempt:%" Pd " waiting for isolate %s to check in\n",
num_attempts, isolate->name());
}

View file

@ -326,7 +326,7 @@ bool JSONWriter::NeedComma() {
void JSONWriter::EnsureIntegerIsRepresentableInJavaScript(int64_t i) {
#ifdef DEBUG
if (!Utils::IsJavascriptInt(i)) {
if (!Utils::IsJavaScriptInt(i)) {
OS::PrintErr(
"JSONWriter::EnsureIntegerIsRepresentableInJavaScript failed on "
"%" Pd64 "\n",

View file

@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Javascript preamble, that lets the output of dart2js run on V8's d8 shell.
// JavaScript preamble, that lets the output of dart2js run on V8's d8 shell.
// Node wraps files and provides them with a different `this`. The global
// `this` can be accessed through `global`.

View file

@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Javascript preamble, that lets the output of dart2js run on JSShell.
// JavaScript preamble, that lets the output of dart2js run on JSShell.
(function(self) {
// Using strict mode to avoid accidentally defining global variables.

View file

@ -414,7 +414,7 @@ final _dartProxyCtor = JS('', 'function DartObject(o) { this.o = o; }');
Object? _convertToJS(Object? o) {
// Note: we don't write `if (o == null) return null;` to make sure dart2js
// doesn't convert `return null;` into `return;` (which would make `null` be
// `undefined` in Javascprit). See dartbug.com/20305 for details.
// `undefined` in JavaScript). See dartbug.com/20305 for details.
if (o == null || o is String || o is num || o is bool) {
return o;
}

View file

@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Javascript preamble, that lets the output of dart2js run on V8's d8 shell.
// JavaScript preamble, that lets the output of dart2js run on V8's d8 shell.
// Node wraps files and provides them with a different `this`. The global
// `this` can be accessed through `global`.

View file

@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Javascript preamble, that lets the output of dart2js run on JSShell.
// JavaScript preamble, that lets the output of dart2js run on JSShell.
(function(self, scriptArguments) {
// Using strict mode to avoid accidentally defining global variables.

View file

@ -374,7 +374,7 @@ class _GrowableList<T> extends ListBase<T> {
void _grow(int new_capacity) {
var newData = _allocateData(new_capacity);
// This is a work-around for dartbug.com/30090: array-bound-check
// This is a workaround for dartbug.com/30090: array-bound-check
// generalization causes excessive deoptimizations because it
// hoists CheckArrayBound(i, ...) out of the loop below and turns it
// into CheckArrayBound(length - 1, ...). Which deoptimizes
@ -398,7 +398,7 @@ class _GrowableList<T> extends ListBase<T> {
void _shrink(int new_capacity, int new_length) {
var newData = _allocateData(new_capacity);
// This is a work-around for dartbug.com/30090. See the comment in _grow.
// This is a workaround for dartbug.com/30090. See the comment in _grow.
if (new_length > 0) {
for (int i = 0; i < new_length; i++) {
newData[i] = this[i];

View file

@ -47,7 +47,7 @@
///
/// ## Proxying and automatic conversion
///
/// When setting properties on a JsObject or passing arguments to a Javascript
/// When setting properties on a JsObject or passing arguments to a JavaScript
/// method or function, Dart objects are automatically converted or proxied to
/// JavaScript objects. When accessing JavaScript properties, or when a Dart
/// closure is invoked from JavaScript, the JavaScript objects are also

View file

@ -22,7 +22,7 @@ main() {
// files from this stack trace, so just let the test pass.
//
// Note: it's not sufficient to check for the absence of `.dart` in the
// stacktrace, because obfuscated Javascript stacktraces often contain
// stacktrace, because obfuscated JavaScript stacktraces often contain
// `self.dartMainRunner`.
} else {
Expect.contains(

View file

@ -151,7 +151,7 @@ class MethodBindingTest {
A.func = A.foo;
Expect.equals(4, A.func());
// bind a function that is possibly native in Javascript.
// bind a function that is possibly native in JavaScript.
String o15 = 'hithere';
var f15 = o15.substring;
Expect.equals('i', f15(1, 2));

View file

@ -189,7 +189,7 @@ class CAaMAiBCaMBCiIJ_2 extends CAaMAiBC with MBCiIJ {}
// Abstract mixin application does not implement I and J.
abstract class OaMiIJ = O with MiIJ;
// Concrete subclass of abstract mixin appliction
// Concrete subclass of abstract mixin application
class COaMiIJ extends OaMiIJ {
String toString() => "${super.toString()}:COaMiIJ";
String methodI() => "COaMiIJ:${this}.I";
@ -199,7 +199,7 @@ class COaMiIJ extends OaMiIJ {
// Abstract class with mixin application and does not implement I and J.
abstract class OaMiIJ_2 extends O with MiIJ {}
// Concrete subclass of abstract mixin appliction
// Concrete subclass of abstract mixin application
class COaMiIJ_2 extends OaMiIJ_2 {
String toString() => "${super.toString()}:COaMiIJ";
String methodI() => "COaMiIJ:${this}.I";

View file

@ -24,7 +24,7 @@ main() {
// files from this stack trace, so just let the test pass.
//
// Note: it's not sufficient to check for the absence of `.dart` in the
// stacktrace, because obfuscated Javascript stacktraces often contain
// stacktrace, because obfuscated JavaScript stacktraces often contain
// `self.dartMainRunner`.
} else {
Expect.contains(

View file

@ -153,7 +153,7 @@ class MethodBindingTest {
A.func = A.foo;
Expect.equals(4, A.func());
// bind a function that is possibly native in Javascript.
// bind a function that is possibly native in JavaScript.
String o15 = 'hithere';
var f15 = o15.substring;
Expect.equals('i', f15(1, 2));

View file

@ -191,7 +191,7 @@ class CAaMAiBCaMBCiIJ_2 extends CAaMAiBC with MBCiIJ {}
// Abstract mixin application does not implement I and J.
abstract class OaMiIJ = O with MiIJ;
// Concrete subclass of abstract mixin appliction
// Concrete subclass of abstract mixin application
class COaMiIJ extends OaMiIJ {
String toString() => "${super.toString()}:COaMiIJ";
String methodI() => "COaMiIJ:${this}.I";
@ -201,7 +201,7 @@ class COaMiIJ extends OaMiIJ {
// Abstract class with mixin application and does not implement I and J.
abstract class OaMiIJ_2 extends O with MiIJ {}
// Concrete subclass of abstract mixin appliction
// Concrete subclass of abstract mixin application
class COaMiIJ_2 extends OaMiIJ_2 {
String toString() => "${super.toString()}:COaMiIJ";
String methodI() => "COaMiIJ:${this}.I";

View file

@ -23,8 +23,8 @@ main() {
var weakRef = WeakReference<List<String>>(list);
expect(weakRef.target, equals(list));
// Javascript API throws when the representation of target is not 'object'
// in the compiled Javascript.
// JavaScript API throws when the representation of target is not 'object'
// in the compiled JavaScript.
expect(() => WeakReference<String>("foo"), throws);
expect(() => WeakReference<int>(1), throws);
});

View file

@ -23,8 +23,8 @@ main() {
var weakRef = WeakReference<List<String>>(list);
expect(weakRef.target, equals(list));
// Javascript API throws when the representation of target is not 'object'
// in the compiled Javascript.
// JavaScript API throws when the representation of target is not 'object'
// in the compiled JavaScript.
expect(() => WeakReference<String>("foo"), throws);
expect(() => WeakReference<int>(1), throws);
});

View file

@ -307,7 +307,7 @@ def main():
dest='dart_js_interop',
action='store_true',
default=False,
help='Use Javascript objects (dart:js) accessing the DOM in _blink')
help='Use JavaScript objects (dart:js) accessing the DOM in _blink')
parser.add_option(
'--no-cached-patches',
dest='no_cached_patches',

View file

@ -563,7 +563,7 @@ def _Process_Operations(blink_file,
# List of DartName operations to not emit (e.g., For now only WebGL2RenderingContextBase
# has readPixels in both WebGLRenderingContextBase and WebGL2RenderingContextBase.
# Furthermore, readPixels has the exact same number of arguments - in Javascript
# Furthermore, readPixels has the exact same number of arguments - in JavaScript
# there is no typing so they're the same.
suppressed_operations = {
'WebGL2RenderingContextBase': ['readPixels2', 'texImage2D2'],

View file

@ -215,7 +215,7 @@ class _ElementCssClassSet extends CssClassSetImpl {
}
// A collection of static methods for DomTokenList. These methods are a
// work-around for the lack of annotations to express the full behaviour of
// workaround for the lack of annotations to express the full behaviour of
// the DomTokenList methods.
static DomTokenList _classListOf(Element e) => JS(

View file

@ -86,7 +86,7 @@ template("aot_snapshot") {
"--output=" + rebase_path(output, root_build_dir),
"--depfile=" + rebase_path(depfile),
# Ensure the compiled appliation (e.g. kernel-service, frontend-server,
# Ensure the compiled application (e.g. kernel-service, frontend-server,
# ...) will use this SDK hash when consuming/producing kernel.
#
# (Instead of ensuring every user of the "application_snapshot" /

View file

@ -128,7 +128,7 @@ template("_application_snapshot") {
"--output=" + rebase_path(output, root_build_dir),
"--depfile=" + rebase_path(depfile),
# Ensure the compiled appliation (e.g. kernel-service, frontend-server,
# Ensure the compiled application (e.g. kernel-service, frontend-server,
# ...) will use this SDK hash when consuming/producing kernel.
#
# (Instead of ensuring every user of the "application_snapshot" /

View file

@ -9,7 +9,7 @@ import("../application_snapshot.gni")
import("../create_timestamp.gni")
declare_args() {
# Enables DDC canary features during compilation to Javascript.
# Enables DDC canary features during compilation to JavaScript.
ddc_canary = false
}