languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 08:44:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vm] Globals cleanup TARGET_ARCH_IS_*

Browse source 
There were two sets of defines of `TARGET_ARCH_IS_*` in `globals.h`.

`IS_SIMARM_X64` implies `TARGET_ARCH_ARM` implies
`TARGET_ARCH_IS_32_BIT`, so the second set of defines can be removed.

Closes https://github.com/dart-lang/sdk/issues/44177.

TEST=The build on all configurations.

Change-Id: I9f8d5ce9ebc7186c4fb36a7d8acbc6c0165c80d1
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-linux-debug-ia32-try,vm-ffi-android-debug-arm64-try,vm-ffi-android-debug-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171884
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
Daco Harkes 2020-11-13 21:59:24 +00:00 committed by commit-bot@chromium.org
parent 9c334a8f3c
commit 00fe513296
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
runtime/platform/globals.h
View file

@ -374,12 +374,6 @@ typedef simd128_value_t fpu_register_t;
#error Unknown architecture.
#endif
#if defined(ARCH_IS_32_BIT) || defined(IS_SIMARM_X64)
#define TARGET_ARCH_IS_32_BIT 1
#elif defined(ARCH_IS_64_BIT)
#define TARGET_ARCH_IS_64_BIT 1
#endif
#if !defined(TARGET_OS_ANDROID) && !defined(TARGET_OS_FUCHSIA) && \
!defined(TARGET_OS_MACOS_IOS) && !defined(TARGET_OS_LINUX) && \
!defined(TARGET_OS_MACOS) && !defined(TARGET_OS_WINDOWS)