dart-sdk/tests/ffi_2/regress_b_261224444_test.dart

28 lines
735 B
Dart
Raw Normal View History

[vm/ffi] Fix FfiTrampolineData GC bug This lets the GC visit FfiTrampolineData::c_signature again. https://dart-review.googlesource.com/c/sdk/+/272201 stopped adding FfiTrampolineData::c_signature to snapshots. However, instead of skipping it manually in app_shapshot.cc, we skipped it in raw_object.h, which also caused the GC to skip it. This CL adds it back in as we need it in JIT snapshots. This way we keep it consistent between AOT/JIT snapshots. TEST=tests/ffi/regress_b_261224444_test.dart The c signatures of FFI trampolines were not properly traced in the precompiler, causing us to hit an assert when the classes mentioned in those types where only referenced from a signature and not retained for any other reason. TEST=tests/ffi/native_assets/process_test.dart (dartkp) Closes: https://github.com/dart-lang/sdk/issues/50678 Bug: b/261224444 Change-Id: I84fc880744c2045ea3e2ef4f37df454b80b2faeb Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274387 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-12-12 15:46:33 +00:00
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// @dart=2.9
import 'dart:ffi';
import 'ffi_test_helpers.dart';
main() {
// Ensure we have FfiTrampolineData in heap.
final malloc = DynamicLibrary.process()
[vm/ffi] Fix FfiTrampolineData GC bug This lets the GC visit FfiTrampolineData::c_signature again. https://dart-review.googlesource.com/c/sdk/+/272201 stopped adding FfiTrampolineData::c_signature to snapshots. However, instead of skipping it manually in app_shapshot.cc, we skipped it in raw_object.h, which also caused the GC to skip it. This CL adds it back in as we need it in JIT snapshots. This way we keep it consistent between AOT/JIT snapshots. TEST=tests/ffi/regress_b_261224444_test.dart The c signatures of FFI trampolines were not properly traced in the precompiler, causing us to hit an assert when the classes mentioned in those types where only referenced from a signature and not retained for any other reason. TEST=tests/ffi/native_assets/process_test.dart (dartkp) Closes: https://github.com/dart-lang/sdk/issues/50678 Bug: b/261224444 Change-Id: I84fc880744c2045ea3e2ef4f37df454b80b2faeb Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274387 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-12-12 15:46:33 +00:00
.lookup<NativeFunction<Pointer<Void> Function(IntPtr)>>("malloc")
.asFunction<Pointer<Void> Function(int)>();
print(malloc);
[vm/ffi] Fix FfiTrampolineData GC bug This lets the GC visit FfiTrampolineData::c_signature again. https://dart-review.googlesource.com/c/sdk/+/272201 stopped adding FfiTrampolineData::c_signature to snapshots. However, instead of skipping it manually in app_shapshot.cc, we skipped it in raw_object.h, which also caused the GC to skip it. This CL adds it back in as we need it in JIT snapshots. This way we keep it consistent between AOT/JIT snapshots. TEST=tests/ffi/regress_b_261224444_test.dart The c signatures of FFI trampolines were not properly traced in the precompiler, causing us to hit an assert when the classes mentioned in those types where only referenced from a signature and not retained for any other reason. TEST=tests/ffi/native_assets/process_test.dart (dartkp) Closes: https://github.com/dart-lang/sdk/issues/50678 Bug: b/261224444 Change-Id: I84fc880744c2045ea3e2ef4f37df454b80b2faeb Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274387 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-12-12 15:46:33 +00:00
triggerGc();
final pointer = malloc(100);
print(pointer.address);
final free = DynamicLibrary.process()
.lookupFunction<Void Function(Pointer), void Function(Pointer)>('free');
free(pointer);
[vm/ffi] Fix FfiTrampolineData GC bug This lets the GC visit FfiTrampolineData::c_signature again. https://dart-review.googlesource.com/c/sdk/+/272201 stopped adding FfiTrampolineData::c_signature to snapshots. However, instead of skipping it manually in app_shapshot.cc, we skipped it in raw_object.h, which also caused the GC to skip it. This CL adds it back in as we need it in JIT snapshots. This way we keep it consistent between AOT/JIT snapshots. TEST=tests/ffi/regress_b_261224444_test.dart The c signatures of FFI trampolines were not properly traced in the precompiler, causing us to hit an assert when the classes mentioned in those types where only referenced from a signature and not retained for any other reason. TEST=tests/ffi/native_assets/process_test.dart (dartkp) Closes: https://github.com/dart-lang/sdk/issues/50678 Bug: b/261224444 Change-Id: I84fc880744c2045ea3e2ef4f37df454b80b2faeb Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274387 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-12-12 15:46:33 +00:00
}