languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 14:51:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime/vm/flag_list.h

244 lines
16 KiB
C
Raw Normal View History

Add product mode: - Add PRODUCT define and build mode to gyp configurations. - Add product mode to test harness. - Start to unify list of flags. - Allow flags to be constant for particular build configurations. R=fschneider@google.com Review URL: https://codereview.chromium.org/1663863002 .
2016-02-04 05:10:30 +00:00
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Make header include guards great again i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER This lets us remove a hack from the PRESUBMIT.py script that existed for reasons that are no longer valid, and sets us up to add some presubmit checks for the GN build. R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 07:26:03 +00:00
#ifndef RUNTIME_VM_FLAG_LIST_H_
#define RUNTIME_VM_FLAG_LIST_H_
Add product mode: - Add PRODUCT define and build mode to gyp configurations. - Add product mode to test harness. - Start to unify list of flags. - Allow flags to be constant for particular build configurations. R=fschneider@google.com Review URL: https://codereview.chromium.org/1663863002 .
2016-02-04 05:10:30 +00:00
Allow enabling --causal-async-stacks in AOT. R=asiva@google.com Review-Url: https://codereview.chromium.org/2944483002 .
2017-06-15 18:09:48 +00:00
// Don't use USING_PRODUCT outside of this file.
#if defined(PRODUCT)
#define USING_PRODUCT true
#else
#define USING_PRODUCT false
#endif
Re-land "[vm/kernel/aot] Exclude vmservice_io from "product" AOT snapshots." This reverts commit 17585c42fee27c135381d808810a0c9a02f1030a. The original revision is in Patchset 1. Fixed Tests: python tools/test.py -m debug -c dartkp -r dart_precompiled --strong standalone_2/no_support_service_test python tools/test.py -m product -c precompiler -r dart_precompiled lib_2/isolate/function_send1_test Change-Id: I6af715ee3c080b515c8312357f3d8be6e494747a Reviewed-on: https://dart-review.googlesource.com/59760 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-06-12 15:31:19 +00:00
#if defined(DART_PRECOMPILED_RUNTIME)
constexpr bool kDartPrecompiledRuntime = true;
#else
constexpr bool kDartPrecompiledRuntime = false;
#endif
[vm/bytecode] Bootstrapping VM from bytecode Previously, core snapshot was generated from AST (because --enable-interpreter/--use-bytecode-compiler was not specified when building core snapshot). As the result, CL https://dart.googlesource.com/sdk/+/da8cb470cc94830a98d49532e8d5d1a5b3d80f8b which declared libraries in bytecode also removed bytecode entirely from core snapshot in Dart SDK. This CL enables bytecode by default if --bytecode argument is specified for gn.py. This enables JIT compiler from bytecode (interpreter is still disabled by default but can be enabled using --enable-interpreter). Core snapshot and other snapshots now have bytecode. This change revealed a bunch of bugs which are fixed in this CL: * _Closure fields were treated as unboxing candidates which triggered assertion in LoadFieldTOS in interpreter. * Several places should load class declarations if they are not loaded yet. * Canonicalization of TypeRef objects which are not fully initialized may cause duplicate entries in the hash table of canonical TypeArguments. This triggers assertions when hash table is rehashed. The solution is to avoid canonicalization of non-root recursive types and recursive type arguments. Also, TypeRef::Canonicalize and TypeRef::Hash are reverted to assert and work only if type was set. * Native wrapper classes are eagerly stamped as type-finalized which caused assertion failures when reading their class declarations from bytecode. * When building flow graph for FFI trampolines kernel offset of library (which is now declared in bytecode) was queried. Added special case to Function::KernelDataProgramOffset(). * In interpreter-only mode with simulator (e.g. SIMARM64) if simulator is not called before code is interrupted with stack overflow check, simulator returns get_sp() = 0, which was treated as stack overflow. * test standalone_2/io/platform_resolved_executable_test.dart spawns sub-process but it didn't pass VM options. Change-Id: I81bc4f1a4c6725cfa246a435ebe5d8abe43abc67 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107199 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Régis Crelier <regis@google.com>
2019-06-26 18:25:26 +00:00
#if defined(DART_USE_BYTECODE)
constexpr bool kDartUseBytecode = true;
#else
constexpr bool kDartUseBytecode = false;
#endif
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
// The disassembler might be force included even in product builds so we need
// to conditionally make these into product flags to make the disassembler
// usable in product mode.
#if defined(FORCE_INCLUDE_DISASSEMBLER)
#define DISASSEMBLE_FLAGS(P, R, C, D) \
P(disassemble, bool, false, "Disassemble dart code.") \
P(disassemble_optimized, bool, false, "Disassemble optimized code.") \
P(disassemble_relative, bool, false, "Use offsets instead of absolute PCs")
#else
#define DISASSEMBLE_FLAGS(P, R, C, D) \
R(disassemble, false, bool, false, "Disassemble dart code.") \
R(disassemble_optimized, false, bool, false, "Disassemble optimized code.") \
R(disassemble_relative, false, bool, false, \
"Use offsets instead of absolute PCs")
#endif
Add product mode: - Add PRODUCT define and build mode to gyp configurations. - Add product mode to test harness. - Start to unify list of flags. - Allow flags to be constant for particular build configurations. R=fschneider@google.com Review URL: https://codereview.chromium.org/1663863002 .
2016-02-04 05:10:30 +00:00
// List of all flags in the VM.
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
// Flags can be one of four categories:
Add product mode: - Add PRODUCT define and build mode to gyp configurations. - Add product mode to test harness. - Start to unify list of flags. - Allow flags to be constant for particular build configurations. R=fschneider@google.com Review URL: https://codereview.chromium.org/1663863002 .
2016-02-04 05:10:30 +00:00
// * P roduct flags: Can be set in any of the deployment modes, including in
// production.
// * R elease flags: Generally available flags except when building product.
VM: Separate precompilation-specific code, make flags const. Move optimizations for precompilation into separate file. Remove precompilation-specific code from flow_graph_optimizer.cc. Add precompilation-flags: They are const in the precompiled runtime. Started moving flags to use the new flag-definition macros. Add libdart_lib_precompiled target. Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime) BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1714743002 .
2016-02-23 16:48:08 +00:00
// * pre C ompile flags: Generally available flags except when building product
// or precompiled runtime.
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
// * D ebug flags: Can only be set in debug VMs, which also have C++ assertions
// enabled.
VM: Separate precompilation-specific code, make flags const. Move optimizations for precompilation into separate file. Remove precompilation-specific code from flow_graph_optimizer.cc. Add precompilation-flags: They are const in the precompiled runtime. Started moving flags to use the new flag-definition macros. Add libdart_lib_precompiled target. Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime) BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1714743002 .
2016-02-23 16:48:08 +00:00
//
// Usage:
// P(name, type, default_value, comment)
// R(name, product_value, type, default_value, comment)
// C(name, precompiled_value, product_value, type, default_value, comment)
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
// D(name, type, default_value, comment)
#define FLAG_LIST(P, R, C, D) \
[vm] Fix experimental_unsafe_mode_use_at_your_own_risk mode. Turn it into an isolate specific flag so that Kernel isolate continues to run from app-jit snapshot without trusting any types. Change-Id: I627a40025d53c23586da5a207eb096886ca98bc4 Reviewed-on: https://dart-review.googlesource.com/72040 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-08-30 12:04:37 +00:00
P(experimental_unsafe_mode_use_at_your_own_risk, bool, false, \
"Omit runtime strong mode type checks and disable optimizations based on " \
"types.") \
[VM-GC] Add a flag to abort on allocation failure This is added to help investigate memory usage. By setting an old-space limit with --old-gen-heap-size and setting the new --abort-on-oom it is possible to test whether a program can run in a certain size. Using binary search one can determine what the minimum size is. Without this flag the VM will slow down to a crawl when it tries to exceed its heap limit. R=vegorov@google.com BUG= Review-Url: https://codereview.chromium.org/2995063002 .
2017-09-04 10:32:27 +00:00
P(abort_on_oom, bool, false, \
"Abort if memory allocation fails - use only with --old-gen-heap-size") \
[VM strong mode] Introduce a VM flag --strong modifying the semantics of type checks to strong mode. Note that the patched core library in runtime/lib is not yet strong mode clean. Also, the core library requires type inference to work properly in strong mode. Change-Id: I7b29af708f180eaa9fa95adfb6ec1b0361e2c003 Reviewed-on: https://dart-review.googlesource.com/8382 Reviewed-by: Siva Annamalai <asiva@google.com>
2017-09-27 23:03:23 +00:00
C(async_debugger, false, false, bool, true, \
"Debugger support async functions.") \
[vm] Remove deprecated (and untested) ARMv5 support from the VM Since we have no CQ/CI test coverage of ARMv5 and none of our customers uses it, a breaking change request was made (see issue further down). The breaking change has been approved and a corresponding email has been sent out: https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ This CL removes any armv5 related code from our codebase. Closes https://github.com/dart-lang/sdk/issues/36666 Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-10-23 14:44:33 +00:00
P(background_compilation, bool, true, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"Run optimizing compilation in background") \
[VM generic functions] Remove empty_type_arguments singleton. This empty vector was added in https://codereview.chromium.org/2818273002/ to properly instantiate generic signatures. Later on, the implementation of HasInstantiatedSignature() was improved in https://codereview.chromium.org/2965743002/ making the empty vector unnecessary. However, the implementation of InstantiateFrom() will also need improvement as noted by the added TODO. Change-Id: I042a57b643390c789620b04122084db19ec445ea Reviewed-on: https://dart-review.googlesource.com/13400 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Régis Crelier <regis@google.com>
2017-10-12 15:21:52 +00:00
P(causal_async_stacks, bool, !USING_PRODUCT, "Improved async stacks") \
[vm] Remove code collection. Code collection interacts badly with - warming up compiled code - retaining pre-compiled code - code coverage - hot reload (deopting to an old version of a function) Change-Id: Id269a6c3281e577d4f600f0c158af9e62f6b49ea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99722 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-04-18 20:12:09 +00:00
P(collect_code, bool, false, "Attempt to GC infrequently used code.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
P(collect_dynamic_function_names, bool, true, \
"Collects all dynamic function names to identify unique targets") \
Parallel compaction. Divide the heap by pages into k tasks. Use ThreadBarrier to ensure planning -> sliding and non-stack forwarding -> stack forwarding. Bug: https://github.com/dart-lang/sdk/issues/30978 Change-Id: I2c9fcec0a0794bfea96ca1a0fb509a9f93242b65 Reviewed-on: https://dart-review.googlesource.com/29444 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Erik Corry <erikcorry@google.com>
2017-12-15 01:38:42 +00:00
P(compactor_tasks, int, 2, \
"The number of tasks to use for parallel compaction.") \
[vm/bytecode] Trigger JIT-compilation from interpreter Performance on Richards benchmark (no bytecode in platform, release build): Interpreter (--enable-interpreter --compilation-counter-threshold=-1) Richards(RunTime): 177228.34433333334 us. Interpreter + bytecode compilation with default threshold 10 (--enable-interpreter) Richards(RunTime): 930.8050725919032 us. Varies from run to run, spikes up to 4178.005912317328 (no OSR yet, only background compilation). Bytecode compilation (--use-bytecode-compiler) Richards(RunTime): 830.1371626556016 us Default pipeline: Richards(RunTime): 880.1557113946327 us. Numbers on Richards benchmark (platform with bytecode, release build): Interpreter (--enable-interpreter --compilation-counter-threshold=-1) Richards(RunTime): 354553.6346666667 us. Interpreter + compilation with default threshold 10 (--enable-interpreter) Richards(RunTime): 934.7108855140189 us. Bytecode compilation (--use-bytecode-compiler) Richards(RunTime): 822.74178403949 us. Change-Id: Ic13e9f7c7d98f2930e6de4c4f74bac4d28478249 Reviewed-on: https://dart-review.googlesource.com/75781 Reviewed-by: Zach Anderson <zra@google.com> Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-09-20 20:57:08 +00:00
P(compilation_counter_threshold, int, 10, \
"Function's usage-counter value before interpreted function is compiled, " \
"-1 means never") \
[vm] Remove deprecated (and untested) ARMv5 support from the VM Since we have no CQ/CI test coverage of ARMv5 and none of our customers uses it, a breaking change request was made (see issue further down). The breaking change has been approved and a corresponding email has been sent out: https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ This CL removes any armv5 related code from our codebase. Closes https://github.com/dart-lang/sdk/issues/36666 Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-10-23 14:44:33 +00:00
P(concurrent_mark, bool, true, "Concurrent mark for old generation.") \
P(concurrent_sweep, bool, true, "Concurrent sweep for old generation.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(dedup_instructions, true, bool, false, \
"Canonicalize instructions when precompiling.") \
C(deoptimize_alot, false, false, bool, false, \
"Deoptimizes we are about to return to Dart code from native entries.") \
C(deoptimize_every, 0, 0, int, 0, \
"Deoptimize on every N stack overflow checks") \
R(disable_alloc_stubs_after_gc, false, bool, false, "Stress testing flag.") \
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
DISASSEMBLE_FLAGS(P, R, C, D) \
[vm] Support disassembling snapshot code at runtime for JIT and AOT snapshots. --code-comments should be passed both at compile/training-time and run-time to get comments in the disassembled instructions. The required --disassemble-* flags need only be passed at run-time. Flow-graph printing is not yet supported because we don't save flow-graph like assembly comments. This functionality is excluded from product builds. Change-Id: If35fbb08cff6eae40069f916ecec9c6f589c0cad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124989 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-14 14:09:21 +00:00
R(code_comments, false, bool, false, \
"Include comments into code and disassembly.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(dump_megamorphic_stats, false, bool, false, \
"Dump megamorphic cache statistics") \
R(dump_symbol_stats, false, bool, false, "Dump symbol table statistics") \
Reapply "DWARF and unwind support for AOT assembly output." This reverts commit 8fcdbb4a7f4bc484fdef49422665e74d16770cb6. R=vegorov@google.com Review-Url: https://codereview.chromium.org/2761593002 .
2017-03-20 20:02:41 +00:00
P(dwarf_stack_traces, bool, false, \
"Emit DWARF line number and inlining info" \
"in dylib snapshots and don't symbolize stack traces.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(enable_asserts, false, bool, false, "Enable assert statements.") \
[vm/kernel] Add flag to disable Kernel-based expression compilation. Change-Id: Ibaa2ccd282b467e2b5ecda09fb86620409d7214b Reviewed-on: https://dart-review.googlesource.com/55220 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
2018-05-15 14:55:37 +00:00
P(enable_kernel_expression_compilation, bool, true, \
"Compile expressions with the Kernel front-end.") \
[vm] Enable mirrors in product mode. Allows building a product mode SDK. Fixes https://github.com/dart-lang/sdk/issues/29972 R=zra@google.com Review-Url: https://codereview.chromium.org/2972883002 .
2017-07-12 19:55:55 +00:00
P(enable_mirrors, bool, true, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"Disable to make importing dart:mirrors an error.") \
[vm / library] Foreign function interface prototype Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode. `dart:ffi` is experimental and its API is likely to change in the future. Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13 issue: https://github.com/dart-lang/sdk/issues/34452 Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64 Reviewed-on: https://dart-review.googlesource.com/c/80124 Reviewed-by: Samir Jindel <sjindel@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com>
2019-02-13 12:42:47 +00:00
P(enable_ffi, bool, true, "Disable to make importing dart:ffi an error.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
P(fields_may_be_reset, bool, false, \
"Don't optimize away static field initialization") \
C(force_clone_compiler_objects, false, false, bool, false, \
"Force cloning of objects needed in compiler (ICData and Field).") \
P(getter_setter_ratio, int, 13, \
"Ratio of getter/setter usage used for double field unboxing heuristics") \
P(guess_icdata_cid, bool, true, \
"Artificially create type feedback for arithmetic etc. operations") \
P(huge_method_cutoff_in_tokens, int, 20000, \
"Huge method cutoff in tokens: Disables optimizations for huge methods.") \
[VM] Fix for issue 34888 Rework the idle notification mechanism to not use the global IdleNotifier class as it was resulting in lock inversion issues causing the monitor to be deleted while it could still be required in another thread. The new mechanism wires the idle notification check into the existing message handling loop and uses the 'paused_for_messages_' mechanism to wake up a idle time waiting handler when new messages arrive. Bug: 34888 Change-Id: Ifd75e5cf4c0b6944d586146fe518b9e3e053a76e Reviewed-on: https://dart-review.googlesource.com/c/82705 Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-11-06 22:37:39 +00:00
P(idle_timeout_micros, int, 1000 * kMicrosecondsPerMillisecond, \
Idle notification for isolates running on the thread pool. If a thread pool isolate has not processed a message in FLAG_idle_timeout_micros, run idle tasks. Change-Id: If506d7805eb1213c3d1f9383d835226822012fff Reviewed-on: https://dart-review.googlesource.com/26004 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Zach Anderson <zra@google.com>
2018-01-17 22:01:28 +00:00
"Consider thread pool isolates for idle tasks after this long.") \
P(idle_duration_micros, int, 500 * kMicrosecondsPerMillisecond, \
"Allow idle tasks to run for this long.") \
[vm] DBC is obsolete. Remove dead code. Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-27 18:18:29 +00:00
P(interpret_irregexp, bool, false, "Use irregexp bytecode interpreter") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
P(lazy_dispatchers, bool, true, "Generate dispatchers lazily") \
P(link_natives_lazily, bool, false, "Link native calls lazily") \
R(log_marker_tasks, false, bool, false, \
"Log debugging information for old gen GC marking tasks.") \
[vm] Remove deprecated (and untested) ARMv5 support from the VM Since we have no CQ/CI test coverage of ARMv5 and none of our customers uses it, a breaking change request was made (see issue further down). The breaking change has been approved and a corresponding email has been sent out: https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ This CL removes any armv5 related code from our codebase. Closes https://github.com/dart-lang/sdk/issues/36666 Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-10-23 14:44:33 +00:00
P(marker_tasks, int, 2, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"The number of tasks to spawn during old gen GC marking (0 means " \
"perform all marking on main thread).") \
P(max_polymorphic_checks, int, 4, \
"Maximum number of polymorphic check, otherwise it is megamorphic.") \
P(max_equality_polymorphic_checks, int, 32, \
"Maximum number of polymorphic checks in equality operator,") \
[vm] Reduce maximum new generation size and growth rate. For example, by default 64-bit architectures now grow as 2, 4, 8, 16 instead of 2, 8, 32. This change is to reduce memory usage and maximum minor GC time for Flutter and Fuchsia. It would negatively impact batch applications, which prefer throughput, so the new defaults are overriden by the command-line Dart VM in runtime/bin/main.cc Change-Id: Ie56a7599d4011a629c8c57bd88fec3ee8f277a9f Reviewed-on: https://dart-review.googlesource.com/54305 Commit-Queue: Zach Anderson <zra@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-06-13 20:50:34 +00:00
P(new_gen_semi_max_size, int, (kWordSize <= 4) ? 8 : 16, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"Max size of new gen semi space in MB") \
[vm] Reduce maximum new generation size and growth rate. For example, by default 64-bit architectures now grow as 2, 4, 8, 16 instead of 2, 8, 32. This change is to reduce memory usage and maximum minor GC time for Flutter and Fuchsia. It would negatively impact batch applications, which prefer throughput, so the new defaults are overriden by the command-line Dart VM in runtime/bin/main.cc Change-Id: Ie56a7599d4011a629c8c57bd88fec3ee8f277a9f Reviewed-on: https://dart-review.googlesource.com/54305 Commit-Queue: Zach Anderson <zra@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-06-13 20:50:34 +00:00
P(new_gen_semi_initial_size, int, (kWordSize <= 4) ? 1 : 2, \
"Initial size of new gen semi space in MB") \
[vm] Reland: Move the interpreter under a flag. After this CL, the interpreter is included by default in the JIT VM under the flag --enable-interpreter. Reland with fix to NativeArgument setup in simulator_arm.cc Change-Id: Ib9b4df6eb4d997dfbe361188b8a127828c1d9c6f Reviewed-on: https://dart-review.googlesource.com/74003 Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Zach Anderson <zra@google.com>
2018-09-07 19:25:31 +00:00
P(optimization_counter_threshold, int, 30000, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"Function's usage-counter value before it is optimized, -1 means never") \
[vm] Support optcounter=1 and randomize it for testing. Change-Id: I1d371ca9644a65f8fe9864ac708689c1469da17d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97242 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
2019-04-05 10:15:44 +00:00
R(randomize_optimization_counter, false, bool, false, \
"Randomize optimization counter thresholds on a per-function basis (for " \
"testing).") \
[vm/compiler] Add optimization flag Rationale: See min-design doc. Change-Id: Ic949a01ea2dcc873cf9e6d4d862e159be91da6f9 Reviewed-on: https://dart-review.googlesource.com/c/92161 Reviewed-by: Aart Bik <ajcbik@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
2019-02-06 22:16:12 +00:00
P(optimization_level, int, 2, \
"Optimization level: 1 (favor size), 2 (default), 3 (favor speed)") \
[VM] Removed old space heap size limit for Kernel and Service isolates. Change-Id: Ib19cc5ca22f319e41c21e6553e6228dfe0c34809 Reviewed-on: https://dart-review.googlesource.com/39420 Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-07 00:19:25 +00:00
P(old_gen_heap_size, int, kDefaultMaxOldGenHeapSize, \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
"Max size of old gen heap size in MB, or 0 for unlimited," \
"e.g: --old_gen_heap_size=1024 allows up to 1024MB old gen heap") \
R(pause_isolates_on_start, false, bool, false, \
"Pause isolates before starting.") \
R(pause_isolates_on_exit, false, bool, false, "Pause isolates exiting.") \
R(pause_isolates_on_unhandled_exceptions, false, bool, false, \
"Pause isolates on unhandled exceptions.") \
P(polymorphic_with_deopt, bool, true, \
"Polymorphic calls with deoptimization / megamorphic call") \
P(precompiled_mode, bool, false, "Precompilation compiler mode") \
Print snapshot size in PRODUCT mode as well. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2525063002 .
2016-11-23 22:30:24 +00:00
P(print_snapshot_sizes, bool, false, "Print sizes of generated snapshots.") \
[vm] Add --print-snapshot-sizes-verbose. E.g., Cluster Size Fraction Cumulative Array 1079963 0.206635 0.206635 ObjectPool 1063564 0.203497 0.410132 Function 961383 0.183946 0.594079 Code 802081 0.153466 0.747545 ROData 379720 0.072654 0.820199 Class 185324 0.035459 0.855658 Bug: Change-Id: I948877963b467263d399fa14ef32eedace02d6a5 Reviewed-on: https://dart-review.googlesource.com/19840 Reviewed-by: Siva Chandra <sivachandra@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2017-11-10 00:23:42 +00:00
P(print_snapshot_sizes_verbose, bool, false, \
"Print cluster sizes of generated snapshots.") \
Add --print-benchmarking-metrics to the VM for Golem. R=fschneider@google.com, johnmccutchan@google.com, sortie@google.com Review-Url: https://codereview.chromium.org/2572873003 .
2017-02-01 00:39:19 +00:00
P(print_benchmarking_metrics, bool, false, \
"Print additional memory and latency metrics for benchmarking.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(print_ssa_liveranges, false, bool, false, \
"Print live ranges after allocation.") \
Add --print_stacktrace_at_api_error. Should be helpful in tracking down flutter/flutter#8612. Prefer stack bounds from pthreads when available to be able to see frames below the Dart entry frame. R=johnmccutchan@google.com Review-Url: https://codereview.chromium.org/2813283002 .
2017-04-12 21:09:14 +00:00
R(print_stacktrace_at_api_error, false, bool, false, \
"Attempt to print a native stack trace when an API error is created.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
D(print_variable_descriptors, bool, false, \
"Print variable descriptors in disassembly.") \
Reapply "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, or later through Observatory." Ensure we still start NativeSymbolResolver even if the profiler is off, since it is also used name weak handler finalizer functions and to produce stack traces for crashes. R=bkonyi@google.com Review-Url: https://codereview.chromium.org/2992893002 .
2017-08-09 18:20:55 +00:00
R(profiler, false, bool, false, "Enable the profiler.") \
[Fuchsia] Grab the number of malloc'd bytes from jemalloc This allows us to report the "native heap memory" value in the Observatory for VMs running on Fuchsia. This change also renames the flag --enable-malloc-hooks to --profiler-native-memory to better reflect what the flag does. (In the future we may also want to rename --profiler to --profiler-cpu.) R=rmacnak@google.com Review-Url: https://codereview.chromium.org/2829833003 .
2017-04-19 22:50:59 +00:00
R(profiler_native_memory, false, bool, false, \
"Enable native memory statistic collection.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
P(reorder_basic_blocks, bool, true, "Reorder basic blocks") \
Fix two bugs with async stack traces. 1. A crash when collecting an async stack trace with inlined frames on the stack. 2. A missing source position in an async stack trace. Fixes #29080. R=johnmccutchan@google.com Review-Url: https://codereview.chromium.org/2767483002 .
2017-03-21 16:31:11 +00:00
C(stress_async_stacks, false, false, bool, false, \
"Stress test async stack traces") \
[VM/nnbd] Pass NNBD mode to runtime functions whose semantics depend on it. Runtime functions do not yet implement the NNBD semantics. In a next change, generated code will pass NNBD mode to the runtime. Declare one new VM flags: --strong-non-nullable-type-checks Change-Id: I050a468e4a6b665ce46c345bafba04a947cf7cb0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124105 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2019-11-16 02:49:48 +00:00
P(strong_non_nullable_type_checks, bool, false, \
"Enable strong non-nullable type checking mode.") \
[VM/AOT] Turn bare instructions on by default Issue https://github.com/dart-lang/sdk/issues/33274 Change-Id: I44850d5906143a53d6b1872eb729364c3a509f9a Reviewed-on: https://dart-review.googlesource.com/c/91060 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2019-01-25 10:25:18 +00:00
P(use_bare_instructions, bool, true, "Enable bare instructions mode.") \
[vm/concurrency] Split up IsolateReloadContext into IsolateReloadContext/IsolateGroupReloadContext Similar to the split of ClassTable into ClassTable/SharedClassTable, this CL splits up the IsolateReloadContext into: * IsolateGroupReloadContext: Consists of reload-related information across all isolates. The [Reload()] method is split up in phases that are performed on all isolates before the next phase is started. => This allows each isolate to add reasons for rolling back, if no reasons are found the reload will be accepted atomically. * IsolateReloadContext: Constists of reload-related information for a particular isolate (e.g. mappings of old to new classes) The assumption is that all isolates have the same source (and therefore the same libraries). For certain things, e.g. discovering which libraries changed, it is necessary to examine the object store. We use the first isolate in a group (but could use any of them) to do so, since the isolate group does not have this information atm. This is a preparation CL for supporting hot-reloading multiple isolates within one isolate group. Though the support in this CL stays at having only a single isolate in a group. => This CL turns off FLAG_enable_isolate_groups in JIT mode. Issue https://github.com/dart-lang/sdk/issues/36097 Change-Id: I7f4d536d4f5ab4a2a73fb0c7618ba967c9b77234 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123254 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
2019-11-15 14:08:45 +00:00
P(enable_isolate_groups, bool, kDartPrecompiledRuntime, \
"Enable isolate group support.") \
[vm] Add --show-invisible-isolates. Useful for profiling the vm-service and kernel-service isolates. Bug: https://github.com/dart-lang/sdk/issues/38553 Change-Id: I9cc562b5089ad01a5f797799d1105a4a8cf910e0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118650 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-09-25 21:41:55 +00:00
P(show_invisible_frames, bool, false, \
"Show invisible frames in stack traces.") \
R(show_invisible_isolates, false, bool, false, \
"Show invisible isolates in the vm-service.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(support_disassembler, false, bool, true, "Support the disassembler.") \
R(support_il_printer, false, bool, true, "Support the IL printer.") \
C(support_reload, false, false, bool, true, "Support isolate reload.") \
R(support_service, false, bool, true, "Support the service protocol.") \
D(trace_cha, bool, false, "Trace CHA operations") \
[vm] Dynamically track exactness of the field's static type on X64. We say that field's static type G<T0, ..., Tn> is exact if for any value that can be loaded from this field, its runtime type T is such that T at G has type arguments exactly equal to <T0, ..., Tn>. Know if field's static type is exact allows us to apply optimizations that require knowing type arguments e.g. - we can fold o.f.:type_arguments to a constant value if we know that o.f is trivially exact; - for method invocations o.f.m(...) we can skip argument type checks on the callee if we know that o.f is invariant (this optimization will be enabled once multiple entry points CLs will land). Bug: https://github.com/dart-lang/sdk/issues/31798 Change-Id: Id565046d45a842625d41feb002b65db48451034c Reviewed-on: https://dart-review.googlesource.com/69969 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-08-17 13:22:02 +00:00
R(trace_field_guards, false, bool, false, "Trace changes in field's cids.") \
[vm] Code size reductions: - Remove dead Isolate::IsTopLevelParsing. - Remove dead TraceFunctionEntry/Exit. - Migrate more tracing flags to flag_list.h to allow code elimination in non-debug modes. - Require an explicit Zone parameter for CheckedHandles. - Remove side-effects from RuntimeEntry constructor. out/ProductX64/exe.stripped/dart_precompiled_runtime 4063464 -> 4046952 (-16k) Change-Id: Iffd3de25a03d2354cdecf2d79aa761c33ab08bd3 Reviewed-on: https://dart-review.googlesource.com/c/83120 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-11-08 02:02:39 +00:00
D(trace_ic, bool, false, "Trace IC handling") \
D(trace_ic_miss_in_optimized, bool, false, \
"Trace IC miss in optimized code") \
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32. Saves about a megabyte on the size of the precompiled runtime VM. Next step will be to eliminate the assemblers and code stubs as well. This requires some more disentangling. Until then, the X64 build still includes the compiler, since its assembler has a dependency on locations.cc, which is part of the compiler. BUG= https://github.com/dart-lang/sdk/issues/30045 R=rmacnak@google.com, zra@google.com Review-Url: https://codereview.chromium.org/2960413002 .
2017-07-11 10:01:47 +00:00
C(trace_irregexp, false, false, bool, false, "Trace irregexps.") \
[vm] Code size reductions: - Remove dead Isolate::IsTopLevelParsing. - Remove dead TraceFunctionEntry/Exit. - Migrate more tracing flags to flag_list.h to allow code elimination in non-debug modes. - Require an explicit Zone parameter for CheckedHandles. - Remove side-effects from RuntimeEntry constructor. out/ProductX64/exe.stripped/dart_precompiled_runtime 4063464 -> 4046952 (-16k) Change-Id: Iffd3de25a03d2354cdecf2d79aa761c33ab08bd3 Reviewed-on: https://dart-review.googlesource.com/c/83120 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-11-08 02:02:39 +00:00
D(trace_intrinsified_natives, bool, false, \
"Report if any of the intrinsified natives are called") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
D(trace_isolates, bool, false, "Trace isolate creation and shut down.") \
D(trace_handles, bool, false, "Traces allocation of handles.") \
D(trace_kernel_binary, bool, false, "Trace Kernel reader/writer.") \
[vm] Code size reductions: - Remove dead Isolate::IsTopLevelParsing. - Remove dead TraceFunctionEntry/Exit. - Migrate more tracing flags to flag_list.h to allow code elimination in non-debug modes. - Require an explicit Zone parameter for CheckedHandles. - Remove side-effects from RuntimeEntry constructor. out/ProductX64/exe.stripped/dart_precompiled_runtime 4063464 -> 4046952 (-16k) Change-Id: Iffd3de25a03d2354cdecf2d79aa761c33ab08bd3 Reviewed-on: https://dart-review.googlesource.com/c/83120 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-11-08 02:02:39 +00:00
D(trace_natives, bool, false, "Trace invocation of natives") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
D(trace_optimization, bool, false, "Print optimization details.") \
R(trace_profiler, false, bool, false, "Profiler trace") \
D(trace_profiler_verbose, bool, false, "Verbose profiler trace") \
[vm] Code size reductions: - Remove dead Isolate::IsTopLevelParsing. - Remove dead TraceFunctionEntry/Exit. - Migrate more tracing flags to flag_list.h to allow code elimination in non-debug modes. - Require an explicit Zone parameter for CheckedHandles. - Remove side-effects from RuntimeEntry constructor. out/ProductX64/exe.stripped/dart_precompiled_runtime 4063464 -> 4046952 (-16k) Change-Id: Iffd3de25a03d2354cdecf2d79aa761c33ab08bd3 Reviewed-on: https://dart-review.googlesource.com/c/83120 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-11-08 02:02:39 +00:00
D(trace_runtime_calls, bool, false, "Trace runtime calls.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
D(trace_ssa_allocator, bool, false, "Trace register allocation over SSA.") \
[VM] Enable optimizations based on strong mode types Strong mode types are queried from: * Return types of interface targets of instance calls. * Return types of static calls. * Types of instance and static fields. * Types of local variables (for initial types of phis). The strong mode types are used to specialize int and double operations and optimize 'is' checks. https://github.com/dart-lang/sdk/issues/30480 Change-Id: I2302509f396eacfcab8ed41e3f50e8c74dd662fd Reviewed-on: https://dart-review.googlesource.com/30386 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-12-19 19:23:22 +00:00
P(trace_strong_mode_types, bool, false, \
"Trace optimizations based on strong mode types.") \
[vm] Code size reductions: - Remove dead Isolate::IsTopLevelParsing. - Remove dead TraceFunctionEntry/Exit. - Migrate more tracing flags to flag_list.h to allow code elimination in non-debug modes. - Require an explicit Zone parameter for CheckedHandles. - Remove side-effects from RuntimeEntry constructor. out/ProductX64/exe.stripped/dart_precompiled_runtime 4063464 -> 4046952 (-16k) Change-Id: Iffd3de25a03d2354cdecf2d79aa761c33ab08bd3 Reviewed-on: https://dart-review.googlesource.com/c/83120 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-11-08 02:02:39 +00:00
D(trace_type_checks, bool, false, "Trace runtime type checks.") \
D(trace_patching, bool, false, "Trace patching of code.") \
D(trace_optimized_ic_calls, bool, false, \
"Trace IC calls in optimized code.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
D(trace_zones, bool, false, "Traces allocation sizes in the zone.") \
P(truncating_left_shift, bool, true, \
"Optimize left shift to truncate if possible") \
[vm/bytecode] Bootstrapping VM from bytecode Previously, core snapshot was generated from AST (because --enable-interpreter/--use-bytecode-compiler was not specified when building core snapshot). As the result, CL https://dart.googlesource.com/sdk/+/da8cb470cc94830a98d49532e8d5d1a5b3d80f8b which declared libraries in bytecode also removed bytecode entirely from core snapshot in Dart SDK. This CL enables bytecode by default if --bytecode argument is specified for gn.py. This enables JIT compiler from bytecode (interpreter is still disabled by default but can be enabled using --enable-interpreter). Core snapshot and other snapshots now have bytecode. This change revealed a bunch of bugs which are fixed in this CL: * _Closure fields were treated as unboxing candidates which triggered assertion in LoadFieldTOS in interpreter. * Several places should load class declarations if they are not loaded yet. * Canonicalization of TypeRef objects which are not fully initialized may cause duplicate entries in the hash table of canonical TypeArguments. This triggers assertions when hash table is rehashed. The solution is to avoid canonicalization of non-root recursive types and recursive type arguments. Also, TypeRef::Canonicalize and TypeRef::Hash are reverted to assert and work only if type was set. * Native wrapper classes are eagerly stamped as type-finalized which caused assertion failures when reading their class declarations from bytecode. * When building flow graph for FFI trampolines kernel offset of library (which is now declared in bytecode) was queried. Added special case to Function::KernelDataProgramOffset(). * In interpreter-only mode with simulator (e.g. SIMARM64) if simulator is not called before code is interrupted with stack overflow check, simulator returns get_sp() = 0, which was treated as stack overflow. * test standalone_2/io/platform_resolved_executable_test.dart spawns sub-process but it didn't pass VM options. Change-Id: I81bc4f1a4c6725cfa246a435ebe5d8abe43abc67 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107199 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Régis Crelier <regis@google.com>
2019-06-26 18:25:26 +00:00
P(use_bytecode_compiler, bool, kDartUseBytecode, "Compile from bytecode") \
[vm, gc] Remove the evacuating compactor. This was a temporary measure to verify the VM could handle moving old-space objects before we had the sliding compactor. Bug: https://github.com/dart-lang/sdk/issues/30978 Change-Id: I4ffec413918481c0af4828d126930455f620935d Reviewed-on: https://dart-review.googlesource.com/22663 Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Erik Corry <erikcorry@google.com>
2017-11-22 18:12:02 +00:00
P(use_compactor, bool, false, "Compact the heap during old-space GC.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
P(use_cha_deopt, bool, true, \
"Use class hierarchy analysis even if it can cause deoptimization.") \
[vm] DBC is obsolete. Remove dead code. Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-27 18:18:29 +00:00
P(use_field_guards, bool, true, "Use field guards and track field types") \
CoreJIT snapshots without training. Only include OSR and field guards in the features descriptor for JIT code to avoid gen_snapshot and dart having different default values. Disabled since core snapshots with code break tests with non-default flags for type checks, assertions, strict errors, OSR, or field guards. R=zra@google.com Review-Url: https://codereview.chromium.org/2902313004 .
2017-05-31 20:49:09 +00:00
C(use_osr, false, true, bool, true, "Use OSR") \
[VM] Enable optimizations based on strong mode types Strong mode types are queried from: * Return types of interface targets of instance calls. * Return types of static calls. * Types of instance and static fields. * Types of local variables (for initial types of phis). The strong mode types are used to specialize int and double operations and optimize 'is' checks. https://github.com/dart-lang/sdk/issues/30480 Change-Id: I2302509f396eacfcab8ed41e3f50e8c74dd662fd Reviewed-on: https://dart-review.googlesource.com/30386 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-12-19 19:23:22 +00:00
P(use_strong_mode_types, bool, true, "Optimize based on strong mode types.") \
Reland "Remove fields from Isolate in Product mode" In my reordering of the fields in Isolate, I omitted the initialization of a few fields in the constroctor. This CL will reland the change with the initialization added back. R=danunez@google.com, rmacnak@google.com Review-Url: https://codereview.chromium.org/2983403002 .
2017-07-25 20:24:28 +00:00
R(verbose_gc, false, bool, false, "Enables verbose GC.") \
R(verbose_gc_hdr, 40, int, 40, "Print verbose GC header interval.") \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
R(verify_after_gc, false, bool, false, \
"Enables heap verification after GC.") \
R(verify_before_gc, false, bool, false, \
"Enables heap verification before GC.") \
[vm/precomp] Reduce the size of slow-path code in precompiled mode. The stub code for calling into the runtime is now responsible for saving any live registers. Since it doesn't know which registers are live (it's shared across many safepoints), it saves all the registers. The stackmaps and environments for safepoints which call this stub are extended to cover the stack slots in the stub's frame which correspond to registers which are actually live at the safepoint. Currently this is only supported in precompiled X64 for the `CheckNull` slow-path. By creating a separate stub for the CheckNull slow path we are able to eliminate the size overhead of preparing arguments for the runtime call stub, and reduce the slow-path size on X64 to 1 instruction. # Test Plan The stackmap for a safepoint in the `CheckNull` slowpath is only used when handling the exception causes a GC, which is extremely unlikely. To induce this, we add a flag to force this behavior in debug-mode and a test which exercises this. The rest of the changes inherit existing coverage. Change-Id: I3d8f2a7c3560c432599344d7420d42ddbee7a89d Reviewed-on: https://dart-review.googlesource.com/59660 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
2018-06-15 15:59:05 +00:00
P(enable_slow_path_sharing, bool, true, "Enable sharing of slow-path code.") \
P(shared_slow_path_triggers_gc, bool, false, \
[vm] Multiple entrypoints: backend/assembler support. Test Plan: Will be tested by following revisions which introduce optimizations that invoke the new entrypoint. Change-Id: I56d714bceb92c44a13c46d52457154b82577aa8c Cq-Include-Trybots: luci.dart.try:vm-kernel-win-release-x64-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try Reviewed-on: https://dart-review.googlesource.com/67345 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-08-16 17:15:32 +00:00
"TESTING: slow-path triggers a GC.") \
[VM] Introduce function and osr entrypoints to the VM's IR Similar to how we treat catch entry instructions, this cl adds new function and osr entry instructions. The [FunctionEntry] and [OsrEntry] - just like [CatchBlockEntry] - have now their own initial definitions. The [GraphEntry] has only initial definitions for constants. Explicit phis are inserted for all parameter / special parameter instructions if necessary. Future work is: a) Minimize parallel moves due to the phis on parameters b) Cleanup frame setup: Move it entirely into FunctionEntry/CatchEntry (instead of the split version we have now) Fixes https://github.com/dart-lang/sdk/issues/34435 Fixes https://github.com/dart-lang/sdk/issues/34287 Change-Id: Iefa0280a709716f748d6fb0523b8d0f4d8de1fec Reviewed-on: https://dart-review.googlesource.com/c/74782 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-15 13:02:51 +00:00
P(enable_multiple_entrypoints, bool, true, \
[vm] Multiple entrypoints: backend/assembler support. Test Plan: Will be tested by following revisions which introduce optimizations that invoke the new entrypoint. Change-Id: I56d714bceb92c44a13c46d52457154b82577aa8c Cq-Include-Trybots: luci.dart.try:vm-kernel-win-release-x64-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try Reviewed-on: https://dart-review.googlesource.com/67345 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-08-16 17:15:32 +00:00
"Enable multiple entrypoints per-function and related optimizations.") \
[VM] Ensure inferred types are set on parameters Now parameter instructions are part of FunctionEntry/OsrEntry/CatchEntry instead of GraphEntry. Change-Id: I27338aaf1d2a9cc3ca61a3817bbb929d0ea6627c Reviewed-on: https://dart-review.googlesource.com/c/80201 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-16 16:09:48 +00:00
P(enable_testing_pragmas, bool, false, \
Re-land "[vm] Skip bounds checks on invocation of partially instantiated closures." This removes the part of the CL which contained asserts about the syntactic form of the partial instantiation target. Reviewed-on: https://dart-review.googlesource.com/72460 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Change-Id: I73733310795cd2c98b33bc641e769531d88a636a Reviewed-on: https://dart-review.googlesource.com/73580 Reviewed-by: Samir Jindel <sjindel@google.com>
2018-09-06 18:10:27 +00:00
"Enable magical pragmas for testing purposes. Use at your own risk!") \
R(eliminate_type_checks, true, bool, true, \
[vm] Reland: Move the interpreter under a flag. After this CL, the interpreter is included by default in the JIT VM under the flag --enable-interpreter. Reland with fix to NativeArgument setup in simulator_arm.cc Change-Id: Ib9b4df6eb4d997dfbe361188b8a127828c1d9c6f Reviewed-on: https://dart-review.googlesource.com/74003 Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Zach Anderson <zra@google.com>
2018-09-07 19:25:31 +00:00
"Eliminate type checks when allowed by static type analysis.") \
[vm] Fix issue with debugging generated code within RR. Change-Id: Ifa13d6695624158367b0aa1baadd6ca41e13197f Reviewed-on: https://dart-review.googlesource.com/c/77880 Auto-Submit: Samir Jindel <sjindel@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-10-03 14:09:17 +00:00
P(enable_interpreter, bool, false, "Enable interpreting kernel bytecode.") \
Re-land "[vm] Prevent access to non-annotated members through native API." Two fixes: - Make entrypoints_verification_test work on configurations where CFE compilation is separate from execution. - Add missing entry-point annotation for Windows. The original revision is in patchset 1. Change-Id: I6c4b52b1bae7bc730546dad6a3e31d8625f850b1 Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/90942 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2019-01-29 15:10:34 +00:00
D(support_rr, bool, false, "Support running within RR.") \
P(verify_entry_points, bool, false, \
"Throw API error on invalid member access throuh native API. See " \
"entry_point_pragma.md")
Remove more feature in product mode - Remove Timeline. - Remove more vmservice code. - Remove AST printing. - Remove IL printing. - Remove profiler. - Remove thread interrupter. - Remove disassembler. - Remove Library::CheckFunctionFingerprints. - Update test status files for product mode. Size of dart_bootstrap before: 5287631 Size of dart_bootstrap after: 5112783 Reduction in size: 174848 bytes. Total reduction in size (382734 + 174848): 557582 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1678203002 .
2016-02-09 16:45:32 +00:00
[VM/AOT] Initialize global VM flags by reading them from vm-isolate snapshots Issue https://github.com/dart-lang/sdk/issues/33274 Change-Id: I2dca1fb9a8807294fb756ea796bb7560bb6d17cc Reviewed-on: https://dart-review.googlesource.com/c/90221 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-01-23 09:49:46 +00:00
// List of VM-global (i.e. non-isolate specific) flags.
//
// The value used for those flags at snapshot generation time needs to be the
// same as during runtime.
//
// Usage:
[SDK] Adds disasm. flags for FORCE_INCLUDE_DISASSEMBLER. This CL enables passing --disassemble to e.g. a product mode gen_snapshot which used to not have the flag even when the disasm. was forcefully included. This CL also: - Fixes numerous typos: marco -> macro. - Reorders the _four_ types of flags in order of strictness. Change-Id: I8e3ef75ea0a748a6af5fa48cf289a57beeb51148 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125404 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-11-18 10:11:38 +00:00
// V(name, command-line-flag-name)
[VM/AOT] Initialize global VM flags by reading them from vm-isolate snapshots Issue https://github.com/dart-lang/sdk/issues/33274 Change-Id: I2dca1fb9a8807294fb756ea796bb7560bb6d17cc Reviewed-on: https://dart-review.googlesource.com/c/90221 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-01-23 09:49:46 +00:00
#define VM_GLOBAL_FLAG_LIST(V) \
V(use_bare_instructions, FLAG_use_bare_instructions)
Make header include guards great again i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER This lets us remove a hack from the PRESUBMIT.py script that existed for reasons that are no longer valid, and sets us up to add some presubmit checks for the GN build. R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 07:26:03 +00:00
#endif // RUNTIME_VM_FLAG_LIST_H_
Reference in a new issue Copy permalink