languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:09:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime/vm/bootstrap_natives.h

489 lines
36 KiB
C
Raw Normal View History

Add support for malformed types and postpone some related errors from compile time to execution time. Still to do (once spec is clarified): - properly handle generic type bounds errors - properly handle 'instance of' type checks involving malformed types - fix bad tests Review URL: https://chromiumcodereview.appspot.com//9515011 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4732 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 02:14:18 +00:00
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Make header include guards great again i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER This lets us remove a hack from the PRESUBMIT.py script that existed for reasons that are no longer valid, and sets us up to add some presubmit checks for the GN build. R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 07:26:03 +00:00
#ifndef RUNTIME_VM_BOOTSTRAP_NATIVES_H_
#define RUNTIME_VM_BOOTSTRAP_NATIVES_H_
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
#include "vm/native_entry.h"
// bootstrap dart natives used in the core dart library.
namespace dart {
// List of bootstrap native entry points used in the core dart library.
Reland "Scaffolding for dart:wasm" This reverts commit 9198813a553c6ce230c8c545d33fbad14ffef340. Reason for revert: Relanding with a fix Original change's description: > Revert "Scaffolding for dart:wasm" > > This reverts commit f39a3f188e3bd259d4d7e41c48516e507c1303f1. > > Reason for revert: https://golem.corp.goog/BuildInfo?target=flutter-profile&machine-type=android-armv7&revision=84750 > > Original change's description: > > Scaffolding for dart:wasm > > > > This CL doesn't have any tests because it's just boilerplate. I'll > > add a test in the follow up CLs where I add actual functionality. > > > > Bug: https://github.com/dart-lang/sdk/issues/37882 > > Change-Id: I47c81f5f1be724f8226e756ba5d01880a45f1ac7 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112841 > > Reviewed-by: Siva Annamalai <asiva@google.com> > > Reviewed-by: Liam Appelbe <liama@google.com> > > Commit-Queue: Liam Appelbe <liama@google.com> > > TBR=asiva@google.com,liama@google.com > > Change-Id: I0fd0f29d66a07fc29e840ddaec2d4161c8d599cb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: https://github.com/dart-lang/sdk/issues/37882 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114044 > Reviewed-by: Liam Appelbe <liama@google.com> > Commit-Queue: Liam Appelbe <liama@google.com> TBR=asiva@google.com,liama@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: https://github.com/dart-lang/sdk/issues/37882 Change-Id: Idb43cbd3a0521776ac420bfef91c8a9a4362f18e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114757 Reviewed-by: Liam Appelbe <liama@google.com> Commit-Queue: Liam Appelbe <liama@google.com>
2019-08-28 23:11:21 +00:00
// V(function_name, argument_count)
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
#define BOOTSTRAP_NATIVE_LIST(V) \
Debugger support for step-into async and async* functions. - [x] Support stepping into an async function. - [x] Support stepping into the async generator in an await for loop. - [x] Unit test for async function. - [x] Unit test for async* function. BUG= R=asiva@google.com, rmacnak@google.com Review-Url: https://codereview.chromium.org/2768103002 .
2017-03-24 14:56:50 +00:00
V(AsyncStarMoveNext_debuggerStepCheck, 1) \
Move _fatal to dart:async The function _fatal is only used in dart:async. Change it from a public function of dart:_internal, which can be invoked via mirrors, into a private function of dart:async. R=rmacnak@google.com Review-Url: https://codereview.chromium.org/2684963004 .
2017-02-20 10:52:52 +00:00
V(DartAsync_fatal, 1) \
Change == into an instance call to allow polymorphic inlining of ==. In unoptimized code equality is now just another instance call. The optimizer replaces it with a specialized implementation based on static type information and type feedback. Many of the manual optimizations of == in the optimizer are now just handled by the generic inliner, plus polymorphic inlining of == calls is now possible. This also eliminates the need for a lot of duplicated code in the backend. I adapted the inlining heuristics to compensate for the slightly larger inital flow graph size. Review URL: https://codereview.chromium.org//27307005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29800 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 11:32:52 +00:00
V(Object_equals, 2) \
Reland r24563 and r24564 with fixes cumbersome API leading to leaks. - Add a WeakTable to the VM. This is used to remember the native peers registered through the Dart C API as well as assigning identity hashcodes to objects when needed. - Use the hashcode to lookup entries in the Expando. Review URL: https://codereview.chromium.org//18826007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24822 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 21:41:05 +00:00
V(Object_getHash, 1) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(Object_toString, 1) \
- Implement first class types in the VM. - Make AbstractType a subclass of Instance and map it and its subclasses to private Dart classes in dart:core implementing the Type interface. - Avoid dispatching through statics in Object if not strictly needed. Review URL: https://codereview.chromium.org//10979058 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12981 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 21:19:00 +00:00
V(Object_runtimeType, 1) \
Reland "Recognize and optimize a.runtimeType == b.runtimeType pattern." This relands commit f4ec20abac2286604565e9d5a6d1d744849c964d. BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/2465793003 .
2016-11-01 15:49:02 +00:00
V(Object_haveSameRuntimeType, 2) \
[VM/nnbd] Remove propagation of library mode to runtime after spec change. On 1/27/20, the nnbd specification changed weak and strong mode instance checks to make them behave uniformly across legacy and opted-in libraries. Therefore, it is not necessary anymore to propagate the library mode in generated code to the runtime. Change-Id: I42d3ddc6e9a921899aeac21be6374c7893a6d27c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138111 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Régis Crelier <regis@google.com>
2020-03-03 20:30:32 +00:00
V(Object_instanceOf, 4) \
Made simple instance-of checks fast for unoptimized code. This change makes dart2js 15% faster when compiling 60KLOC. 15sec -> 13sec. BUG= R=regis@google.com Review URL: https://codereview.chromium.org/2147123002 .
2016-07-14 18:11:17 +00:00
V(Object_simpleInstanceOf, 2) \
Implement Function.apply in vm (issue 5670). Fix a closure parameter count check bug (unveiled by an apply test). Review URL: https://codereview.chromium.org//11564029 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16175 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 19:04:01 +00:00
V(Function_apply, 2) \
Remove signature classes from the VM. They were used as the class of closure instances and as the type class of function types. All closure instances now have class _Closure and function types are represented by a new class FunctionType extending AbstractType. Fix issue 24567 and add regression test. R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/1584223006 .
2016-01-20 00:32:59 +00:00
V(Closure_equals, 2) \
Reapply "Improve hashCode for closure objects" with fixes. This CL includes the following fixes: * Fix for incorrect non-nullable assumption about _Closure._hash field. * Add error handling into BecomeMapTraits::Hash. * Correct assertions for validating layout of Closure objects. * Add identityHashCode to the list of VM entry points in precompiler. Closes #30211. Original code review: https://codereview.chromium.org/2983823002/ Original CL description: This performance improvement is inspired by Flutter listeners stored in the HashSet (see ObserverList) and frequently checked using HashSet.contains(). If there are many such listeners and they are implicit instance closures (for example, created by 'new Listenable.merge(...)'), HashSet.contains() becomes very slow. It spends a lot of time in Closure_equals native method due to hash collisions between closure objects with same function but different receivers. This CL improves hashCode() calculation for implicit instance closures by mixing function hashcode with identity hashcode of the receiver. For explicit closures and static implicit closures hashCode() is improved by using identityHashCode() of a closure object. Also, hashcode is calculated once and cached in each closure instance. The size of a closure instance doesn't grow up because there was unused word-size padding both on 32-bit and 64-bit architectures. The execution time of the following micro-benchmark is reduced from 47665ms to 135ms on my Linux/x64 box. ------------------------------------- import "dart:collection"; class Foo { int _a; Foo(this._a); void bar() {} } main() { HashSet hs = new HashSet(); for (int i = 0; i < 1000; ++i) { hs.add(new Foo(i).bar); } var watch = new Stopwatch()..start(); for (int i = 0; i < 1000; ++i) { for (var c in hs) { hs.contains(c); } } int time = watch.elapsedMilliseconds; print("Time: ${time}ms\n"); } ------------------------------------- R=zra@google.com Review-Url: https://codereview.chromium.org/2988493002 .
2017-07-20 22:22:15 +00:00
V(Closure_computeHash, 1) \
- Implement first class types in the VM. - Make AbstractType a subclass of Instance and map it and its subclasses to private Dart classes in dart:core implementing the Type interface. - Avoid dispatching through statics in Object if not strictly needed. Review URL: https://codereview.chromium.org//10979058 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12981 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 21:19:00 +00:00
V(AbstractType_toString, 1) \
[VM] Intrinsify Type.hashCode This CL optimizes Type.hashCode similarly to String.hashCode, by introducing intrinsic version of hashCode calculation which uses hashcode stored in Type instance. This is important for Flutter's .of pattern, which heavily uses Maps with Type keys. Results on Flutter stocks/build_bench.dart microbenchmark: Before: 4906 µs After: 4751 µs (minimum of 5 runs, using tip of Flutter and Flutter engine) Issue: https://github.com/dart-lang/sdk/issues/31011 Issue: https://github.com/flutter/flutter/issues/11572 Change-Id: Ifbaf721050007db49bbd969dc669d070f4ce839e Reviewed-on: https://dart-review.googlesource.com/12622 Reviewed-by: Zach Anderson <zra@google.com>
2017-10-10 23:46:09 +00:00
V(Type_getHashCode, 1) \
[VM/nnbd] Implement syntactic type equality. Legacy types are considered equal to their non-nullable variant. Type hash is modified to be consistent with the new definition. Change-Id: If90f7f13cf77e519d5b90b57d9dbf4988f71be13 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126283 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2019-12-09 18:18:59 +00:00
V(Type_equality, 2) \
[VM/runtime] Decouple representation of function signatures from Function objects. This fixes issue https://github.com/dart-lang/sdk/issues/43088 This CL improves on https://dart-review.googlesource.com/c/sdk/+/166920 by keeping the names of type parameters. See go/dart-vm-signatures for motivation for this change. TEST=existing suites Change-Id: Ia82f1d322f72d07b2fb253cf914f9b868025c71e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176981 Reviewed-by: Ryan Macnak <rmacnak@google.com>
2021-01-07 23:45:37 +00:00
V(FunctionType_getHashCode, 1) \
V(FunctionType_equality, 2) \
Reland "[vm] Check prefix.loadLibrary is called and returns before prefix members are used." This reverts commit 9a87cf91744975e4c6d305d635697fa76ed2c0b7. Reason for revert: Broken test disabled Original change's description: > Revert "[vm] Check prefix.loadLibrary is called and returns before prefix members are used." > > This reverts commit b0484ecbde5e09b0addf73bab016ac988800d888. > > Reason for revert: timeouts on Flutter integration tests > (https://github.com/dart-lang/sdk/issues/42350). > > Original change's description: > > [vm] Check prefix.loadLibrary is called and returns before prefix members are used. > > > > Restore checks against reloading a library with deferred prefixes. > > > > No loading is actually deferred. > > > > Bug: https://github.com/dart-lang/sdk/issues/26878 > > Bug: https://github.com/dart-lang/sdk/issues/41974 > > Change-Id: Iec2662de117453d596cca28dd9481a9751091ce9 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149613 > > Commit-Queue: Ryan Macnak <rmacnak@google.com> > > Reviewed-by: Alexander Markov <alexmarkov@google.com> > > Reviewed-by: Siva Annamalai <asiva@google.com> > > TBR=rmacnak@google.com,alexmarkov@google.com,asiva@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: https://github.com/dart-lang/sdk/issues/26878, https://github.com/dart-lang/sdk/issues/41974 > Change-Id: I78709650e91d206b84a8ddd9171ef66d6cf1b008 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151169 > Reviewed-by: Alexander Markov <alexmarkov@google.com> > Commit-Queue: Alexander Markov <alexmarkov@google.com> TBR=rmacnak@google.com,alexmarkov@google.com,asiva@google.com # Not skipping CQ checks because this is a reland. Bug: https://github.com/dart-lang/sdk/issues/26878, https://github.com/dart-lang/sdk/issues/41974 Change-Id: Ife76bd51db65ca58e08655a9b8406c8ca483447f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151326 Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-06-16 21:11:40 +00:00
V(LibraryPrefix_isLoaded, 1) \
V(LibraryPrefix_setLoaded, 1) \
[vm] Initial implementation of deferred loading. (Assignment of libraries to loading units is already done in the kernel generation step.) After compiling and before serializing, we walk the program and for each Code we assign its Instructions, CodeSourceMap and CompressedStackMap to the loading unit of that Code's defining library. Deduplication may cause Instructions, CodeSourceMaps and CompressedStackMaps to belong to more than one loading unit; in this case the objects are assigned to the root loading unit. Later they can be more precisely assigned to the dominating loading unit. All objects except some Instructions, CodeSourceMaps and CompressedStackMaps belong to the root loading unit's snapshot. This snapshot is written like an unsplit snapshot, except that when serializing Code, we will write a reference to a stub or null when the Code's Instructions, CodeSourceMap or CompressedStackMap belongs to a non-root loading unit. The snapshots of non-root loading units contain these deferred objects and references to the corresponding Code objects to patch. The types of objects we defer (Instructions, CodeSourceMaps and CompressedStackMaps) usually represent 70+% of the snapshot size. Bare instructions mode must be disabled when splitting because we cannot have PC-relative calls between loading units. Later we can re-enable this for calls within loading units. Broken: Compactor probably crashes we can now have an unbounded number of image pages and the compactor assumes a fixed number. Embedder's guide: At compile-time, gen_snapshot should be passed --loading_unit_manifest with a path, which will enable splitting and output a mapping from loading unit ids to snapshot output paths. At runtime, sometime during isolate startup, an embedder should call Dart_SetDeferredLoadHandler, probably near an existing call to Dart_SetLibraryTagHandler. The callback is given a loading unit id, and should eventually call Dart_DeferredLoadComplete[Error]. Bug: https://github.com/dart-lang/sdk/issues/41974 Change-Id: Ib597eb87c8cd634416d5ee1f00629c5550aebb00 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152427 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-07-17 19:29:47 +00:00
V(LibraryPrefix_loadingUnit, 1) \
V(LibraryPrefix_issueLoad, 1) \
Implement a native identical function in the VM. Returns true if objects are the same instance. Adds an identical closure test (disabled for dart2js pending https://chromiumcodereview.appspot.com/11612022/). BUG=7378 Review URL: https://codereview.chromium.org//11613003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16461 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-22 00:12:35 +00:00
V(Identical_comparison, 2) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(Integer_bitAndFromInteger, 2) \
V(Integer_bitOrFromInteger, 2) \
V(Integer_bitXorFromInteger, 2) \
V(Integer_addFromInteger, 2) \
V(Integer_subFromInteger, 2) \
V(Integer_mulFromInteger, 2) \
V(Integer_truncDivFromInteger, 2) \
V(Integer_moduloFromInteger, 2) \
V(Integer_greaterThanFromInteger, 2) \
V(Integer_equalToInteger, 2) \
Implement fromEnvironment on bool, int and String This implements const constructor fromEnvironment on bool, int and String. The VM have the added -Dname=value option to define the value for the properties. All values are provided by using the -D - nothing is read from the environment. If the resulting value is null or - in the case of int.fromEnvironment - not a number an ArgumentError is thrown. This CL does not have any implementation for dart2js. This is a continuation of the change https://chromiumcodereview.appspot.com/24975002 by iposva@ BUG= R=iposva@google.com Review URL: https://codereview.chromium.org//50983002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29642 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 05:46:57 +00:00
V(Integer_fromEnvironment, 3) \
- Move MathNatives from dart:core to dart:math. - Split out double and integer parsing from MathNatives. Review URL: https://codereview.chromium.org//11316031 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15032 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 19:42:02 +00:00
V(Integer_parse, 1) \
[vm/corelib] More cleanup in integer operations after _Bigint is removed Change-Id: I41da6a37e554ffb8b77f51fda3fee5a15f2b8045 Reviewed-on: https://dart-review.googlesource.com/60441 Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-06-18 18:16:51 +00:00
V(Integer_shlFromInteger, 2) \
V(Integer_shrFromInteger, 2) \
[vm] Support unsigned shift operator int.>>> TEST=runtime/tests/vm/dart/unsigned_shift_right_test.dart and other tests for >>>. Issue https://github.com/dart-lang/sdk/issues/30892 Issue https://github.com/dart-lang/sdk/issues/44914 Change-Id: I7f0a9e1e486be06576c5d9bff3659b0aa6d68c23 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184921 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Régis Crelier <regis@google.com>
2021-02-24 00:14:57 +00:00
V(Integer_ushrFromInteger, 2) \
Implement fromEnvironment on bool, int and String This implements const constructor fromEnvironment on bool, int and String. The VM have the added -Dname=value option to define the value for the properties. All values are provided by using the -D - nothing is read from the environment. If the resulting value is null or - in the case of int.fromEnvironment - not a number an ArgumentError is thrown. This CL does not have any implementation for dart2js. This is a continuation of the change https://chromiumcodereview.appspot.com/24975002 by iposva@ BUG= R=iposva@google.com Review URL: https://codereview.chromium.org//50983002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29642 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 05:46:57 +00:00
V(Bool_fromEnvironment, 3) \
Add bool.hasEnvironment constructor and tests Change-Id: I65ebfcb48bf46292d5ae611ecb7431e0666f753c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139286 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
2020-03-16 11:17:58 +00:00
V(Bool_hasEnvironment, 2) \
- Add a minimal implementation of Capability. - Make RawReceivePort and SendPort VM internal objects. - Rationalize the creation of ports and their handling within the VM. R=asiva@google.com Review URL: https://codereview.chromium.org//243973002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:44:03 +00:00
V(CapabilityImpl_factory, 1) \
- Implement hashCode and == for Capability. R=lrn@google.com Review URL: https://codereview.chromium.org//778983002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42102 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 12:17:48 +00:00
V(CapabilityImpl_equals, 2) \
V(CapabilityImpl_get_hashcode, 1) \
Reland "[ Service / dart:isolate ] Added getPorts RPC and 'debugName' optional" This reverts commit f78c40e32a5b52f6b013a61f1548e0da5a9089a8. Change-Id: Id838b39afcb371d3b50f0009322ecf0fb2080894 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169461 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-10-29 02:52:03 +00:00
V(RawReceivePortImpl_factory, 2) \
- Add a minimal implementation of Capability. - Make RawReceivePort and SendPort VM internal objects. - Rationalize the creation of ports and their handling within the VM. R=asiva@google.com Review URL: https://codereview.chromium.org//243973002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:44:03 +00:00
V(RawReceivePortImpl_get_id, 1) \
V(RawReceivePortImpl_get_sendport, 1) \
Very simple version of Isolates. R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com Review URL: https://codereview.chromium.org//27215002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
V(RawReceivePortImpl_closeInternal, 1) \
[ VM ] Allow for Timer to set its ReceivePort as active / inactive to prevent repeated port allocations Flutter makes heavy use of short-lived Timers which currently causes repeated opening/closing of the Timer port. This change allows for RawReceivePorts to be set active / inactive, allowing for a port to be kept open but not considered alive. Flutter benchmark changes: Before dart-lang/sdk@d5118d5: "notifyListener2_iteration": 545.0 After dart-lang/sdk@d5118d5: "notifyListener2_iteration": 1639.0 With fix: "notifyListener2_iteration": 629.0 Fixes https://github.com/flutter/flutter/issues/69583 TEST=Updated port state tests and verified change against Flutter's microbenchmarks Change-Id: I50ff1a1b0f1f29bcdac958e41c66429e9586fba2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171628 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-11-11 23:42:12 +00:00
V(RawReceivePortImpl_setActive, 2) \
- Add a minimal implementation of Capability. - Make RawReceivePort and SendPort VM internal objects. - Rationalize the creation of ports and their handling within the VM. R=asiva@google.com Review URL: https://codereview.chromium.org//243973002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35325 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 19:44:03 +00:00
V(SendPortImpl_get_id, 1) \
V(SendPortImpl_get_hashcode, 1) \
Make SendPortImpl_internalSend not take a reply port as argument. The reply port is still there in the internal Message structure, where it is used by control messages. BUG= http://dartbug.com/14731 R=fschneider@google.com Review URL: https://codereview.chromium.org//73783002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30302 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 11:28:23 +00:00
V(SendPortImpl_sendInternal_, 2) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(Smi_bitNegate, 1) \
Esoteric bit operations. - bit length - truncate to signed fixed width integer - truncate to unsigned fixed width integer This change is motivated by a program that spends 20-30% of its time here: // TODO(5828): Replace this with a bit-length method on int when available. int n_bitLength = this.n.toRadixString(2).length; See Also https://code.google.com/p/dart/issues/detail?id=5828#c3 https://code.google.com/p/dart/issues/detail?id=6486#c2 https://code.google.com/p/dart/issues/detail?id=5798#c5 https://code.google.com/p/dart/issues/detail?id=12008 R=lrn@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//23645003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27269 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 22:22:26 +00:00
V(Smi_bitLength, 1) \
[vm] Fix soundness issue when awaiting a user-defined Future TEST=language/async/await_user_defined_future_soundness_test Issue: https://github.com/dart-lang/sdk/issues/49345 Change-Id: Ieaaa9baace13dad242c770a710d4d459e135af81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250222 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
2022-06-30 22:53:24 +00:00
V(SuspendState_instantiateClosureWithFutureTypeArgument, 2) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(Mint_bitNegate, 1) \
Esoteric bit operations. - bit length - truncate to signed fixed width integer - truncate to unsigned fixed width integer This change is motivated by a program that spends 20-30% of its time here: // TODO(5828): Replace this with a bit-length method on int when available. int n_bitLength = this.n.toRadixString(2).length; See Also https://code.google.com/p/dart/issues/detail?id=5828#c3 https://code.google.com/p/dart/issues/detail?id=6486#c2 https://code.google.com/p/dart/issues/detail?id=5798#c5 https://code.google.com/p/dart/issues/detail?id=12008 R=lrn@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//23645003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27269 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 22:22:26 +00:00
V(Mint_bitLength, 1) \
Add Debugger.inspect. 1976 here we come! R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//1132153002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45664 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 22:18:43 +00:00
V(Developer_debugger, 2) \
Add getIsolateID to Service class in dart:developer Fixes https://github.com/dart-lang/sdk/issues/23924 BUG= R=asiva@google.com Review URL: https://codereview.chromium.org/2542003002 .
2016-12-01 20:48:49 +00:00
V(Developer_getIsolateIDFromSendPort, 1) \
Provide an API to dart:developer to control the web server hosting the Service Protocol - [x] Add `ServiceProtocolnfo` class to dart:developer. - [x] Add `Service` class to dart:developer. - [x] Add `Service.getInfo` static method to dart:developer. - [x] Add `Service.controlWebServer` static method to dart:developer. API: ```dart /// Information about the service protocol. class ServiceProtocolInfo { /// The major version of the protocol. final int majorVersion; /// The minor version of the protocol. final int minorVersion; /// The Uri to access the service. If the web server is not running, this /// will be null. final Uri serverUri; } /// Access information about the service protocol and control the web server. class Service { /// Get information about the service protocol. static Future<ServiceProtocolInfo> getInfo(); /// Control the web server that the service protocol is accessed through. static Future<ServiceProtocolInfo> controlWebServer({bool enable: false}); } ``` ... and add a randomly generated authentication token path prefix that must be passed in to access the service protocol. Old base url: Observatory listening on http://127.0.0.1:54804/ New base url: Observatory listening on http://127.0.0.1:54804/<token>/ For example: Observatory listening on http://127.0.0.1:54804/PTwjm8Ii8qg=/ Many tools will need to be updated. Fixes #23320 BUG= R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/2438613002 .
2016-10-31 19:32:23 +00:00
V(Developer_getServerInfo, 1) \
V(Developer_getServiceMajorVersion, 0) \
V(Developer_getServiceMinorVersion, 0) \
Add Debugger.inspect. 1976 here we come! R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//1132153002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45664 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 22:18:43 +00:00
V(Developer_inspect, 1) \
Rework service extensions to be safe - When scheduling a service extension to be invoked, store the closure in an array held in the isolate. - At the tail of IsolateMessageHandler::HandleMessage, invoke all pending service extension closures. R=iposva@google.com, turnidge@google.com Review URL: https://codereview.chromium.org//1299493007 .
2015-08-27 18:23:39 +00:00
V(Developer_lookupExtension, 1) \
V(Developer_registerExtension, 2) \
Support piping log data over the service protocol BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org//1241683005 .
2015-07-21 14:54:46 +00:00
V(Developer_log, 8) \
Add dart:developer.postEvent for posting events to the service protocol from Dart code - Add dart:developer.postEvent for posting events to the service protocol. - Add 'Extension' service protocol event stream. - Unit test. - Update service.md - Bug fix for logging stream. R=turnidge@google.com Review URL: https://codereview.chromium.org/1537523002 .
2015-12-17 17:34:52 +00:00
V(Developer_postEvent, 2) \
[ dart:developer / Service ] Added optional 'silenceOutput' parameter to Service.controlWebServer Fixes https://github.com/dart-lang/sdk/issues/31308 Change-Id: I3454592bf0e30bb1a84622493889619f3799ed0b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159541 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2020-08-21 19:32:40 +00:00
V(Developer_webServerControl, 3) \
Avoid just truncating to the nearby int in double.hashCode. Preserves the property that doubles and ints that are equal share the same hash code, but gives different doubles a much higher chance of having different hash codes. BUG=https://github.com/dart-lang/sdk/issues/2884 Change-Id: Ia97164087db568f26ffbbd6854ed9c19f81e9611 Reviewed-on: https://dart-review.googlesource.com/15140 Commit-Queue: Kasper Lund <kasperl@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-10-23 06:47:20 +00:00
V(Double_hashCode, 1) \
isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue. Review URL: https://codereview.chromium.org//11227042 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
V(Double_getIsNegative, 1) \
V(Double_getIsInfinite, 1) \
V(Double_getIsNaN, 1) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(Double_add, 2) \
V(Double_sub, 2) \
V(Double_mul, 2) \
V(Double_div, 2) \
V(Double_remainder, 2) \
V(Double_modulo, 2) \
V(Double_greaterThanFromInteger, 2) \
V(Double_equalToInteger, 2) \
V(Double_greaterThan, 2) \
V(Double_equal, 2) \
V(Double_doubleFromInteger, 2) \
V(Double_round, 1) \
V(Double_floor, 1) \
V(Double_ceil, 1) \
V(Double_truncate, 1) \
V(Double_toInt, 1) \
Avoid unnecessary copying when parsing doubles. R=sgjesse@google.com, vegorov@google.com Review URL: https://codereview.chromium.org//368483004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37863 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 11:59:31 +00:00
V(Double_parse, 3) \
VM: Remove unnecessary _Num class from runtime/lib. BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1874853002 .
2016-04-08 23:25:52 +00:00
V(Double_toString, 1) \
Implement Double.toStringAsFixed. Review URL: http://codereview.chromium.org//8728006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2790 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 22:03:35 +00:00
V(Double_toStringAsFixed, 2) \
V(Double_toStringAsExponential, 2) \
V(Double_toStringAsPrecision, 2) \
Fix 23563: double unary- operator unstable for NANs BUG= R=koda@google.com Review URL: https://codereview.chromium.org//1160453003
2015-06-03 18:00:28 +00:00
V(Double_flipSignBit, 1) \
Reland "[vm] Finish adding support for ECMAScript 2018 features." This work pulls in v8 support for these features with appropriate changes for Dart and closes https://github.com/dart-lang/sdk/issues/34935. This adds support for the following features: * Interpreting patterns as Unicode patterns instead of BMP patterns * the dotAll flag (`/s`) for changing the behavior of '.' to also match line terminators * Escapes for character classes described by Unicode property groups (e.g., \p{Greek} to match all Greek characters, or \P{Greek} for all non-Greek characters). The following TC39 proposals describe some of the added features: * https://github.com/tc39/proposal-regexp-dotall-flag * https://github.com/tc39/proposal-regexp-unicode-property-escapes These additional changes are included: * Extends named capture group names to include the full range of identifier characters supported by ECMAScript, not just ASCII. * Changing the RegExp interface to return RegExpMatch objects, not Match objects, so that downcasting is not necessary to use named capture groups from Dart **Note**: The changes to the RegExp interface are a breaking change for implementers of the RegExp interface. Current users of the RegExp interface (i.e., code using Dart RegExp objects) will not be affected. Change-Id: Ie62e6082a0e2fedc1680ef2576ce0c6db80fc19a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100641 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Stevie Strickland <sstrickl@google.com>
2019-04-29 09:11:48 +00:00
V(RegExp_factory, 6) \
Simpler regex names: C++ JSRegExp -> RegExp Dart _JSSyntaxRegExp -> _RegExp Function RegExp.:irregexp: pattern -> RegExp.:matcher: pattern R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/1815333002 .
2016-03-22 00:21:05 +00:00
V(RegExp_getPattern, 1) \
V(RegExp_getIsMultiLine, 1) \
V(RegExp_getIsCaseSensitive, 1) \
Reland "[vm] Finish adding support for ECMAScript 2018 features." This work pulls in v8 support for these features with appropriate changes for Dart and closes https://github.com/dart-lang/sdk/issues/34935. This adds support for the following features: * Interpreting patterns as Unicode patterns instead of BMP patterns * the dotAll flag (`/s`) for changing the behavior of '.' to also match line terminators * Escapes for character classes described by Unicode property groups (e.g., \p{Greek} to match all Greek characters, or \P{Greek} for all non-Greek characters). The following TC39 proposals describe some of the added features: * https://github.com/tc39/proposal-regexp-dotall-flag * https://github.com/tc39/proposal-regexp-unicode-property-escapes These additional changes are included: * Extends named capture group names to include the full range of identifier characters supported by ECMAScript, not just ASCII. * Changing the RegExp interface to return RegExpMatch objects, not Match objects, so that downcasting is not necessary to use named capture groups from Dart **Note**: The changes to the RegExp interface are a breaking change for implementers of the RegExp interface. Current users of the RegExp interface (i.e., code using Dart RegExp objects) will not be affected. Change-Id: Ie62e6082a0e2fedc1680ef2576ce0c6db80fc19a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100641 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Stevie Strickland <sstrickl@google.com>
2019-04-29 09:11:48 +00:00
V(RegExp_getIsUnicode, 1) \
V(RegExp_getIsDotAll, 1) \
Simpler regex names: C++ JSRegExp -> RegExp Dart _JSSyntaxRegExp -> _RegExp Function RegExp.:irregexp: pattern -> RegExp.:matcher: pattern R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/1815333002 .
2016-03-22 00:21:05 +00:00
V(RegExp_getGroupCount, 1) \
[VM] Partial support for named regexp captures. See https://github.com/tc39/proposal-regexp-named-groups for a high-level description of the feature and examples. This is one of the features requested in https://github.com/dart-lang/sdk/issues/34935. This is a partial implementation because while there is a way to retrieve groups via Dart by name, it requires casting the returned Match to the new RegExpMatch interface to avoid changing the RegExp interface. Changing the RegExp interface will happen in a future update, since there are other planned changes to the RegExp interface coming soon and that way we only change it once. See https://github.com/dart-lang/sdk/issues/36171 for more details on the planned changes. Also, since only BMP regular expressions are supported, not full Unicode ones (i.e., those with the /u flag in ECMAscript), \k<NAME> will only be parsed as a named back reference if there are named captures in the string. Otherwise, the \k will be parsed as the identity escape for backwards compatibility. The new tests illustrate this difference. Change-Id: Ieeb0374813db78924c9aa8ac3e652dfb6d4a5934 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95461 Commit-Queue: Stevie Strickland <sstrickl@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Jenny Messerly <jmesserly@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-03-19 10:40:15 +00:00
V(RegExp_getGroupNameMap, 1) \
Simpler regex names: C++ JSRegExp -> RegExp Dart _JSSyntaxRegExp -> _RegExp Function RegExp.:irregexp: pattern -> RegExp.:matcher: pattern R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/1815333002 .
2016-03-22 00:21:05 +00:00
V(RegExp_ExecuteMatch, 3) \
VM: Optimize RegExp.matchAsPrefix(...) by generating a sticky RegExp specialization. This is the same as a sticky RegExp flag in ES2015. Overlay some RegExp fields on top of each other - given that they should never be used simultaneously. BUG=http://dartbug.com/27810 R=rmacnak@google.com Review URL: https://codereview.chromium.org/2510783002 .
2016-11-17 16:46:21 +00:00
V(RegExp_ExecuteMatchSticky, 3) \
[vm/corelib] Remove GrowableArrayMarker hack. GrowableArrayMarker was a class that implemented int and was used to enable implementation of default List factory constructor in pure Dart: factory List([int length = GROWABLE_ARRAY_MARKER]) { return identical(length, GROWABLE_ARRAY_MARKER) ? new _GrowableList<E>(0) : new _List<E>(length); } Its existence complicated all kinds of things in the VM and it is finally time to remove it. Instead we build List factory body directly in IL. This CL also provides inlining rule for `new List(n)` case. Change-Id: I870751658a4ac17fce649c9ac70395ff88a5436c Reviewed-on: https://dart-review.googlesource.com/57262 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-05-30 13:44:43 +00:00
V(List_new, 2) \
- Rename arrays to lists: _ObjectArray -> _List _GrowableObjectArray -> _GrowableList _ImmutableArray -> _ImmutableList R=srdjan@google.com Review URL: https://codereview.chromium.org//25813002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28189 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 00:15:14 +00:00
V(List_allocate, 2) \
V(List_getIndexed, 2) \
V(List_setIndexed, 3) \
V(List_getLength, 1) \
Improve List.sublist and List.toList for large lists. - Merge array allocation and List._copyFromObjectArray to provide memmove fast path; - In optimizer given v2 = CreateArray(v0, v1) fold v2.length load to v1; BUG= R=iposva@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//536043002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39831 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 20:36:01 +00:00
V(List_slice, 4) \
Fix 16099: Invocation's positionalArguments contains an immutable array. R=asiva@google.com Review URL: https://codereview.chromium.org//139663003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31845 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 19:14:45 +00:00
V(ImmutableList_from, 4) \
Make String.fromCharCodes take start/end. This avoids having to make a sublist of a list of character codes before passing it to String.fromCharCodes. new String.fromCharCodes(codes.sublist(start, end)) becomes just new String.fromCharCodes(codes, start, end) R=floitsch@google.com, sgjesse@google.com Review URL: https://codereview.chromium.org//515183002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40672 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-25 10:45:24 +00:00
V(StringBase_createFromCodePoints, 3) \
Make StringBase._substringUnchecked a native function. This avoids making a throw-away list on every substring operation. Fixed the underscore on the function name while I was at it. Review URL: https://chromiumcodereview.appspot.com//10874038 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11262 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 21:48:40 +00:00
V(StringBase_substringUnchecked, 3) \
Avoid extra duplication of substrings during string.replaceAll. R=asiva@google.com, zerny@google.com Review URL: https://codereview.chromium.org//858543002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43059 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 08:27:42 +00:00
V(StringBase_joinReplaceAllResult, 4) \
Change VM's string-buffer patch to use a Uin16Array as backing buffer. Review URL: https://codereview.chromium.org//12421002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19679 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:21:52 +00:00
V(StringBuffer_createStringFromUint16Array, 3) \
Implement faster splitting with empty string as pattern. Add special native for computing substring of OneByteString (preparation for instrinsic). Review URL: https://codereview.chromium.org//11416270 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15548 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 22:55:09 +00:00
V(OneByteString_substringUnchecked, 3) \
Make String.fromCharCodes take start/end. This avoids having to make a sublist of a list of character codes before passing it to String.fromCharCodes. new String.fromCharCodes(codes.sublist(start, end)) becomes just new String.fromCharCodes(codes, start, end) R=floitsch@google.com, sgjesse@google.com Review URL: https://codereview.chromium.org//515183002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40672 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-25 10:45:24 +00:00
V(OneByteString_allocateFromOneByteList, 3) \
Create string efficiently from Uint16List/View. R=asiva@google.com, fschneider@google.com Review URL: https://codereview.chromium.org//864463002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43235 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 12:44:44 +00:00
V(TwoByteString_allocateFromTwoByteList, 3) \
Make hashCode a getter and not a method. Review URL: https://codereview.chromium.org//11191078 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
V(String_getHashCode, 1) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(String_getLength, 1) \
V(String_charAt, 2) \
Remove deprecated string features. Make String.codeUnits return a List. Review URL: https://codereview.chromium.org//12282038 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
V(String_codeUnitAt, 2) \
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
V(String_concat, 2) \
Implement fromEnvironment on bool, int and String This implements const constructor fromEnvironment on bool, int and String. The VM have the added -Dname=value option to define the value for the properties. All values are provided by using the -D - nothing is read from the environment. If the resulting value is null or - in the case of int.fromEnvironment - not a number an ArgumentError is thrown. This CL does not have any implementation for dart2js. This is a continuation of the change https://chromiumcodereview.appspot.com/24975002 by iposva@ BUG= R=iposva@google.com Review URL: https://codereview.chromium.org//50983002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29642 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 05:46:57 +00:00
V(String_fromEnvironment, 3) \
Implement case mapping using the Unicode default case mapping algorithm. BUG=5425968 Review URL: http://codereview.chromium.org//8333001 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@616 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-21 20:33:29 +00:00
V(String_toLowerCase, 1) \
V(String_toUpperCase, 1) \
Improve string library performance. String concat and indexOf. Rename String concatAll to concatRange. Optimize concatRange for OneByteStrings (avoids natives), optimize indexOf for one character onByteStrings. R=iposva@google.com Review URL: https://codereview.chromium.org//42443002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29472 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 18:18:40 +00:00
V(String_concatRange, 3) \
Remove int.pow and double.pow from VM library. BUG= http://dartbug.com/10268 R=regis@google.com Review URL: https://codereview.chromium.org//23129005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26340 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 08:13:13 +00:00
V(Math_doublePow, 2) \
- Do not rely on time to seed the default PRNG. R=asiva@google.com Review URL: https://codereview.chromium.org//200483003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33704 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 17:30:05 +00:00
V(Random_initialSeed, 0) \
Add a 'secure' constructor to Random in dart:math returning a cryptographically secure random generator which reads from the entropy source provided by the embedder for every generated random value. Add a test. Fixes #1746. R=lrn@google.com Review URL: https://codereview.chromium.org/1398453004 .
2015-10-15 17:16:03 +00:00
V(SecureRandom_getBytes, 1) \
Add microsecond support to DateTime. R=iposva@google.com, lrn@google.com Review URL: https://codereview.chromium.org/1493033003 .
2015-12-08 23:46:46 +00:00
V(DateTime_currentTimeMicros, 0) \
V(DateTime_timeZoneName, 1) \
V(DateTime_timeZoneOffsetInSeconds, 1) \
Add optional message argument to assert statements in the VM. Add flag --assert-message to control the feature. BUG=#24215 R=regis@google.com Review-Url: https://codereview.chromium.org/2574003003 .
2016-12-14 19:05:19 +00:00
V(AssertionError_throwNew, 3) \
[vm/nnbd] Non-null assertions in NNBD weak mode Fixes https://github.com/dart-lang/sdk/issues/42357 Change-Id: I07341ba02361201ec2130fb7b6cb87a25b9b5f51 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151662 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Leaf Petersen <leafp@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Régis Crelier <regis@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-06-18 20:02:42 +00:00
V(AssertionError_throwNewSource, 4) \
Add `Error.throwWithStackTrace` function which throws an error and stack. Allows throwing an error with an existing stack trace, instead of always creating a new stack traces. Fixes #30741 Bug: https://github.com/dart-lang/sdk/issues/30741 TEST=corelib/error_throw_with_stacktrace_test.dart Change-Id: Iea77b4a8eb5e0cab4cd0d75432d033256c9f79fc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219522 Commit-Queue: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
2021-11-08 15:51:32 +00:00
V(Error_throwWithStackTrace, 2) \
Add StackTrace.current getter. R=floitsch@google.com, iposva@google.com, sra@google.com Review URL: https://codereview.chromium.org/1448003002.
2015-11-24 07:26:03 +00:00
V(StackTrace_current, 0) \
[vm] Delete BoundedType class in VM. In Dart2, type bounds checking is either performed by the common front-end or by explicitly generated code, but not by type finalization or runtime anymore, as it was done in Dart1. Consequently, the class BoundedType is not needed anymore, and malbounded or malformed types are not seen by the runtime either. Change-Id: I5d6e4c68d153d6730fa7ff7f6d9dcfa611299c16 Reviewed-on: https://dart-review.googlesource.com/c/86687 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Samir Jindel <sjindel@google.com>
2018-12-10 23:15:27 +00:00
V(TypeError_throwNew, 4) \
Update stopwatch to use patching to share sources instead of exposing a Clock class. R=lrn@google.com,ajohnsen@google.com BUG= Review URL: https://chromiumcodereview.appspot.com//10831327 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10715 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-15 12:06:17 +00:00
V(Stopwatch_now, 0) \
V(Stopwatch_frequency, 0) \
Reland "[vm] Generate event ids for synchronous begin and end events." Fix transposed id and timestamp. TEST=Instruments, ci Bug: https://github.com/dart-lang/sdk/issues/49178 Change-Id: I2c2650f28050b179d26e1269729727f58201a8a8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251581 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2022-07-22 19:13:47 +00:00
V(Timeline_getNextTaskId, 0) \
Add Timeline to dart:developer - This CL only adds support for synchronous blocks of time. A follow up CL will add asynchronous blocks of time. - Reports true thread id to tracing system. This is an improvement over Mojo's tracing helper. - Dart events are included in individual isolate traces and global traces obtained via the embedders API. - Dart events are included in the write to disk path (--timeline_dir). R=rmacnak@google.com Review URL: https://codereview.chromium.org//1377663002 .
2015-10-01 16:30:47 +00:00
V(Timeline_getTraceClock, 0) \
Add an intrinsified early out path for Dart timeline calls BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1985813002 .
2016-05-17 16:45:28 +00:00
V(Timeline_isDartStreamEnabled, 0) \
[vm, timeline] Following switch from Duration events to Begin-End event pairs, avoid separate native call transitions to query the monotonic and thread clocks. Bug: https://github.com/dart-lang/sdk/issues/39727 Change-Id: Ie38947c63845f13d660cb4a367681fed31796473 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128564 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
2020-01-02 23:13:06 +00:00
V(Timeline_reportFlowEvent, 5) \
V(Timeline_reportInstantEvent, 3) \
V(Timeline_reportTaskEvent, 5) \
Simplify the VM's typed_data constructors. Remove _new native functions to have one indirection less when constructing typed data lists. BUG= R=asiva@google.com Review URL: https://codereview.chromium.org/1782003002 .
2016-03-10 08:38:08 +00:00
V(TypedData_Int8Array_new, 2) \
V(TypedData_Uint8Array_new, 2) \
V(TypedData_Uint8ClampedArray_new, 2) \
V(TypedData_Int16Array_new, 2) \
V(TypedData_Uint16Array_new, 2) \
V(TypedData_Int32Array_new, 2) \
V(TypedData_Uint32Array_new, 2) \
V(TypedData_Int64Array_new, 2) \
V(TypedData_Uint64Array_new, 2) \
V(TypedData_Float32Array_new, 2) \
V(TypedData_Float64Array_new, 2) \
V(TypedData_Float32x4Array_new, 2) \
V(TypedData_Int32x4Array_new, 2) \
V(TypedData_Float64x2Array_new, 2) \
[vm] Make use of the new TypedDataBase to avoid redundant code in the runtime. Reduces VM code size by about 18k. TEST=ci Change-Id: Ic0dbdb6a7807a0f0d37333c6f32bed5cb3e7b905 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202543 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2021-06-08 19:15:38 +00:00
V(TypedDataBase_length, 1) \
V(TypedDataBase_setRange, 7) \
Implement 'dart:typeddata' directly in the VM instead of using 'dart:scalarlist' Review URL: https://codereview.chromium.org//12544015 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19656 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 21:50:33 +00:00
V(TypedData_GetInt8, 2) \
V(TypedData_SetInt8, 3) \
V(TypedData_GetUint8, 2) \
V(TypedData_SetUint8, 3) \
V(TypedData_GetInt16, 2) \
V(TypedData_SetInt16, 3) \
V(TypedData_GetUint16, 2) \
V(TypedData_SetUint16, 3) \
V(TypedData_GetInt32, 2) \
V(TypedData_SetInt32, 3) \
V(TypedData_GetUint32, 2) \
V(TypedData_SetUint32, 3) \
V(TypedData_GetInt64, 2) \
V(TypedData_SetInt64, 3) \
V(TypedData_GetUint64, 2) \
V(TypedData_SetUint64, 3) \
V(TypedData_GetFloat32, 2) \
V(TypedData_SetFloat32, 3) \
V(TypedData_GetFloat64, 2) \
V(TypedData_SetFloat64, 3) \
Review changes Review URL: https://codereview.chromium.org//12982010 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20559 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 14:44:15 +00:00
V(TypedData_GetFloat32x4, 2) \
V(TypedData_SetFloat32x4, 3) \
Fix 15413: setRange for views with overlapping buffers. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//124383007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31528 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:48:46 +00:00
V(TypedData_GetInt32x4, 2) \
V(TypedData_SetInt32x4, 3) \
Add Float64x2, Float64x2List, etc... with runtime and dart2js implementations R=sra@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//148043003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32196 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 15:28:05 +00:00
V(TypedData_GetFloat64x2, 2) \
V(TypedData_SetFloat64x2, 3) \
[VM] Define layout of _*ArrayView/_ByteDataView in C+++ This removes the 3 fields from the classes in Dart and instead describes the layout in C++ via a RawTypedDataView class (as already do with normal RawTypedData). The existing "semi" TypedDataView handle class is changed to be a real handle class. This decreases performance of some microbenchmarks due to field guards not being used anymore (before the JIT could add a field guard to view classes guarding that only normal typed data is used as backing store (and not e.g. external typed data) Issue https://github.com/dart-lang/sdk/issues/35154 Issue https://github.com/dart-lang/sdk/issues/31954 Change-Id: I7a0022b843a4c0fa69f53dedcc4c7bd2117cdc37 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96806 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2019-03-15 21:24:15 +00:00
V(TypedDataView_ByteDataView_new, 4) \
V(TypedDataView_Int8ArrayView_new, 4) \
V(TypedDataView_Uint8ArrayView_new, 4) \
V(TypedDataView_Uint8ClampedArrayView_new, 4) \
V(TypedDataView_Int16ArrayView_new, 4) \
V(TypedDataView_Uint16ArrayView_new, 4) \
V(TypedDataView_Int32ArrayView_new, 4) \
V(TypedDataView_Uint32ArrayView_new, 4) \
V(TypedDataView_Int64ArrayView_new, 4) \
V(TypedDataView_Uint64ArrayView_new, 4) \
V(TypedDataView_Float32ArrayView_new, 4) \
V(TypedDataView_Float64ArrayView_new, 4) \
V(TypedDataView_Float32x4ArrayView_new, 4) \
V(TypedDataView_Int32x4ArrayView_new, 4) \
V(TypedDataView_Float64x2ArrayView_new, 4) \
V(TypedDataView_offsetInBytes, 1) \
V(TypedDataView_typedData, 1) \
[ VM / dart:typed_data ] Fixed issue where null could be passed for simd types in AOT Arguments to simd type constructors were being checked in the bootstrap natives entrypoint but not elsewhere. Checking for null in Dart code ensures that we don't accidentally miss these checks in AOT. The changes to sdk_nnbd are required in order to ensure the number of arguments passed to native code match the number of arguments from the non-NNBD implementation (we needed to remove the implicit type args parameter). Fixes https://github.com/dart-lang/sdk/issues/39518 Change-Id: Iaf7d8790c154f1e85db613b6dc84004c8013df9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126905 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-12-09 15:29:27 +00:00
V(Float32x4_fromDoubles, 4) \
V(Float32x4_splat, 1) \
Fix 15413: setRange for views with overlapping buffers. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//124383007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31528 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:48:46 +00:00
V(Float32x4_fromInt32x4Bits, 2) \
Add Float64x2, Float64x2List, etc... with runtime and dart2js implementations R=sra@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//148043003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32196 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 15:28:05 +00:00
V(Float32x4_fromFloat64x2, 2) \
Review changes Review URL: https://codereview.chromium.org//12982010 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20559 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 14:44:15 +00:00
V(Float32x4_zero, 1) \
V(Float32x4_add, 2) \
V(Float32x4_negate, 1) \
V(Float32x4_sub, 2) \
V(Float32x4_mul, 2) \
V(Float32x4_div, 2) \
V(Float32x4_cmplt, 2) \
V(Float32x4_cmplte, 2) \
V(Float32x4_cmpgt, 2) \
V(Float32x4_cmpgte, 2) \
V(Float32x4_cmpequal, 2) \
V(Float32x4_cmpnequal, 2) \
V(Float32x4_scale, 2) \
V(Float32x4_abs, 1) \
V(Float32x4_clamp, 3) \
V(Float32x4_getX, 1) \
V(Float32x4_getY, 1) \
V(Float32x4_getZ, 1) \
V(Float32x4_getW, 1) \
Add signMask getter to Float32x4 R=srdjan@google.com, zra@google.com Review URL: https://codereview.chromium.org//22947006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26394 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 21:35:53 +00:00
V(Float32x4_getSignMask, 1) \
Add all 256 shuffle methods to Float32x4 R=srdjan@google.com Review URL: https://codereview.chromium.org//19564014 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25227 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 17:03:09 +00:00
V(Float32x4_shuffle, 2) \
SIMD shuffle API changes R=srdjan@google.com, zra@google.com Review URL: https://codereview.chromium.org//51373004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29723 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 07:09:54 +00:00
V(Float32x4_shuffleMix, 3) \
Review changes Review URL: https://codereview.chromium.org//12982010 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20559 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 14:44:15 +00:00
V(Float32x4_setX, 2) \
V(Float32x4_setY, 2) \
V(Float32x4_setZ, 2) \
V(Float32x4_setW, 2) \
V(Float32x4_min, 2) \
V(Float32x4_max, 2) \
V(Float32x4_sqrt, 1) \
V(Float32x4_reciprocal, 1) \
V(Float32x4_reciprocalSqrt, 1) \
[ VM / dart:typed_data ] Fixed issue where null could be passed for simd types in AOT Arguments to simd type constructors were being checked in the bootstrap natives entrypoint but not elsewhere. Checking for null in Dart code ensures that we don't accidentally miss these checks in AOT. The changes to sdk_nnbd are required in order to ensure the number of arguments passed to native code match the number of arguments from the non-NNBD implementation (we needed to remove the implicit type args parameter). Fixes https://github.com/dart-lang/sdk/issues/39518 Change-Id: Iaf7d8790c154f1e85db613b6dc84004c8013df9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126905 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-12-09 15:29:27 +00:00
V(Float64x2_fromDoubles, 2) \
V(Float64x2_splat, 1) \
Add Float64x2, Float64x2List, etc... with runtime and dart2js implementations R=sra@google.com, srdjan@google.com Review URL: https://codereview.chromium.org//148043003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32196 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 15:28:05 +00:00
V(Float64x2_zero, 1) \
V(Float64x2_fromFloat32x4, 2) \
V(Float64x2_add, 2) \
V(Float64x2_negate, 1) \
V(Float64x2_sub, 2) \
V(Float64x2_mul, 2) \
V(Float64x2_div, 2) \
V(Float64x2_scale, 2) \
V(Float64x2_abs, 1) \
V(Float64x2_clamp, 3) \
V(Float64x2_getX, 1) \
V(Float64x2_getY, 1) \
V(Float64x2_getSignMask, 1) \
V(Float64x2_setX, 2) \
V(Float64x2_setY, 2) \
V(Float64x2_min, 2) \
V(Float64x2_max, 2) \
V(Float64x2_sqrt, 1) \
[ VM / dart:typed_data ] Fixed issue where null could be passed for simd types in AOT Arguments to simd type constructors were being checked in the bootstrap natives entrypoint but not elsewhere. Checking for null in Dart code ensures that we don't accidentally miss these checks in AOT. The changes to sdk_nnbd are required in order to ensure the number of arguments passed to native code match the number of arguments from the non-NNBD implementation (we needed to remove the implicit type args parameter). Fixes https://github.com/dart-lang/sdk/issues/39518 Change-Id: Iaf7d8790c154f1e85db613b6dc84004c8013df9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126905 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-12-09 15:29:27 +00:00
V(Int32x4_fromInts, 4) \
V(Int32x4_fromBools, 4) \
Fix 15413: setRange for views with overlapping buffers. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//124383007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31528 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:48:46 +00:00
V(Int32x4_fromFloat32x4Bits, 2) \
V(Int32x4_or, 2) \
V(Int32x4_and, 2) \
V(Int32x4_xor, 2) \
V(Int32x4_add, 2) \
V(Int32x4_sub, 2) \
V(Int32x4_getX, 1) \
V(Int32x4_getY, 1) \
V(Int32x4_getZ, 1) \
V(Int32x4_getW, 1) \
V(Int32x4_setX, 2) \
V(Int32x4_setY, 2) \
V(Int32x4_setZ, 2) \
V(Int32x4_setW, 2) \
V(Int32x4_getSignMask, 1) \
V(Int32x4_shuffle, 2) \
V(Int32x4_shuffleMix, 3) \
V(Int32x4_getFlagX, 1) \
V(Int32x4_getFlagY, 1) \
V(Int32x4_getFlagZ, 1) \
V(Int32x4_getFlagW, 1) \
V(Int32x4_setFlagX, 2) \
V(Int32x4_setFlagY, 2) \
V(Int32x4_setFlagZ, 2) \
V(Int32x4_setFlagW, 2) \
V(Int32x4_select, 3) \
[vm/sendandexit] Introduce Isolate.exit([port, message]). This exits current isolate immediately. If [port] is provided, then [message] is verified and sent out as isolate exits. TEST=ci Fixes https://github.com/dart-lang/sdk/issues/47164 Change-Id: I513f4d7ceb5d74820f4aee60f5799b7b5193f2e4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214312 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2021-09-30 20:20:24 +00:00
V(Isolate_exit_, 2) \
Add package config support to dart:isolate - Add "static Future<Uri> get packageRoot;", "static Future<Uri> get packageConfig;" and "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class. - Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution: false" parameters to spawnUri. BUG= R=rmacnak@google.com Review URL: https://codereview.chromium.org/1553233002 .
2016-01-13 02:19:04 +00:00
V(Isolate_getCurrentRootUriStr, 0) \
Reland "[ VM / dart:isolate ] Added ability to set names for spawned isolates." This reverts commit 638f13ff3d1439d1938755005448b48d5573b664. Change-Id: Ib5015539b1c93791c2469be6995789f8f0362806 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97845 Commit-Queue: Ben Konyi <bkonyi@google.com> Auto-Submit: Ben Konyi <bkonyi@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2019-03-28 16:39:50 +00:00
V(Isolate_getDebugName, 1) \
[vm/sendandexit] Introduce Isolate.exit([port, message]). This exits current isolate immediately. If [port] is provided, then [message] is verified and sent out as isolate exits. TEST=ci Fixes https://github.com/dart-lang/sdk/issues/47164 Change-Id: I513f4d7ceb5d74820f4aee60f5799b7b5193f2e4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214312 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2021-09-30 20:20:24 +00:00
V(Isolate_getPortAndCapabilitiesOfCurrentIsolate, 0) \
[vm] Experimental ability to spawn isolate from kernel blob in memory TEST=runtime/tests/vm/dart/spawn_uri_from_kernel_blob_test.dart Change-Id: Ieb327f0350d5d8ea1d344c64aa3dd217125da5fe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232682 Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
2022-02-23 16:55:52 +00:00
V(Isolate_registerKernelBlob, 1) \
V(Isolate_unregisterKernelBlob, 1) \
[vm/sendandexit] Introduce Isolate.exit([port, message]). This exits current isolate immediately. If [port] is provided, then [message] is verified and sent out as isolate exits. TEST=ci Fixes https://github.com/dart-lang/sdk/issues/47164 Change-Id: I513f4d7ceb5d74820f4aee60f5799b7b5193f2e4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214312 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2021-09-30 20:20:24 +00:00
V(Isolate_sendOOB, 2) \
V(Isolate_spawnFunction, 10) \
V(Isolate_spawnUri, 12) \
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
V(GrowableList_allocate, 2) \
V(GrowableList_getIndexed, 2) \
V(GrowableList_setIndexed, 3) \
V(GrowableList_getLength, 1) \
V(GrowableList_getCapacity, 1) \
V(GrowableList_setLength, 2) \
V(GrowableList_setData, 2) \
[vm/intrinsics] Introduce dart:_internal.uncheckedCast. This function can be used to avoid checked down casts in the parts of the code where we know by construction that the type of the value matches expectations. Use it to avoid down-cast in the _LinkedHashMap.operator[]. Bug: https://github.com/dart-lang/sdk/issues/31798 Change-Id: I80949bfb84dde7716fc23aeba311931970ce16aa Reviewed-on: https://dart-review.googlesource.com/70511 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-08-20 13:25:10 +00:00
V(Internal_unsafeCast, 1) \
[vm] Native effects Adds a way to express native effects in Dart expressions in kernel. This CL adds a `void _nativeEffect(Object)` to `dart:internal`. The semantics of `_nativeEffect` are to not execute its arguments and return `null`. This CL uses this `_nativeEffect` to make sure that we never execute the struct constructor invocations used to simulate the native behavior of FFI trampolines. Closes: https://github.com/dart-lang/sdk/issues/45607 TEST=tests/ffi(_2)/native_effect_test.dart Change-Id: Ie06de145e49f8b1cae9e148c2d5d97d5cd8e6878 Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,dart-sdk-linux-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194421 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2021-04-09 16:45:13 +00:00
V(Internal_nativeEffect, 1) \
[vm/compiler] Add regression test for many unboxed fields The GC was sometimes incorrectly calculating the "is-unboxed" bit due to shifter >= 64. The change in [0] fixed that issue and this CL is adding a regresion test. Our tests in `runtime/tests/vm/dart/*` have access to `dart:_internal`. To make the newly added test reliable we add a `collectAllGarbage()` native and use it in the test. [0] https://dart-review.googlesource.com/c/sdk/+/143000 Change-Id: Ifb3f16469a9dc58623acdb029b78807ed7fcc857 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148402 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2020-05-18 11:30:57 +00:00
V(Internal_collectAllGarbage, 0) \
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
V(Internal_makeListFixedLength, 1) \
V(Internal_makeFixedListUnmodifiable, 1) \
[VM runtime] Implement support for _extractTypeArguments in the VM (fixes #31805). Update status files. This cl includes implementing these two features on all platforms: 1) Support calling generic functions via DartEntry::InvokeFunction(). 2) Support native generic functions. These are currently allowed, but type arguments are ignored, and therefore not accessible from the C++ side. Change-Id: Id39e8ca46c2ba1ba3d46946c16712a8572ff64ea Reviewed-on: https://dart-review.googlesource.com/34023 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
2018-01-12 21:32:20 +00:00
V(Internal_extractTypeArguments, 2) \
[VM runtime] Explicitly specify length of parent type argument vector in native call Internal_prependTypeArguments to protect against vector reuse optimization. This is indirectly related to issue #33040. Change-Id: Ic03805135b1c68b59234336e145f5578cf178c74 Reviewed-on: https://dart-review.googlesource.com/53692 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Régis Crelier <regis@google.com>
2018-05-03 23:51:36 +00:00
V(Internal_prependTypeArguments, 4) \
[vm] Correct semantics of bounds-checks on partial instantiation. Fixes #34267. Change-Id: Ieb557e186aa457bac3b99b6817050bde8f8e142f Reviewed-on: https://dart-review.googlesource.com/72161 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-08-31 10:13:51 +00:00
V(Internal_boundsCheckForPartialInstantiation, 2) \
[vm] Add _allocate and _setAt methods to _TwoByteString. Also base these and the corresponding methods in _OneByteString on functions in dart:_internal, so they can be used in other patches. Change-Id: Ibced31758db2959c111a01cdaa46df2971ae4a6c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146784 Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-05-12 17:33:50 +00:00
V(Internal_allocateOneByteString, 1) \
V(Internal_allocateTwoByteString, 1) \
V(Internal_writeIntoOneByteString, 3) \
V(Internal_writeIntoTwoByteString, 3) \
Reland "[vm/concurrency] Ensure fixes to switchable call (due to disabled code) is correctly performed"" If two mutators concurrently execute a switchable call that targets a code object which has been disabled, they both go to runtime trying to fix that switchable call site's object pool. This Cl ensures we use the same logic as for other miss handlers to ensure we properly guard against concurrent accesses. The attached regression test will trigger a segfault - though only with low probability. The changes to first land is: Avoid assuming the target can be called directly. Instead always go through IC Stub when returning from miss handler. We do that since a call site might not provide ARGS_DESC but the target might need it. Fixes https://github.com/dart-lang/sdk/issues/46539 Fixes https://github.com/dart-lang/sdk/issues/46553 TEST=vm/dart{,_2}/isolates/regress_46539_test Change-Id: I18018fa286173d905c52b6e058a6c87b544ff18e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206373 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
2021-07-13 07:30:18 +00:00
V(Internal_deoptimizeFunctionsOnStack, 0) \
Reland "[pkg/native_stack_traces] Support Mach-O dSYM debugging information." This is a reland of commit 08c13f173c3715fd768d768566eeccf1f9f14c3b Fixes test failures on non-x64 architectures, both in the test harness and due to DWARF5 line number program headers having a non-backwards compatible format. (We generate DWARF2 in the ELF snapshot writer, but the assembler used for assembly snapshots may generate DWARF5.) TEST=vm/dart{,_2}/use_dwarf_stack_traces_flag Original change's description: > [pkg/native_stack_traces] Support Mach-O dSYM debugging information. > > TEST=vm/dart{,_2}/use_dwarf_stack_traces_flag > > Bug: https://github.com/dart-lang/sdk/issues/43612 > Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-mac-product-x64-try,pkg-mac-release-arm64-try,vm-kernel-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try > Change-Id: Icda21bb14dcc0cf4784cea118e6ba7dd4edd35aa > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250381 > Commit-Queue: Tess Strickland <sstrickl@google.com> > Reviewed-by: Slava Egorov <vegorov@google.com> Bug: https://github.com/dart-lang/sdk/issues/43612 Change-Id: I8a9cb70e78bc8594bcae004809c5a1be778d691d Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-mac-product-x64-try,pkg-mac-release-arm64-try,vm-kernel-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251464 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
2022-07-22 07:05:26 +00:00
V(Internal_randomInstructionsOffsetInsideAllocateObjectStub, 0) \
[vm] Fix handling of all-dynamic type arguments in noSuchMethod. This fixes #33073 for all code which is relevant to Dart 2. Change-Id: I3956bf9f2bb06f0e67c8b643e8a7765f28464f5f Reviewed-on: https://dart-review.googlesource.com/54260 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Régis Crelier <regis@google.com>
2018-05-10 17:06:42 +00:00
V(InvocationMirror_unpackTypeArguments, 2) \
Revert "Revert "Dart Core Lib change to support generic functions in class NoSuchMethodError."" This reverts commit 8cf9ef22c4f6c85dd0a121b07474d3c95116510f. The expectations in Dart2js and Kernel tests have now been updated. Change-Id: I9d65ff207490cfc783849b1b726db81cf56ecfc2 Reviewed-on: https://dart-review.googlesource.com/9124 Reviewed-by: Régis Crelier <regis@google.com>
2017-09-28 00:27:24 +00:00
V(NoSuchMethodError_existingMethodSignature, 3) \
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
V(Uri_isWindowsPlatform, 0) \
V(UserTag_new, 2) \
V(UserTag_label, 1) \
V(UserTag_defaultTag, 0) \
V(UserTag_makeCurrent, 1) \
V(Profiler_getCurrentTag, 0) \
V(VMService_SendIsolateServiceMessage, 2) \
V(VMService_SendRootServiceMessage, 1) \
DevFS initial implementation. This cl implements an experimental filesystem maintained in the vm, called dart-devfs. This will allow service protocol users to read and write source files while the vm is running. This is needed for the reload support for flutter. R=turnidge@google.com Review URL: https://codereview.chromium.org/2059883003 .
2016-06-10 19:33:50 +00:00
V(VMService_SendObjectRootServiceMessage, 1) \
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
V(VMService_OnStart, 0) \
V(VMService_OnExit, 0) \
V(VMService_OnServerAddressChange, 1) \
Reland "[ VM / Service ] Omit private fields from service responses by default" Adds better error handling in DDS to prevent google3 breakages due to Flutter binary update lag times. This reverts commit 28e958febb21f13f8486b6fe0a05ef8524b57808. TEST=N/A Change-Id: Ida454f0ef3caeedd1b0326c37fef58d4b73557d5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227620 Reviewed-by: Siva Annamalai <asiva@google.com>
2022-01-11 23:35:28 +00:00
V(VMService_ListenStream, 2) \
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
V(VMService_CancelStream, 1) \
V(VMService_RequestAssets, 0) \
V(VMService_DecodeAssets, 1) \
[ VM / Service ] Add support for streaming CPU samples with specific user tags TEST=cpu_sample_streaming_test.dart Change-Id: Ia983217ae2a5da8c3252fafbed8197b4f4a20e2b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224040 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
2021-12-17 00:15:09 +00:00
V(VMService_AddUserTagsToStreamableSampleList, 1) \
V(VMService_RemoveUserTagsFromStreamableSampleList, 1) \
[vm/ffi] Pointer optimize indexed load and store Follow up of https://dart-review.googlesource.com/c/sdk/+/117547 This gets rid of unnecessary allocations in hot loops with indexed loads and stores. Issue: https://github.com/dart-lang/sdk/issues/38172 Change-Id: I37a4b1aba00084e465d47cce79bb9963e1afc104 Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119645 Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-11 15:54:01 +00:00
V(Ffi_loadInt8, 2) \
V(Ffi_loadInt16, 2) \
V(Ffi_loadInt32, 2) \
V(Ffi_loadInt64, 2) \
V(Ffi_loadUint8, 2) \
V(Ffi_loadUint16, 2) \
V(Ffi_loadUint32, 2) \
V(Ffi_loadUint64, 2) \
V(Ffi_loadFloat, 2) \
V(Ffi_loadDouble, 2) \
V(Ffi_loadPointer, 2) \
V(Ffi_loadStruct, 2) \
V(Ffi_storeInt8, 3) \
V(Ffi_storeInt16, 3) \
V(Ffi_storeInt32, 3) \
V(Ffi_storeInt64, 3) \
V(Ffi_storeUint8, 3) \
V(Ffi_storeUint16, 3) \
V(Ffi_storeUint32, 3) \
V(Ffi_storeUint64, 3) \
V(Ffi_storeFloat, 3) \
V(Ffi_storeDouble, 3) \
V(Ffi_storePointer, 3) \
[vm / library] Foreign function interface prototype Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode. `dart:ffi` is experimental and its API is likely to change in the future. Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13 issue: https://github.com/dart-lang/sdk/issues/34452 Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64 Reviewed-on: https://dart-review.googlesource.com/c/80124 Reviewed-by: Samir Jindel <sjindel@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com>
2019-02-13 12:42:47 +00:00
V(Ffi_address, 1) \
V(Ffi_fromAddress, 1) \
[VM/FFI] Adds FFI leaf calls. This CL adds FFI leaf calls by adding `lookupFunction(.., isLeaf)` and `_asFunctionInternal(.., isLeaf)`, which generate FFI leaf calls. These calls skip a lot of the usual frame building and generated <-> native transition overhead. `benchmark/FfiCall/` shows a 1.1x - 4.3x speed-up between the regular FFI calls and their leaf call counterparts (JIT, x64, release). TEST=Adds `tests/ffi{,_2}/vmspecific_leaf_call_test.dart`. Tested FFI tests. Closes: https://github.com/dart-lang/sdk/issues/36707 Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-release-arm64-try,vm-ffi-android-release-arm-try,vm-ffi-android-product-arm64-try,vm-ffi-android-product-arm-try,vm-ffi-android-debug-arm64-try,vm-ffi-android-debug-arm-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-kernel-precomp-tsan-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try Bug: https://github.com/dart-lang/sdk/issues/36707 Change-Id: Id8824f36b0006bf09951207bd004356fe6e9f46e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179768 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2021-05-21 11:12:02 +00:00
V(Ffi_asFunctionInternal, 2) \
Take 3 for '[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).' Fixes the changes to assembly snapshot writer in SIMARM_X64 mode. This unfortunately can't be tested until the ELF loader is available. Take 2 is in patchset 1. Change-Id: Ib8b067dd4f09dcba3b142705e9cb4dfbf4e3eb53 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117726 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-09-18 14:56:27 +00:00
V(Ffi_nativeCallbackFunction, 2) \
V(Ffi_pointerFromFunction, 1) \
[vm / library] Foreign function interface prototype Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode. `dart:ffi` is experimental and its API is likely to change in the future. Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13 issue: https://github.com/dart-lang/sdk/issues/34452 Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64 Reviewed-on: https://dart-review.googlesource.com/c/80124 Reviewed-by: Samir Jindel <sjindel@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com>
2019-02-13 12:42:47 +00:00
V(Ffi_dl_open, 1) \
V(Ffi_dl_lookup, 2) \
[vm/isolate] Add TransferableTypedData class that allows low-cost passing of Uint8List between isolates. TransferableTypedData instances are one-use kind of thing: once receiver materializes it, it can't be used again, once sender sends it out to an isolate, sender can't send it to different isolate. Example of use: sender isolate: ``` Future<TransferableTypedData> consolidateHttpClientResponseBytes(HttpClientResponse response) { final completer = Completer<TransferableTypedData>(); final chunks = <Uint8List>[]; response.listen((List<int> chunk) { chunks.add(chunk); }, onDone: () { completer.complete(TransferableTypedData.fromList(chunks)); }); return completer.future; } ... sendPort.send(await consolidateHttpClientResponseBytes(response)); ``` receiver isolate: ``` RawReceivePort port = RawReceivePort((TransferableTypedData transferable) { Uint8List content = transferable.materialize().asUint8List(); ... }); ``` 31959[tr] and 31960[tr] tests were inspired by dartbug.com/31959, dartbug.com/31960 that this CL attempts to address: ``` ╰─➤ out/ReleaseX64/dart 31960.dart sending... 163ms for round-trip sending... 81ms for round-trip sending... 20ms for round-trip sending... 14ms for round-trip sending... 20ms for round-trip sending... 14ms for round-trip ``` (notice no "since last checking" pauses") vs ``` ╰─➤ out/ReleaseX64/dart 31960.dart sending... 154ms since last checkin 174ms for round-trip sending... 68ms since last checkin 9ms since last checkin 171ms for round-trip sending... 13ms since last checkin 108ms for round-trip sending... 14ms since last checkin 108ms for round-trip sending... 14ms since last checkin 107ms for round-trip ``` Change-Id: I0fcb5ce285394f498c3f1db4414204531f98199d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99623 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-06-06 19:49:07 +00:00
V(Ffi_dl_getHandle, 1) \
[vm/ffi] Add providesSymbol to DynamicLibrary This adds the providesSymbol method to DynamicLibrary. It returns whether the library contains a function with the given name. As per dlsym(3), it is valid for dlsym to return nullptr in a success case if the symbol actually has a NULL value. So I've changed the logic to check for dlerror() after we invoke dlsym(), both in the existing lookup and in the new method. Closes https://github.com/dart-lang/sdk/issues/46192 TEST=tests/ffi(_2)/has_symbol_test.dart Change-Id: Ibcb1c051cc0cdd95a104fe86ef2fc76da5bafb5d Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64-try,vm-ffi-android-debug-arm-try,vm-kernel-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-mac-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201900 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2021-06-02 16:01:43 +00:00
V(Ffi_dl_providesSymbol, 2) \
[vm/ffi] Optimize `Pointer<T>.asTypedList()` This change refactors `_asExternalTypedData` into multiple functions, which are data type specific, e.g `_asExternalTypedDataInt8`. These functions are implemented as recognized methods. Argument checks have previously been performed in the removed runtime entry implementation of `_asExternalTypedData.` These are now handled in Dart. TEST=tests/ffi/external_typed_data_test.dart Closes https://github.com/dart-lang/sdk/issues/39843 Closes https://github.com/dart-lang/sdk/pull/47780 https://github.com/dart-lang/sdk/pull/47780 GitOrigin-RevId: 65763bddd06c633583b4adbf920c32c5a7a3720f Change-Id: I703b350d89004ebe36e70eaa44dda1d9ebb050c7 Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,app-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221360 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2021-11-29 17:38:04 +00:00
V(Ffi_asExternalTypedDataInt8, 2) \
V(Ffi_asExternalTypedDataInt16, 2) \
V(Ffi_asExternalTypedDataInt32, 2) \
V(Ffi_asExternalTypedDataInt64, 2) \
V(Ffi_asExternalTypedDataUint8, 2) \
V(Ffi_asExternalTypedDataUint16, 2) \
V(Ffi_asExternalTypedDataUint32, 2) \
V(Ffi_asExternalTypedDataUint64, 2) \
V(Ffi_asExternalTypedDataFloat, 2) \
V(Ffi_asExternalTypedDataDouble, 2) \
[vm/ffi] DynamicLibrary.process() and DynamicLibrary.executable() Change-Id: I6be84f24f0ac245ba176748e4a3ec1ba782798ce Cq-Include-Trybots: luci.dart.try:vm-kernel-win-debug-x64-try,vm-kernel-mac-debug-x64-try,vm-ffi-android-debug-arm-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113687 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
2019-08-19 14:24:01 +00:00
V(Ffi_dl_processLibrary, 0) \
V(Ffi_dl_executableLibrary, 0) \
[vm/ffi] Adds @FfiNative() support Adds support for marking external functions as @FfiNative's, which will be called using fast FFI calls. Resolution happens by calling out to a new embedder provided Dart_FfiNativeResolver which the embedder can specify via Dart_SetFfiNativeResolver. TEST=vm/cc/DartAPI_FfiNativeResolver Bug: https://github.com/dart-lang/sdk/issues/43889 Change-Id: I3cfff360b05314499a81444b90f4ea0a1b937b0b Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170092 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2021-06-15 05:58:39 +00:00
V(Ffi_GetFfiNativeResolver, 0) \
[vm/ffi] Expose a subset of dart_(native_)api.h for dynamic linking. This CL introduces dart_api_dl.h which exposes a subset of dart_api.h and dart_native_api.h for dynamic linking at runtime through the FFI. Dynamic linking is done through including dart_api_dl.cc in a shared library and passing NativeApi.initializeApiDLData to the init function. This CL also includes Native API versioning to deal with possible version skew between native api version against which native libraries are compiled and the version in the DartVM the code is run on. The subset of symbols in the CL includes handle related symbols, error related symbols, handle scope symbols, and native port sumbols. Design: http://go/dart-ffi-expose-dart-api Closes: https://github.com/dart-lang/sdk/issues/40607 Closes: https://github.com/dart-lang/sdk/issues/36858 Closes: https://github.com/dart-lang/sdk/issues/41319 Closes: https://github.com/flutter/flutter/issues/46887 Closes: https://github.com/flutter/flutter/issues/47061 Misc: Closes: https://github.com/dart-lang/sdk/issues/42260 Change-Id: I9e557808dbc99b341f23964cbddbb05f26d7a6c5 Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-mac-debug-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-nnbd-linux-debug-x64-try,analyzer-nnbd-linux-release-try,front-end-nnbd-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145592 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-18 07:30:43 +00:00
V(DartApiDLInitializeData, 0) \
V(DartApiDLMajorVersion, 0) \
V(DartApiDLMinorVersion, 0) \
V(DartNativeApiFunctionPointer, 1) \
[vm/isolate] Add TransferableTypedData class that allows low-cost passing of Uint8List between isolates. TransferableTypedData instances are one-use kind of thing: once receiver materializes it, it can't be used again, once sender sends it out to an isolate, sender can't send it to different isolate. Example of use: sender isolate: ``` Future<TransferableTypedData> consolidateHttpClientResponseBytes(HttpClientResponse response) { final completer = Completer<TransferableTypedData>(); final chunks = <Uint8List>[]; response.listen((List<int> chunk) { chunks.add(chunk); }, onDone: () { completer.complete(TransferableTypedData.fromList(chunks)); }); return completer.future; } ... sendPort.send(await consolidateHttpClientResponseBytes(response)); ``` receiver isolate: ``` RawReceivePort port = RawReceivePort((TransferableTypedData transferable) { Uint8List content = transferable.materialize().asUint8List(); ... }); ``` 31959[tr] and 31960[tr] tests were inspired by dartbug.com/31959, dartbug.com/31960 that this CL attempts to address: ``` ╰─➤ out/ReleaseX64/dart 31960.dart sending... 163ms for round-trip sending... 81ms for round-trip sending... 20ms for round-trip sending... 14ms for round-trip sending... 20ms for round-trip sending... 14ms for round-trip ``` (notice no "since last checking" pauses") vs ``` ╰─➤ out/ReleaseX64/dart 31960.dart sending... 154ms since last checkin 174ms for round-trip sending... 68ms since last checkin 9ms since last checkin 171ms for round-trip sending... 13ms since last checkin 108ms for round-trip sending... 14ms since last checkin 108ms for round-trip sending... 14ms since last checkin 107ms for round-trip ``` Change-Id: I0fcb5ce285394f498c3f1db4414204531f98199d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99623 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-06-06 19:49:07 +00:00
V(TransferableTypedData_factory, 2) \
Reland "[wasm] Remove dart:wasm" This is a reland of ade333dd54eb75c2abc6030690e3b8e2f5ca8d95 Original change's description: > [wasm] Remove dart:wasm > > I'm not entirely sure why I had to modify a random set of fingerprints > in runtime/vm/compiler/recognized_methods_list.h, but when I did a debug > build it had some fingerprint errors. > > Change-Id: Ib0a0cccb37f2efba509e2b37b6eabe790fa933c4 > TEST= Deleting stuff, so not really necessary > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170620 > Commit-Queue: Liam Appelbe <liama@google.com> > Reviewed-by: Liam Appelbe <liama@google.com> > Reviewed-by: Ryan Macnak <rmacnak@google.com> Change-Id: I0d1388f6312358cc62bb32f5ac7b88a3187223c9 TEST= Deleting stuff, so not really necessary Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171940 Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com> Reviewed-by: Liam Appelbe <liama@google.com>
2020-11-13 20:40:24 +00:00
V(TransferableTypedData_materialize, 1)
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
// List of bootstrap native entry points used in the dart:mirror library.
#define MIRRORS_BOOTSTRAP_NATIVE_LIST(V) \
Changes to mirrors in support of metadata access at runtime. R=iposva@google.com Review URL: https://codereview.chromium.org//16757007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24050 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 21:12:58 +00:00
V(Mirrors_makeLocalClassMirror, 1) \
Reflection on generics. BUG= R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//22292002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25942 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 20:06:56 +00:00
V(Mirrors_makeLocalTypeMirror, 1) \
Reapply "reflectType() dynamic type arguments support (#26012)" This was a pull request: 8a8033a4176a2f26e8ed035497631d539dc1ede5 MirrorsUsed doesn't transitively include reflective information. However, it must still be able to create TypeMirrors for types that are used as return- or parameter types. Initially, the patch checked that TypeMirrors had the correct number of arguments for generic types. This is now disabled. A better approach would be to know if a class has full reflective information, or not. But this would require much bigger changes to the system. R=sigmund@google.com Review-Url: https://codereview.chromium.org/2615943004 .
2017-01-10 14:53:21 +00:00
V(Mirrors_instantiateGenericType, 2) \
Add proper API for creating private symbols wrt a library. BUG=http://dartbug.com/13355 BUG=http://dartbug.com/12358 R=ahe@google.com, asiva@google.com, gbracha@google.com Review URL: https://codereview.chromium.org//24631003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:56:14 +00:00
V(Mirrors_mangleName, 2) \
Implement mirror equality on the VM. Resolves issue 12026. R=asiva@google.com Review URL: https://codereview.chromium.org//21381002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25711 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 16:40:10 +00:00
V(MirrorReference_equals, 2) \
Deal with deferred loading in the VM mirrors. - Invalidate MirrorSystem.libraries when a load completes. - Recheck if a deferred import's target has been loaded before failing. - Allow loading libraries from a LibraryDepedencyMirror. - Propogate compile-time error when attempting to reflect a deferred type. BUG=http://dartbug.com/22592 R=asiva@google.com, gbracha@google.com Review URL: https://codereview.chromium.org//1095903002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45444 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-28 23:47:45 +00:00
V(MirrorSystem_libraries, 0) \
V(MirrorSystem_isolate, 0) \
Reapply "[mirrors] Add IsolateMirror.loadUri." - Forward only kImportTag requests to DFE. This restores the current handling of a kScriptTag request when loading the kernel isolate in the simulators. - Mark dynamic_load_test as failing in the reload stress tests (reload fails to preserve library identity). Change-Id: Ibe6f0a3505b99736a38d566abf3b2151505d7a7e Reviewed-on: https://dart-review.googlesource.com/56706 Reviewed-by: Siva Annamalai <asiva@google.com>
2018-05-29 22:01:01 +00:00
V(IsolateMirror_loadUri, 1) \
Support named and optional positional arguments in reflective invocation. R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//23604003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27134 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 17:12:28 +00:00
V(InstanceMirror_invoke, 5) \
Implement the invoke methods (invoke, getField, setField, newInstance, apply) as internal natives. R=asiva@google.com Review URL: https://codereview.chromium.org//18463003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25024 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 21:14:43 +00:00
V(InstanceMirror_invokeGetter, 3) \
V(InstanceMirror_invokeSetter, 4) \
Fix runtimeType for strings, integers and double: return their interface type. R=asiva@google.com Review URL: https://codereview.chromium.org//25674017 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28286 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 22:08:55 +00:00
V(InstanceMirror_computeType, 1) \
Implement reflect() with Dart code, InstanceMirror.type and ClosureMirror.function with internal code. R=asiva@google.com Review URL: https://codereview.chromium.org//21119002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25594 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 23:57:31 +00:00
V(ClosureMirror_function, 1) \
Add TypeMirror.isSubtypeOf, TypeMirror.isAssignableTo, ClassMirror.isSubclassOf to the API, the VM runtime mirrors and the source mirrors. BUG=http://dartbug.com/12439 BUG=http://dartbug.com/13856 R=gbracha@google.com, johnniwinther@google.com, regis@google.com Review URL: https://codereview.chromium.org//126823004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32577 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 20:41:32 +00:00
V(TypeMirror_subtypeTest, 2) \
Mirrors memory usage tweaks. - Don't build and cache vestigial members/constructors maps. - Avoid creating multiple LibraryMirrors for the same library. - Store infrequently used method flags as a bitfield. - Don't cache MethodMirror source. mirrors_reader_test final heap size: 10.8 -> 8.9 MB (-17.5%) mirrors_reader_test time: 1.55 -> 1.33 seconds (-14.2%) R=asiva@google.com Review URL: https://codereview.chromium.org//1080393006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45352 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:51:49 +00:00
V(ClassMirror_libraryUri, 1) \
Implement ClassMirror.superclass with internal code for ordinary (but not function type) classes. Resolves issue 5794 and issue 9434. R=asiva@google.com Review URL: https://codereview.chromium.org//20465002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25508 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 22:45:07 +00:00
V(ClassMirror_supertype, 1) \
Substitution for type variables in mirrors on instantiated generics. BUG=http://dartbug.com/12282 BUG=http://dartbug.com/13808 R=gbracha@google.com, regis@google.com Review URL: https://codereview.chromium.org//26344006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28495 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 01:51:11 +00:00
V(ClassMirror_supertype_instantiated, 1) \
Ensure FunctionTypeMirrors have a proper reflectee and implement ClassMirror.superinterfaces with internal code. Remove some unnecessary fields and constructor arguments. R=asiva@google.com Review URL: https://codereview.chromium.org//21010005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25599 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 00:29:52 +00:00
V(ClassMirror_interfaces, 1) \
Generic instantiations of mixins and interfaces. Equality of type parameters. BUG=http://dartbug.com/14113 BUG=http://dartbug.com/14114 R=regis@google.com Review URL: https://codereview.chromium.org//27610002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28768 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 00:16:34 +00:00
V(ClassMirror_interfaces_instantiated, 1) \
More reflection of mixin applications in the VM. *Provide ClassMirror.mixin *Hide extra class on the inheritance chain introduced in mixin typedefs *Give mixin applications a simpleName that matches the source language syntax *Update mixin_test to distinguish between members and constructors *Update mixin_test for the mixin application naming scheme BUG=http://dartbug.com/12464 R=ahe@google.com, asiva@google.com Review URL: https://codereview.chromium.org//23190003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26824 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 22:55:53 +00:00
V(ClassMirror_mixin, 1) \
Generic instantiations of mixins and interfaces. Equality of type parameters. BUG=http://dartbug.com/14113 BUG=http://dartbug.com/14114 R=regis@google.com Review URL: https://codereview.chromium.org//27610002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28768 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 00:16:34 +00:00
V(ClassMirror_mixin_instantiated, 2) \
Deal with type arguments of generic local functions in VM mirrors. BUG=http://dartbug.com/14913 R=regis@google.com Review URL: https://codereview.chromium.org//1072443005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44983 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 21:40:51 +00:00
V(ClassMirror_members, 3) \
V(ClassMirror_constructors, 3) \
Make LibraryMirror.members an internal native and lazy. R=asiva@google.com Review URL: https://codereview.chromium.org//20119002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25451 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 23:51:15 +00:00
V(LibraryMirror_members, 2) \
Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors." Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies. BUG=http://dartbug.com/10360 Review URL: https://codereview.chromium.org//189843003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
V(LibraryMirror_libraryDependencies, 2) \
Support named and optional positional arguments in reflective invocation. R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//23604003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27134 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 17:12:28 +00:00
V(ClassMirror_invoke, 5) \
Implement the invoke methods (invoke, getField, setField, newInstance, apply) as internal natives. R=asiva@google.com Review URL: https://codereview.chromium.org//18463003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25024 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 21:14:43 +00:00
V(ClassMirror_invokeGetter, 3) \
V(ClassMirror_invokeSetter, 4) \
Fill in type arguments when creating an object from the mirrors or embedding API. BUG=http://dartbug.com/13186 BUG=http://dartbug.com/12921 R=regis@google.com Review URL: https://codereview.chromium.org//23983026 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27417 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:48:16 +00:00
V(ClassMirror_invokeConstructor, 5) \
BUG= R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org//20216002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25651 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 22:57:59 +00:00
V(ClassMirror_type_variables, 1) \
Reflection on generics. BUG= R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//22292002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25942 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 20:06:56 +00:00
V(ClassMirror_type_arguments, 1) \
Deal with deferred loading in the VM mirrors. - Invalidate MirrorSystem.libraries when a load completes. - Recheck if a deferred import's target has been loaded before failing. - Allow loading libraries from a LibraryDepedencyMirror. - Propogate compile-time error when attempting to reflect a deferred type. BUG=http://dartbug.com/22592 R=asiva@google.com, gbracha@google.com Review URL: https://codereview.chromium.org//1095903002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45444 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-28 23:47:45 +00:00
V(LibraryMirror_fromPrefix, 1) \
Support named and optional positional arguments in reflective invocation. R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//23604003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27134 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 17:12:28 +00:00
V(LibraryMirror_invoke, 5) \
Implement the invoke methods (invoke, getField, setField, newInstance, apply) as internal natives. R=asiva@google.com Review URL: https://codereview.chromium.org//18463003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25024 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 21:14:43 +00:00
V(LibraryMirror_invokeGetter, 3) \
V(LibraryMirror_invokeSetter, 4) \
Reflection on generics. BUG= R=ahe@google.com, regis@google.com Review URL: https://codereview.chromium.org//22292002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25942 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 20:06:56 +00:00
V(TypeVariableMirror_owner, 1) \
V(TypeVariableMirror_upper_bound, 1) \
Implement DeclarationMirror.location for all but ParameterMirrors. - Mark NativeFieldWrapper classes as synthetic. - Mark ClassID fields as synthetic. BUG=http://dartbug.com/22378 R=gbracha@google.com, hausner@google.com Review URL: https://codereview.chromium.org//922023002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43784 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 23:32:20 +00:00
V(DeclarationMirror_location, 1) \
Implement metadata as an internal native. Be honest about which mirrors don't yet support metadata introspection. R=asiva@google.com Review URL: https://codereview.chromium.org//19235015 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25126 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 21:50:54 +00:00
V(DeclarationMirror_metadata, 1) \
Make ClosureMirror handle instances of user-defined classes that implement call. R=asiva@google.com Review URL: https://codereview.chromium.org//22625003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25944 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 20:25:46 +00:00
V(FunctionTypeMirror_call_method, 2) \
ParameterMirror: Implement some missing getters. Fixes issue 11334 and issue 11684 and issue 11567. R=asiva@google.com Review URL: https://codereview.chromium.org//21624006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26086 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 21:38:36 +00:00
V(FunctionTypeMirror_parameters, 2) \
Keep types in signatures of function types properly instantiated as the function type itself gets instantiated. Until now, the signature was kept unchanged and the instantiation was reflected by the type arguments of the function type only. This delayed instantiation would complicate the implementation of generic functions. This cl actually removes type arguments for (non-typedef) function types. The function type is now fully represented by the signature. When the function type is instantiated, a new signature is allocated (instead of a new type argument vector) to hold instantiated result type and formal parameter types. The same applies in the case of typedef function types, however, the type arguments of the typedef are kept as before. This allows for better printing of typedef function types and for finalization of recursive type involving typedefs as type arguments. R=asiva@google.com Review-Url: https://codereview.chromium.org/2793033005 .
2017-04-06 19:28:48 +00:00
V(FunctionTypeMirror_return_type, 1) \
Deal with type arguments of generic local functions in VM mirrors. BUG=http://dartbug.com/14913 R=regis@google.com Review URL: https://codereview.chromium.org//1072443005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44983 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 21:40:51 +00:00
V(MethodMirror_owner, 2) \
ParameterMirror: Implement some missing getters. Fixes issue 11334 and issue 11684 and issue 11567. R=asiva@google.com Review URL: https://codereview.chromium.org//21624006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26086 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 21:38:36 +00:00
V(MethodMirror_parameters, 2) \
Use the runtime for generic subsitution of variable types, return types, parameter types. BUG=http://dartbug.com/14613 BUG=http://dartbug.com/14156 R=gbracha@google.com, regis@google.com Review URL: https://codereview.chromium.org//62273003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30120 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 17:54:59 +00:00
V(MethodMirror_return_type, 2) \
Fix Function.end_token_pos() and implement MethodMirror.source getter. Move .source getter from ClosureMirror to MethodMirror (as the TODO already suggested) and provide an implementation. BUG= R=asiva@google.com, hausner@google.com Review URL: https://codereview.chromium.org//23038010 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26659 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 17:14:07 +00:00
V(MethodMirror_source, 1) \
Use the runtime for generic subsitution of variable types, return types, parameter types. BUG=http://dartbug.com/14613 BUG=http://dartbug.com/14156 R=gbracha@google.com, regis@google.com Review URL: https://codereview.chromium.org//62273003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30120 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 17:54:59 +00:00
V(ParameterMirror_type, 3) \
clang-format runtime/vm R=johnmccutchan@google.com Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 21:54:47 +00:00
V(VariableMirror_type, 2)
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
[vm] Implement `NativeFinalizer` This CL implements `NativeFinalizer` in the GC. `FinalizerEntry`s are extended to track `external_size` and in which `Heap::Space` the finalizable value is. On attaching a native finalizer, the external size is added to the relevant heap. When the finalizable value is promoted from new to old space, the external size is promoted as well. And when a native finalizer is run or is detached, the external size is removed from the relevant heap again. In contrast to Dart `Finalizer`s, `NativeFinalizer`s are run on isolate shutdown. When the `NativeFinalizer`s themselves are collected, the finalizers are not run. Users should stick the native finalizer in a global variable to ensure finalization. We will revisit this design when we add send and exit support, because there is a design space to explore what to do in that case. This current solution promises the least to users. In this implementation native finalizers have a Dart entry to clean up the entries from the `all_entries` field of the finalizer. We should consider using another data structure that avoids the need for this Dart entry. See the TODO left in the code. Bug: https://github.com/dart-lang/sdk/issues/47777 TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Change-Id: I8f594c80c3c344ad83e1f2de10de028eb8456121 Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-ffi-android-debug-arm64c-try,dart-sdk-mac-arm64-try,vm-kernel-mac-release-arm64-try,pkg-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-win-debug-x64c-try,vm-kernel-win-debug-x64-try,vm-kernel-precomp-win-debug-x64c-try,vm-kernel-nnbd-win-release-ia32-try,vm-ffi-android-debug-arm-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-mac-debug-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,benchmark-linux-try,flutter-frontend-try,pkg-linux-debug-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-gcc-linux-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236320 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-03-26 09:41:21 +00:00
#define BOOTSTRAP_FFI_NATIVE_LIST(V) \
V(FinalizerEntry_SetExternalSize, void, (Dart_Handle, intptr_t))
Use the return value of vm native methods to set the return value, based on Siva's earlier suggestion (he actually suggested putting it in the generated stub, which I haven't done). Added SetReturnUnsafe and use it exactly one place so far. Review URL: https://chromiumcodereview.appspot.com//10874072 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11633 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:41:19 +00:00
class BootstrapNatives : public AllStatic {
public:
Allow the native resolver to setup whether it needs the Dart API scope to be setup automatically or not when a native function is invoked. This would allow the embedder to treat some native functions as leaf functions whose invocation can be very light. R=hausner@google.com, zra@google.com Review URL: https://codereview.chromium.org//117723002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31286 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 17:47:56 +00:00
static Dart_NativeFunction Lookup(Dart_Handle name,
int argument_count,
bool* auto_setup_scope);
Use the return value of vm native methods to set the return value, based on Siva's earlier suggestion (he actually suggested putting it in the generated stub, which I haven't done). Added SetReturnUnsafe and use it exactly one place so far. Review URL: https://chromiumcodereview.appspot.com//10874072 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11633 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:41:19 +00:00
[vm] Implement `NativeFinalizer` This CL implements `NativeFinalizer` in the GC. `FinalizerEntry`s are extended to track `external_size` and in which `Heap::Space` the finalizable value is. On attaching a native finalizer, the external size is added to the relevant heap. When the finalizable value is promoted from new to old space, the external size is promoted as well. And when a native finalizer is run or is detached, the external size is removed from the relevant heap again. In contrast to Dart `Finalizer`s, `NativeFinalizer`s are run on isolate shutdown. When the `NativeFinalizer`s themselves are collected, the finalizers are not run. Users should stick the native finalizer in a global variable to ensure finalization. We will revisit this design when we add send and exit support, because there is a design space to explore what to do in that case. This current solution promises the least to users. In this implementation native finalizers have a Dart entry to clean up the entries from the `all_entries` field of the finalizer. We should consider using another data structure that avoids the need for this Dart entry. See the TODO left in the code. Bug: https://github.com/dart-lang/sdk/issues/47777 TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Change-Id: I8f594c80c3c344ad83e1f2de10de028eb8456121 Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-ffi-android-debug-arm64c-try,dart-sdk-mac-arm64-try,vm-kernel-mac-release-arm64-try,pkg-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-win-debug-x64c-try,vm-kernel-win-debug-x64-try,vm-kernel-precomp-win-debug-x64c-try,vm-kernel-nnbd-win-release-ia32-try,vm-ffi-android-debug-arm-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-mac-debug-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,benchmark-linux-try,flutter-frontend-try,pkg-linux-debug-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-gcc-linux-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236320 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-03-26 09:41:21 +00:00
// For use with @FfiNative.
static void* LookupFfiNative(const char* name, uintptr_t argument_count);
[vm] Use consistent signatures for native call wrappers and native function symbolizers. Bug: https://github.com/dart-lang/sdk/issues/39427 Change-Id: I0d52d935c15f4d01d56e5e99bc4b83b31678a6ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146940 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-05-07 16:16:08 +00:00
static const uint8_t* Symbol(Dart_NativeFunction nf);
Add runtime and native entry tags - Split runtime and native entry tags. - Set runtime / native entry address as vm tag in stubs. - Add reverse native entry resolver (pc to name) to public API (breaking change). - Hookup reverse resolver for standalone VM (io + bootstrap + builtin natives). - Runtime entries are registered with tags. - Profiler queries for tag names via the reverse native entry resolver. - Profiler outputs named entry tags as children under parent tag (runtime or native). R=asiva@google.com Review URL: https://codereview.chromium.org//227433004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34941 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 20:26:45 +00:00
Throw AbstractClassInstantiationError if an abstract class is instantiated This is the second try to my previous attempt to implement the new abstract class handling. Instead of a compile-time error, the VM now throws an AbstractClassInstantiationError at runtime if an abstract class is instantiated. Added the new error class to the core library. For now I'm still using the rule that a class is abstract if it is explicitly marked as abstract, or if it defines a new abstract method. Review URL: https://chromiumcodereview.appspot.com//10916039 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11708 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 18:06:42 +00:00
#define DECLARE_BOOTSTRAP_NATIVE(name, ignored) \
[vm] Represent tagged pointers as C++ value types instead of C++ pointer types. This works around bugs in UndefinedBehaviorSanitizer and Clang. Bug: b/28638298 Change-Id: I6be595f9664516019d28017d24559583a1ae3a21 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144354 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2020-04-25 05:21:27 +00:00
static ObjectPtr DN_##name(Thread* thread, Zone* zone, \
NativeArguments* arguments);
Use the return value of vm native methods to set the return value, based on Siva's earlier suggestion (he actually suggested putting it in the generated stub, which I haven't done). Added SetReturnUnsafe and use it exactly one place so far. Review URL: https://chromiumcodereview.appspot.com//10874072 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11633 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:41:19 +00:00
BOOTSTRAP_NATIVE_LIST(DECLARE_BOOTSTRAP_NATIVE)
[vm] Enable mirrors in product mode. Allows building a product mode SDK. Fixes https://github.com/dart-lang/sdk/issues/29972 R=zra@google.com Review-Url: https://codereview.chromium.org/2972883002 .
2017-07-12 19:55:55 +00:00
#if !defined(DART_PRECOMPILED_RUNTIME)
Remove mirrors in product mode (stripped) dart_product before: 5307888 (stripped) dart_product after: 5232976 Reduction in size: 74912 bytes. R=rmacnak@google.com Review URL: https://codereview.chromium.org/1712843002 .
2016-02-22 17:55:20 +00:00
MIRRORS_BOOTSTRAP_NATIVE_LIST(DECLARE_BOOTSTRAP_NATIVE)
#endif
Use the return value of vm native methods to set the return value, based on Siva's earlier suggestion (he actually suggested putting it in the generated stub, which I haven't done). Added SetReturnUnsafe and use it exactly one place so far. Review URL: https://chromiumcodereview.appspot.com//10874072 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11633 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:41:19 +00:00
#undef DECLARE_BOOTSTRAP_NATIVE
[vm] Implement `NativeFinalizer` This CL implements `NativeFinalizer` in the GC. `FinalizerEntry`s are extended to track `external_size` and in which `Heap::Space` the finalizable value is. On attaching a native finalizer, the external size is added to the relevant heap. When the finalizable value is promoted from new to old space, the external size is promoted as well. And when a native finalizer is run or is detached, the external size is removed from the relevant heap again. In contrast to Dart `Finalizer`s, `NativeFinalizer`s are run on isolate shutdown. When the `NativeFinalizer`s themselves are collected, the finalizers are not run. Users should stick the native finalizer in a global variable to ensure finalization. We will revisit this design when we add send and exit support, because there is a design space to explore what to do in that case. This current solution promises the least to users. In this implementation native finalizers have a Dart entry to clean up the entries from the `all_entries` field of the finalizer. We should consider using another data structure that avoids the need for this Dart entry. See the TODO left in the code. Bug: https://github.com/dart-lang/sdk/issues/47777 TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Change-Id: I8f594c80c3c344ad83e1f2de10de028eb8456121 Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-ffi-android-debug-arm64c-try,dart-sdk-mac-arm64-try,vm-kernel-mac-release-arm64-try,pkg-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-win-debug-x64c-try,vm-kernel-win-debug-x64-try,vm-kernel-precomp-win-debug-x64c-try,vm-kernel-nnbd-win-release-ia32-try,vm-ffi-android-debug-arm-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-mac-debug-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,benchmark-linux-try,flutter-frontend-try,pkg-linux-debug-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-gcc-linux-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236320 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-03-26 09:41:21 +00:00
#define DECLARE_BOOTSTRAP_FFI_NATIVE(name, return_type, argument_types) \
static return_type FN_##name argument_types;
BOOTSTRAP_FFI_NATIVE_LIST(DECLARE_BOOTSTRAP_FFI_NATIVE)
#undef DECLARE_BOOTSTRAP_FFI_NATIVE
Use the return value of vm native methods to set the return value, based on Siva's earlier suggestion (he actually suggested putting it in the generated stub, which I haven't done). Added SetReturnUnsafe and use it exactly one place so far. Review URL: https://chromiumcodereview.appspot.com//10874072 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11633 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:41:19 +00:00
};
Initial checkin. git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00
} // namespace dart
Make header include guards great again i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER This lets us remove a hack from the PRESUBMIT.py script that existed for reasons that are no longer valid, and sets us up to add some presubmit checks for the GN build. R=asiva@google.com, rmacnak@google.com Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 07:26:03 +00:00
#endif // RUNTIME_VM_BOOTSTRAP_NATIVES_H_
Reference in a new issue Copy permalink